Add replacement config to generator_pythia8 to replace D*/Sigmac+ by Xic0/Omegac0

[FDUEnrich]

No description provided.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

[fgrosa]

Hi @FDUEnrich thanks a lot for the development!
I have a few comments (see below) and in addition you need to add the test macro corresponding to the new ini file in https://github.com/AliceO2Group/O2DPG/tree/master/MC/config/PWGHF/ini/tests (it is required for every ini file).

[fgrosa]

@klsmith15k apparently the test macro for GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini that you committed is missing. Can you please implement it and open a PR? Thanks!

[klsmith15k]

@fgrosa I apologize for the delay! I followed your instructions and uploaded the test macro with a new PR here. Please let me know if there are any further issues

[fgrosa]

Hi @jackal1-66@sawenzel would it be possible to restart the tests for this PR? The error should have been solved in #2199. Many thanks!

[jackal1-66]

Hello, there are few tests still failing:

Test 16: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini with generator External�[0;31m -> FAILED�[0m
�[0;31mError found in log /sw/BUILD/4262584a411a319d977a5ed874161c22135727bc/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/16_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini_External_dir/o2sim_serverlog�[0m
1384-[11:42:37][INFO] GENEVENT CHANGING STATE TO SERVING
1385-[11:42:37][INFO] Sending 500 particles
1386-[11:42:37][INFO] treating ev 7 part 1 out of 3
1387-[11:42:37][INFO] Sending 500 particles
1388-[11:42:37][INFO] treating ev 7 part 2 out of 3
1389-[11:42:37][INFO] Sending 472 particles
1390-[11:42:37][INFO] treating ev 7 part 3 out of 3
1391-[11:42:37][INFO] Event generation started 1392-[11:42:37][INFO] GENEVENT CHANGING STATE TO WAITEVENT
1393-
1394: *** Break *** segmentation violation
1395-
1396-
1397-
1398-===========================================================
1399-There was a crash.
1400-This is the entire stack trace of all threads:
1401-===========================================================
1402-
1403-Thread 7 (Thread 0x7fa8061ff600 (LWP 5106) "o2-sim-primary-"):
1404-#0 0x00007fa82807f17a in __futex_abstimed_wait_common () from /lib64/libc.so.6

and

Test 38: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini with generator External�[0;31m -> FAILED�[0m
�[0;31mError found in log /sw/BUILD/4262584a411a319d977a5ed874161c22135727bc/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log�[0m
2-
3-Processing External.C...
4---------------------------------
5-# Events: 100
6-# MB events: 80
7-# events injected with 4 quark pair: 10
8-# events injected with 5 quark pair: 10
9-# signal hadrons: 142
10-# signal hadrons decaying in the correct channel: 127
11-Fraction of signals decaying into the correct channel 0.894366 lower than expected
12:(int) 1

Could you please check them out?

[jackal1-66]

Also I checked a bit further and noticed that these tests:

39_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2.ini
9_GeneratorHFTrigger_Xi_Omega_C.ini
7_GeneratorHFTrigger_OmegaCToXiPi.ini
50_GeneratorHF_HFe_ccbar_and_bbar_gap5_Mode2.ini
4_GeneratorJPsiHFCorr_ccbar.ini
54_GeneratorHF_mu_bbbar_gap5_Mode2_accLarge_muTrig.ini
22_GeneratorHF_D2H_bbbar_gap5.ini
51_GeneratorHF_mu_bbbar_gap3_Mode2_accSmall.ini
45_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkgSigmaC.ini
55_GeneratorHF_mu_bbbar_gap5_Mode2_accSmall.ini
52_GeneratorHF_mu_bbbar_gap5_Mode2_accInt_muTrig.ini
34_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2.ini
10_GeneratorHFTrigger_bbbar.ini
37_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DReso.ini
8_GeneratorHFTrigger_XiCToXiPi.ini
38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini
36_GeneratorHF_D2H_ccbar_and_bbbar_gap5.ini
41_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini
25_GeneratorHF_D2H_ccbar_Mode2_OmegaC_NoDecay_pp_ref.ini
40_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons.ini
46_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_pp_ref.ini
48_GeneratorHF_D2H_ccbar_and_bbbar_gap8_Mode2_XiC.ini
33_GeneratorHF_D2H_ccbar_and_bbbar_gap3.ini
42_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC.ini
44_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkg.ini
43_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC_OmegaC.ini
12_GeneratorHF_D2H_bbbar_Bforced_gap5_Mode2.ini
6_GeneratorHFTrigger_Bforced.ini
35_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2_XiC.ini
13_GeneratorHF_D2H_bbbar_BtoDK_gap5_Mode2.ini

Generate more than 2000 Pythia events to complete. Could you please add the line #NEV_TEST> 10 at the beginning of these ini files? They will reduce the required events from 100 to 10, which should be enough for testing, while reducing significantly the processing time.

[fgrosa]

Also I checked a bit further and noticed that these tests:

39_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2.ini
9_GeneratorHFTrigger_Xi_Omega_C.ini
7_GeneratorHFTrigger_OmegaCToXiPi.ini
50_GeneratorHF_HFe_ccbar_and_bbar_gap5_Mode2.ini
4_GeneratorJPsiHFCorr_ccbar.ini
54_GeneratorHF_mu_bbbar_gap5_Mode2_accLarge_muTrig.ini
22_GeneratorHF_D2H_bbbar_gap5.ini
51_GeneratorHF_mu_bbbar_gap3_Mode2_accSmall.ini
45_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkgSigmaC.ini
55_GeneratorHF_mu_bbbar_gap5_Mode2_accSmall.ini
52_GeneratorHF_mu_bbbar_gap5_Mode2_accInt_muTrig.ini
34_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2.ini
10_GeneratorHFTrigger_bbbar.ini
37_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DReso.ini
8_GeneratorHFTrigger_XiCToXiPi.ini
38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini
36_GeneratorHF_D2H_ccbar_and_bbbar_gap5.ini
41_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini
25_GeneratorHF_D2H_ccbar_Mode2_OmegaC_NoDecay_pp_ref.ini
40_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons.ini
46_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_pp_ref.ini
48_GeneratorHF_D2H_ccbar_and_bbbar_gap8_Mode2_XiC.ini
33_GeneratorHF_D2H_ccbar_and_bbbar_gap3.ini
42_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC.ini
44_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkg.ini
43_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC_OmegaC.ini
12_GeneratorHF_D2H_bbbar_Bforced_gap5_Mode2.ini
6_GeneratorHFTrigger_Bforced.ini
35_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2_XiC.ini
13_GeneratorHF_D2H_bbbar_BtoDK_gap5_Mode2.ini

Generate more than 2000 Pythia events to complete. Could you please add the line #NEV_TEST> 10 at the beginning of these ini files? They will reduce the required events from 100 to 10, which should be enough for testing, while reducing significantly the processing time.

Hi @jackal1-66 thanks a lot for the suggestion! I reduced the number of test events in this PR #2216. I also fixed the ones crashing, and reduced even more than 10 the number for few ini files that trigger on very rare particles (hence the actual generation of events is much much larger than 5, order of ~100k actually)

[jackal1-66]

The CI is still red on GitHub, however it's a timeout issue. In particular the list of generators taking a long time is:

32_GeneratorHF_D2H_bbbar_Mode2_OmegaC.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1935.13 s
19_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1090.34 s
61_GeneratorJPsiHFCorr_ccbar.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1019.41 s
46_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 963.383 s
44_GeneratorHF_D2H_bbbar_Mode2_XiC0_XiCplus.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 377.139 s
59_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 354.304 s
54_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 326.443 s

ordered timewise.
This will have to be fixed in the near future (different solution to develop). Testing with the same CI conditions without timeout leads to successful tests, so I am merging this, considering it's a blocker for HF analyses.

[fgrosa]

The CI is still red on GitHub, however it's a timeout issue. In particular the list of generators taking a long time is:

32_GeneratorHF_D2H_bbbar_Mode2_OmegaC.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1935.13 s
19_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1090.34 s
61_GeneratorJPsiHFCorr_ccbar.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1019.41 s
46_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 963.383 s
44_GeneratorHF_D2H_bbbar_Mode2_XiC0_XiCplus.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 377.139 s
59_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 354.304 s
54_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 326.443 s

ordered timewise. This will have to be fixed in the near future (different solution to develop). Testing with the same CI conditions without timeout leads to successful tests, so I am merging this, considering it's a blocker for HF analyses.

Hi @jackal1-66 thanks a lot! Indeed we should find a way to perform the tests, without being limited by the timeout in case many configurations need to be tested. Let's follow this up for the future.

[jackal1-66]

The CI is still red on GitHub, however it's a timeout issue. In particular the list of generators taking a long time is:

32_GeneratorHF_D2H_bbbar_Mode2_OmegaC.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1935.13 s
19_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1090.34 s
61_GeneratorJPsiHFCorr_ccbar.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 1019.41 s
46_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 963.383 s
44_GeneratorHF_D2H_bbbar_Mode2_XiC0_XiCplus.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 377.139 s
59_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay_pp_ref.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 354.304 s
54_GeneratorHF_D2H_bbbar_Mode2_XiC_NoDecay.ini_External_dir/o2dpg-test-sim.log:[INFO] Simulation process took 326.443 s

ordered timewise. This will have to be fixed in the near future (different solution to develop). Testing with the same CI conditions without timeout leads to successful tests, so I am merging this, considering it's a blocker for HF analyses.

Hi @jackal1-66 thanks a lot! Indeed we should find a way to perform the tests, without being limited by the timeout in case many configurations need to be tested. Let's follow this up for the future.

FYI #2250