Skip to content

Add PreCondition overload that takes source and ResolutionContext as parameters - #2252

Merged
jbogard merged 2 commits into
LuckyPennySoftware:masterfrom
ESPNSTI:Issue-2251-Add-PreCondition-Overload
Aug 7, 2017
Merged

Add PreCondition overload that takes source and ResolutionContext as parameters#2252
jbogard merged 2 commits into
LuckyPennySoftware:masterfrom
ESPNSTI:Issue-2251-Add-PreCondition-Overload

Conversation

@ESPNSTI

@ESPNSTIESPNSTI commented Aug 5, 2017

Copy link
Copy Markdown

Added an overload to PreCondition that had both TSource and ResolutionContext as parameters.
Closes#2251.

@lbargaoanu

Copy link
Copy Markdown
Contributor

The test is missing.

@ESPNSTI

Copy link
Copy Markdown
Author

There's no test for the ResolutionContext overload either. :)

I'll see what I can do.

@lbargaoanu

Copy link
Copy Markdown
Contributor

Maybe it's GitHub's fault, but it would be nice if you could fix the diff.

@ESPNSTI

Copy link
Copy Markdown
Author

I'm not sure what's going on, I thought I had set autocrlf to false.
I'll check and see if I can fix it.
Some of the files seem to have inconsistent line endings it seems.

@jbogardjbogard added this to the 6.2.0 milestone Aug 7, 2017
@jbogard
jbogard merged commit 57b5a6f into LuckyPennySoftware:masterAug 7, 2017
@lock

lockBot commented May 6, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@locklockBot locked as resolved and limited conversation to collaborators May 6, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add PreCondition overload

3 participants

@ESPNSTI@lbargaoanu@jbogard