Uh oh!
There was an error while loading. Please reload this page.
Reverse the string based MapFrom - #3336
Conversation
timmi-on-rails
commented
Feb 25, 2020
Here we go, I am done. Feedback codebaseFor me it was hard to follow the code, because the open generic cases are always treated special and this makes the code more complex/nested/partially redundant. |
lbargaoanu
left a comment
There was a problem hiding this comment.
Some cosmetic changes. Hopefully I didn't break anything.
Thanks!
lbargaoanu
commented
Feb 26, 2020
If this fixes the attributes stuff, you might want to add a test for it. |
timmi-on-rails
commented
Feb 26, 2020
It doesn't fix attributes, but I can work out a fix and test for that. |
lbargaoanu
commented
Feb 26, 2020
Separate. |
Ok, your changes look good. |
lbargaoanu
commented
Mar 8, 2020
@jbogard Merge? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes#3329.