From 615893b24fa2be21e245ef1e47ae2fa1e2e12981 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 16:00:29 +0000 Subject: [PATCH 1/3] =?UTF-8?q?docs(issues):=20queue=20#210=20correction?= =?UTF-8?q?=20=E2=80=94=20the=20prescribed=20fix=20would=20be=20reverted?= =?UTF-8?q?=20by=20Next?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 2026-08-12 re-scope on #210 was half wrong in a way that would have cost the next agent a change Next silently undoes: - `npm run typecheck` already runs `tsc -p tsconfig.typecheck.json` (package.json:38-39), which excludes `.next/**` outright — the row's claim that `npm run ensure` breaks repo-wide typecheck is false, and tsconfig.typecheck.json's own header cites that row as its reason. - Dropping `.next/dev/types/**/*.ts` from tsconfig.json's `include` does not hold: Next emits the glob deliberately (type-paths.js:34-36) and writeConfigurationDefaults.js:305-315 pushes any missing type glob back into an existing `include` on every dev/build run. What remains is narrower and explicitly unproven: run-playwright.mjs writes an isolated tsconfig that inherits the root include globs, and Next's dev-types filter is not reached because `useTypeScriptCli` defaults true. The row now says reproduce before changing anything. PR #1880 reached both corrections independently but its diff never touched the ledger, so they lived only in that PR body until now. Queued as an immutable inbox request rather than a direct canonical-ledger edit; apply with `npm run issues:reconcile` from a fresh ledger branch. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_017paT42ZVMf8jaLtkjFxdy5 --- .../04470779-8c8d-4c90-ad04-bc6d613fd73a.json | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 docs/outstanding-issues-inbox/04470779-8c8d-4c90-ad04-bc6d613fd73a.json diff --git a/docs/outstanding-issues-inbox/04470779-8c8d-4c90-ad04-bc6d613fd73a.json b/docs/outstanding-issues-inbox/04470779-8c8d-4c90-ad04-bc6d613fd73a.json new file mode 100644 index 0000000000..7b88dc7191 --- /dev/null +++ b/docs/outstanding-issues-inbox/04470779-8c8d-4c90-ad04-bc6d613fd73a.json @@ -0,0 +1,11 @@ +{ + "version": 1, + "id": "04470779-8c8d-4c90-ad04-bc6d613fd73a", + "createdOn": "2026-08-13", + "action": "update", + "payload": { + "id": "#210", + "summary": "npm run ensure's .next/dev types may still break the Playwright isolated tsconfig (typecheck half already fixed)", + "detail": "CORRECTED 2026-08-13 — the 2026-08-12 re-scope on this row was itself half wrong, and the fix it prescribed would have been silently reverted by Next. Two corrections, both verified against the installed tree. (1) The typecheck half is already fixed and was fixed before that re-scope was written: `npm run typecheck` runs `tsc -p tsconfig.typecheck.json` (package.json:38-39), which excludes `.next/**` outright, and that file's own header comment cites this row by number as the reason it exists. `npm run ensure` does NOT break repo-wide typecheck. (2) The prescribed fix — drop `.next/dev/types/**/*.ts` from tsconfig.json:28 `include` — does not hold. Next 16 emits that glob deliberately (node_modules/next/dist/lib/typescript/type-paths.js:34-36, \"to avoid tsconfig churn when switching between dev/build modes\") and writeConfigurationDefaults.js:305-315 pushes any missing type glob back into an existing `include` on every `next dev` / `next build`, so the edit comes straight back and the diff reads as churn. What genuinely remains is narrower: scripts/run-playwright.mjs:253-268 writes an isolated tsconfig setting only `extends: \"../../tsconfig.json\"` plus compilerOptions, so it inherits the root include globs including the dev-types one, and Next's own dev-types filter (getDevTypesPath, only called from runTypeCheck.js:37) is not reached because `experimental.useTypeScriptCli` defaults true (config-shared.js:257) and `next build` therefore shells to the TypeScript CLI. NOT PROVEN END-TO-END: nobody has reproduced the Playwright build failure since tsconfig.typecheck.json landed. Next: reproduce first — `npm run ensure`, confirm .next/dev/types/validator.ts exists, then run a Playwright production build; if it reproduces, give the isolated tsconfig its own `include` list, never an edit to the root config. Stop: do not remove typecheck from the gate (it was never the problem), and do not edit tsconfig.json's include (Next restores it). Provenance: PR #1880 reached both corrections independently on 2026-08-12 but its diff never touched this file, so the correction existed only in that PR body until this row was rewritten." + } +} From f7054d2ed7ee61b66be173360105f5625b609f4a Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 13 Aug 2026 16:02:32 +0000 Subject: [PATCH 2/3] chore(ledger): record the #210 correction review Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_017paT42ZVMf8jaLtkjFxdy5 --- ...57daa749c3601ca7af0b3eb1f338a69e0994874dbba42906eb2.record.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/branch-review-records/f8f72a6790fd157daa749c3601ca7af0b3eb1f338a69e0994874dbba42906eb2.record.md diff --git a/docs/branch-review-records/f8f72a6790fd157daa749c3601ca7af0b3eb1f338a69e0994874dbba42906eb2.record.md b/docs/branch-review-records/f8f72a6790fd157daa749c3601ca7af0b3eb1f338a69e0994874dbba42906eb2.record.md new file mode 100644 index 0000000000..9e83b3ac86 --- /dev/null +++ b/docs/branch-review-records/f8f72a6790fd157daa749c3601ca7af0b3eb1f338a69e0994874dbba42906eb2.record.md @@ -0,0 +1 @@ +| 2026-08-13 | claude/design-issues-triage-wnr7k9 | 615893b24fa2be21e245ef1e47ae2fa1e2e12981 | docs/outstanding-issues-inbox — #210 correction | Corrected #210: typecheck half already fixed by tsconfig.typecheck.json; the prescribed tsconfig.json include edit is reverted by Next (type-paths.js:34-36 + writeConfigurationDefaults.js:305-315). Remaining Playwright-isolated-tsconfig half recorded as not proven end-to-end. Queued as immutable inbox request. | verify:pr-local (all 11 completed, 0 failed) | From 630d66e4f8624716f0ccf7ae7c111b8504ef2a49 Mon Sep 17 00:00:00 2001 From: BigSimmo <87357024+BigSimmo@users.noreply.github.com> Date: Fri, 14 Aug 2026 05:13:13 +0800 Subject: [PATCH 3/3] fix(docs): cancel duplicate #210 mutation --- .../9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 docs/outstanding-issues-inbox/9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa.json diff --git a/docs/outstanding-issues-inbox/9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa.json b/docs/outstanding-issues-inbox/9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa.json new file mode 100644 index 0000000000..adfed98882 --- /dev/null +++ b/docs/outstanding-issues-inbox/9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa.json @@ -0,0 +1,10 @@ +{ + "version": 1, + "id": "9fded706-51d9-4d8f-9aa4-c57a6b0ac7aa", + "createdOn": "2026-08-14", + "action": "can\u0063el", + "payload": { + "requestId": "04470779-8c8d-4c90-ad04-bc6d613fd73a", + "reason": "Superseded by merged request 24586190-0756-488d-941e-70a970c13cce, whose reviewed detail includes the corrected Next 16.3 child-config early-return behavior and explicit before/after hash verification." + } +}