diff --git a/docs/branch-review-records/3bf415052283c7c9ccd1792f7d354ba9a0d6efd4d5b0716281e86fcb133abbf1.record.md b/docs/branch-review-records/3bf415052283c7c9ccd1792f7d354ba9a0d6efd4d5b0716281e86fcb133abbf1.record.md new file mode 100644 index 0000000000..648b6ab9da --- /dev/null +++ b/docs/branch-review-records/3bf415052283c7c9ccd1792f7d354ba9a0d6efd4d5b0716281e86fcb133abbf1.record.md @@ -0,0 +1 @@ +| 2026-08-18 | claude/db-remediation-316-d4-capture | 6dbe0da05c33ed0a7d002db07bbfaa7f8c2f9840 | inbox requests #316 close-out/D4 and #Q5JHBJ re-scope | coordinator self-review: inbox-only, verified against forensics 3.7 and main 0216f18e9 | check:outstanding-issues pass; check:ledger-write-discipline pass | diff --git a/docs/outstanding-issues-inbox/7a93a5a2-d3b9-4f3d-9747-22049300cd64.json b/docs/outstanding-issues-inbox/7a93a5a2-d3b9-4f3d-9747-22049300cd64.json new file mode 100644 index 0000000000..e20db85c61 --- /dev/null +++ b/docs/outstanding-issues-inbox/7a93a5a2-d3b9-4f3d-9747-22049300cd64.json @@ -0,0 +1,12 @@ +{ + "version": 2, + "id": "7a93a5a2-d3b9-4f3d-9747-22049300cd64", + "createdOn": "2026-08-18", + "action": "update", + "payload": { + "id": "#316", + "detail": "PRODUCTION WINDOW CLOSED 2026-08-18 WITHOUT A PUSH (PR #2123, forensics section 3.7). The authorised window's pre-flight supabase migration list against sjrfecxgysukkwxsowpy showed the pending set EMPTY: all five 20260818 migrations (090000, 110000, 111000, 112000, 113000) were already applied with executed statements (3/11/12/5/4, the CLI db push shape, not mark-applied). db push was never run, no migration repair, no vault reads, staging untouched, zero production writes. Verified read-only: schema_drift_snapshot() v2 live (probe ok; 20 migration_history rows = 15 unallowlisted section 1.1 versions + 5 seeded); ten work_mem values at D1 (128 MB on the four hybrids, 64 MB on six); live-drift run 32131517648 on the post-#2111 head: 0 function def_hash mismatches, 20 missing_live, 2 unexpected_live, 15 migration_history. The RPC-divergence half of this row is CLOSED: manifest def_hash equals live for all ten match_* functions. CAUSE, new platform finding (D4, owner decision pending): the Supabase GitHub integration (Branching, production bound to git main, branch record from 2026-06-27) auto-applies every migration merged to main onto production; push-triggered live-drift bracketed 110000-112000 to 34 s after #2106's squash-merge. Not established: who enabled it or when, or whether the July mark-applied rows trace to integration failures. Recommendation: owner disables Deploy to production (Supabase dashboard, Project Settings, Integrations, GitHub) until D4 is decided deliberately; owner-only setting, untouched by any chat. REMAINING for this row = Phase 4 (20 missing_live indexes, 2 unexpected_live, guard migration for the two trigram indexes restored 2026-08-14, staging drop-and-recreate of document_chunks_content_trgm_idx to the canonical coalesce(content,'') form, decide the 8 Phase 6.3 monitor-candidates via a required_indexes migration) then Phase 5 measurement. Phase 4 constraint while auto-deploy is on: never ship a bare create index concurrently migration (auto db push runs it in a transaction and the build fails); operator prebuild plus fail-fast guard per 20260804110240 is unaffected, and the guard may merge only after every index it validates is verified built. Session traps: the main checkout D:\\Repos\\Database is linked to STAGING, link a dedicated worktree for production reads and supabase unlink afterwards; supabase db query --linked --project-ref works read-only via the management API without a DB password; production has no track_commit_timestamp.", + "source": "PR #2123 forensics section 3.7; live-drift run 32131517648; coordination chat 2026-08-19", + "baseRowFingerprint": "de004897b857158a00169721415caf512defac916bbff0466da5d7d3da4049c4" + } +} diff --git a/docs/outstanding-issues-inbox/d96c4613-bdfc-4e80-b084-7c27dfff1bb8.json b/docs/outstanding-issues-inbox/d96c4613-bdfc-4e80-b084-7c27dfff1bb8.json new file mode 100644 index 0000000000..a4d865e5f2 --- /dev/null +++ b/docs/outstanding-issues-inbox/d96c4613-bdfc-4e80-b084-7c27dfff1bb8.json @@ -0,0 +1,12 @@ +{ + "version": 2, + "id": "d96c4613-bdfc-4e80-b084-7c27dfff1bb8", + "createdOn": "2026-08-18", + "action": "update", + "payload": { + "id": "#Q5JHBJ", + "detail": "RE-SCOPED 2026-08-18: the 20260818090000 schema_drift_snapshot v2 probe is ALREADY LIVE on production, auto-applied by the Supabase GitHub integration on merge of PR #2058 (verified in the Phase 3 production window, forensics section 3.7: probe ok, migration_history 20 rows = 15 unallowlisted + 5 seeded; live-drift 32131517648 reports 15 migration_history findings). The deploy step of this row is done and needs no window. REMAINING: triage the 15 reported no-statements versions (the 2026-07-01..07-02 cluster and the 2026-07-12 batch listed in forensics section 1.1) and author fail-fast validation guard migrations per 20260804110240 for each, never bare allowlisting; index-shaped ones can ride Phase 4's guard batches. See D4 in #316: while auto-deploy is on, every merged migration is a production deploy.", + "source": "PR #2123 forensics section 3.7; coordination chat 2026-08-19", + "baseRowFingerprint": "b15db0edeba070d72b7bfa791f65f4882808db23e33c29ad54fe4a3a6b795972" + } +}