From 56de22ef9a12e9fa692f782fcd09f3876f9206f8 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 18:51:14 +0000
Subject: [PATCH 1/9] fix(ui): restore Safari edge-to-edge after
 hidden-composer regression

PR #932 reintroduced env(safe-area-inset-bottom) into the hidden composer
content reserve and inflated no-composer shell padding, undoing #922 and
leaving a toolbar-sized blank band. Restore the 0.75rem hidden contract,
stop stacking shell pad under DocumentViewer routes, and sync hide/show
motion with reduced-motion respect.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/app/globals.css                           |  9 +++++++++
 src/components/ClinicalDashboard.tsx          |  7 ++++---
 src/components/DocumentViewer.tsx             |  5 ++++-
 .../global-search-shell.tsx                   | 19 ++++++++++++++-----
 ...clinical-dashboard-merge-artifacts.test.ts | 16 +++++++++++-----
 5 files changed, 42 insertions(+), 14 deletions(-)

diff --git a/src/app/globals.css b/src/app/globals.css
index 20df4b99c0..b346ffe5c8 100644
--- a/src/app/globals.css
+++ b/src/app/globals.css
@@ -2596,3 +2596,12 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
     transition: padding-bottom 240ms cubic-bezier(0.4, 0, 0.2, 1);
   }
 }
+
+@media (max-width: 639px) and (prefers-reduced-motion: reduce) {
+  #main-content,
+  #main-content[data-bottom-composer-hidden="true"],
+  [data-testid="document-viewer-content"],
+  [data-testid="document-viewer-content"][data-scroll-hidden="true"] {
+    transition: none;
+  }
+}
diff --git a/src/components/ClinicalDashboard.tsx b/src/components/ClinicalDashboard.tsx
index 1f74aa26a8..79e3fa337f 100644
--- a/src/components/ClinicalDashboard.tsx
+++ b/src/components/ClinicalDashboard.tsx
@@ -3259,9 +3259,10 @@ export function ClinicalDashboard({
         : compactMobileBottomSearch
           ? "calc(5rem + var(--safe-area-bottom))"
           : "calc(5.25rem + var(--safe-area-bottom))";
-  const mobileComposerReserve = bottomComposerHidden
-    ? "max(0.75rem, env(safe-area-inset-bottom))"
-    : visibleMobileComposerReserve;
+  // Safari's bottom safe-area inset includes its translucent browser toolbar.
+  // Reusing that inset after the app composer hides recreates a toolbar-sized
+  // blank band, so the hidden state intentionally keeps only a small content pad.
+  const mobileComposerReserve = bottomComposerHidden ? "0.75rem" : visibleMobileComposerReserve;
   const renderDegradedNotice = () => (
     <UtilityDrawer
       icon={!isOnline ? WifiOff : CircleAlert}
diff --git a/src/components/DocumentViewer.tsx b/src/components/DocumentViewer.tsx
index 2bf5a660e0..f669cf32e3 100644
--- a/src/components/DocumentViewer.tsx
+++ b/src/components/DocumentViewer.tsx
@@ -3120,7 +3120,10 @@ export function DocumentViewer({
           }}
           className={cn(
             glassOverlaySurface,
-            "document-viewer-composer floating-composer-edge dashboard-composer-edge fixed z-40 mx-auto flex min-h-[56px] max-w-3xl items-center gap-2 rounded-full bg-[color:var(--surface-lux)] px-2 shadow-[var(--shadow-lux)] max-sm:transition-transform max-sm:duration-200 max-sm:ease-out motion-reduce:transition-none",
+            "document-viewer-composer floating-composer-edge dashboard-composer-edge fixed z-40 mx-auto flex min-h-[56px] max-w-3xl items-center gap-2 rounded-full bg-[color:var(--surface-lux)] px-2 shadow-[var(--shadow-lux)] max-sm:transition-transform motion-reduce:transition-none",
+            composerScrollHidden
+              ? "max-sm:duration-[240ms] max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]"
+              : "max-sm:duration-200 max-sm:ease-[cubic-bezier(0.22,1,0.36,1)]",
           )}
         >
           <button
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index 092e17e7b0..00ce28cc83 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -222,6 +222,13 @@ function isToolDetailWithFooterSearch(pathname: string): boolean {
   );
 }
 
+/** Document viewer surfaces own their floating bottom composer; the shell must not stack a second pad. */
+function isDocumentViewerOwnedRoute(pathname: string): boolean {
+  if (pathname.startsWith("/documents/source")) return true;
+  if (!pathname.startsWith("/documents/")) return false;
+  return pathname !== "/documents/search";
+}
+
 function GlobalStandaloneSearchShellClient({
   children,
   initialMode = "answer",
@@ -341,9 +348,13 @@ function GlobalStandaloneSearchShellClient({
     (!isInfoPage || isToolDetailWithFooterSearch(pathname));
   const reservesFloatingComposer = shouldShowSearchComposer && !isStandaloneModeHome;
   // Standalone mode homes portal the composer into the hero (in-flow at every
-  // width), so phones need no bottom-dock clearance there.
+  // width), so phones need no bottom-dock clearance there. Document viewer
+  // routes own their own floating composer, so the shell keeps only a small pad
+  // and lets DocumentViewer manage visible-dock clearance.
   const visibleMobileComposerReserve = !shouldShowSearchComposer
-    ? "max(2rem, var(--safe-area-bottom))"
+    ? isDocumentViewerOwnedRoute(pathname)
+      ? "0.75rem"
+      : "2rem"
     : isStandaloneModeHome
       ? "2rem"
       : searchMode === "answer"
@@ -361,9 +372,7 @@ function GlobalStandaloneSearchShellClient({
   // Reusing that inset after the app composer hides recreates a toolbar-sized
   // blank band, so the hidden state intentionally keeps only a small content
   // pad. Interactive composer chrome still receives the full inset above.
-  const mobileComposerReserve = bottomComposerHidden
-    ? "max(0.75rem, env(safe-area-inset-bottom))"
-    : visibleMobileComposerReserve;
+  const mobileComposerReserve = bottomComposerHidden ? "0.75rem" : visibleMobileComposerReserve;
 
   useEffect(() => {
     // Re-derive the mode and query from the URL, but only when the search string
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index 6aea230613..7484d6b708 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -89,20 +89,26 @@ describe("ClinicalDashboard merge-artifact guards", () => {
 
   it("releases the Safari toolbar reserve only after phone composers hide", () => {
     expect(globalSearchShellSource).toContain("const visibleMobileComposerReserve = !shouldShowSearchComposer");
-    expect(globalSearchShellSource).toContain("const mobileComposerReserve = bottomComposerHidden");
-    expect(globalSearchShellSource).toMatch(
-      /bottomComposerHidden\s*\?\s*"max\(0\.75rem, env\(safe-area-inset-bottom\)\)"/,
+    expect(globalSearchShellSource).toContain('const mobileComposerReserve = bottomComposerHidden ? "0.75rem"');
+    expect(globalSearchShellSource).not.toContain(
+      'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
     );
     expect(globalSearchShellSource).not.toContain('bottomComposerHidden ? "max(0.75rem, var(--safe-area-bottom))"');
+    expect(globalSearchShellSource).not.toContain('"max(2rem, var(--safe-area-bottom))"');
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = !reservesFloatingComposer");
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
-    expect(clinicalDashboardSource).toMatch(
-      /bottomComposerHidden\s*\?\s*"max\(0\.75rem, env\(safe-area-inset-bottom\)\)"/,
+    expect(globalSearchShellSource).toContain("function isDocumentViewerOwnedRoute");
+    expect(globalSearchShellSource).toContain('isDocumentViewerOwnedRoute(pathname)\n      ? "0.75rem"\n      : "2rem"');
+    expect(clinicalDashboardSource).toContain('const mobileComposerReserve = bottomComposerHidden ? "0.75rem"');
+    expect(clinicalDashboardSource).not.toContain(
+      'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
     );
     expect(clinicalDashboardSource).toContain('"max-sm:pb-[var(--mobile-composer-reserve)] sm:mb-24"');
     expect(documentViewerSource).toContain('data-testid="document-viewer-content"');
     expect(documentViewerSource).toContain('"max-sm:pb-3"');
     expect(documentViewerSource).toContain('"max-sm:pb-[calc(9rem+var(--safe-area-bottom))]"');
+    expect(documentViewerSource).toContain("max-sm:duration-[240ms]");
+    expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
   });
 
   it("does not reintroduce the obsolete output-mode copy helper", () => {

From 513028955dab5e46e20f6bac8e025d773e739ea1 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:07:48 +0000
Subject: [PATCH 2/9] fix(ui): stop stacking dock-sized page pads under shared
 reserve

Child surfaces under GlobalSearchShell/ClinicalDashboard kept large
pb-[calc(Nrem+env(safe-area-inset-bottom))] clearance that could not
collapse when the phone dock hid, so edge-to-edge still failed on those
routes. Rely on --mobile-composer-reserve as the single phone clearance
owner and lock the removed stack pads in merge-artifacts.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/components/applications-launcher-page.tsx |  1 -
 .../clinical-dashboard/differentials-home.tsx |  2 +-
 .../favourites-command-library-page.tsx       |  4 +--
 .../factsheets/factsheet-detail-page.tsx      |  2 +-
 .../factsheets/factsheets-search-page.tsx     |  2 +-
 src/components/forms/form-detail-page.tsx     |  2 +-
 src/components/formulation/formulation-ui.tsx |  2 +-
 .../services/service-detail-page.tsx          |  2 +-
 src/components/specifiers/specifier-ui.tsx    |  2 +-
 src/components/ui-primitives.tsx              |  5 +++-
 ...clinical-dashboard-merge-artifacts.test.ts | 27 +++++++++++++++++++
 11 files changed, 40 insertions(+), 11 deletions(-)

diff --git a/src/components/applications-launcher-page.tsx b/src/components/applications-launcher-page.tsx
index 4b26a9be8a..71e52e1aa5 100644
--- a/src/components/applications-launcher-page.tsx
+++ b/src/components/applications-launcher-page.tsx
@@ -734,7 +734,6 @@ export function ApplicationsLauncherWorkspace({
       aria-labelledby="tools-home-title"
       className={cn(
         "mx-auto w-full max-w-[90rem] overflow-x-hidden px-4 pb-8 text-[color:var(--text)] sm:px-6 lg:px-8",
-        "pb-[calc(12rem+env(safe-area-inset-bottom))] sm:pb-8",
         "pt-5 sm:pt-8 lg:pt-10",
         className,
       )}
diff --git a/src/components/clinical-dashboard/differentials-home.tsx b/src/components/clinical-dashboard/differentials-home.tsx
index 95f375323b..b1ff08ed3a 100644
--- a/src/components/clinical-dashboard/differentials-home.tsx
+++ b/src/components/clinical-dashboard/differentials-home.tsx
@@ -872,7 +872,7 @@ function SearchResultsView({
       // this results canvas into a nested phone scrollport, stealing scroll from
       // #main-content. The fixed compare FAB and shell hide-on-scroll both assume
       // #main-content owns vertical scroll.
-      className="mx-auto grid w-full max-w-[86rem] min-w-0 gap-3 overflow-x-clip px-4 pb-[calc(12.5rem+env(safe-area-inset-bottom))] min-[390px]:gap-4 sm:px-4 lg:px-0 lg:pb-0"
+      className="mx-auto grid w-full max-w-[86rem] min-w-0 gap-3 overflow-x-clip px-4 pb-4 min-[390px]:gap-4 sm:px-4 lg:px-0 lg:pb-0"
     >
       {/* Query context lives here on every breakpoint — on phones this is the
           only place the submitted query is visible above the fold. */}
diff --git a/src/components/clinical-dashboard/favourites-command-library-page.tsx b/src/components/clinical-dashboard/favourites-command-library-page.tsx
index a26d432928..1b1a1b3056 100644
--- a/src/components/clinical-dashboard/favourites-command-library-page.tsx
+++ b/src/components/clinical-dashboard/favourites-command-library-page.tsx
@@ -1074,7 +1074,7 @@ export function FavouritesCommandLibraryPage({ query = "", demoMode }: { query?:
     return (
       <main
         data-testid="favourites-hub"
-        className="min-h-0 overflow-x-clip bg-[color:var(--background)] pb-[calc(6rem+env(safe-area-inset-bottom))] text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:pb-32 md:pb-0"
+        className="min-h-0 overflow-x-clip bg-[color:var(--background)] pb-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:pb-32 md:pb-0"
       >
         <span data-testid="favourites-command-library" className="sr-only">
           Favourites command library
@@ -1128,7 +1128,7 @@ export function FavouritesCommandLibraryPage({ query = "", demoMode }: { query?:
   return (
     <main
       data-testid="favourites-hub"
-      className="min-h-0 overflow-x-clip bg-[color:var(--background)] pb-[calc(6rem+env(safe-area-inset-bottom))] text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:pb-32 md:pb-0"
+      className="min-h-0 overflow-x-clip bg-[color:var(--background)] pb-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:pb-32 md:pb-0"
     >
       <span data-testid="favourites-command-library" className="sr-only">
         Favourites command library
diff --git a/src/components/factsheets/factsheet-detail-page.tsx b/src/components/factsheets/factsheet-detail-page.tsx
index 547b710c44..2f86b49c8d 100644
--- a/src/components/factsheets/factsheet-detail-page.tsx
+++ b/src/components/factsheets/factsheet-detail-page.tsx
@@ -163,7 +163,7 @@ export function FactsheetDetailPage({ factsheet }: { factsheet: Factsheet }) {
           </div>
         </div>
 
-        <div className="mx-auto grid max-w-[64rem] gap-8 px-4 py-6 pb-[calc(3rem+env(safe-area-inset-bottom))] sm:px-6 sm:py-8 lg:grid-cols-[minmax(0,1fr)_16.5rem] lg:items-start lg:px-8">
+        <div className="mx-auto grid max-w-[64rem] gap-8 px-4 py-6 pb-4 sm:px-6 sm:py-8 lg:grid-cols-[minmax(0,1fr)_16.5rem] lg:items-start lg:px-8">
           <article className="min-w-0">
             {/* hero band */}
             <div className="rounded-2xl border border-[color:var(--border)] p-6" style={{ background: theme.hero }}>
diff --git a/src/components/factsheets/factsheets-search-page.tsx b/src/components/factsheets/factsheets-search-page.tsx
index c71f4a0c60..be68e32b1e 100644
--- a/src/components/factsheets/factsheets-search-page.tsx
+++ b/src/components/factsheets/factsheets-search-page.tsx
@@ -49,7 +49,7 @@ export function FactsheetsSearchPage({
   return (
     <div
       data-testid="factsheets-search-page"
-      className="mx-auto w-full max-w-[64rem] px-4 py-6 pb-[calc(2rem+env(safe-area-inset-bottom))] sm:px-6 sm:py-8 lg:px-8"
+      className="mx-auto w-full max-w-[64rem] px-4 py-6 pb-4 sm:px-6 sm:py-8 lg:px-8"
     >
       <p className="text-2xs font-bold uppercase tracking-[0.06em] text-[color:var(--clinical-accent)]">Find a sheet</p>
       <h1 className="mt-1.5 text-2xl font-extrabold tracking-tight text-[color:var(--text-heading)]">
diff --git a/src/components/forms/form-detail-page.tsx b/src/components/forms/form-detail-page.tsx
index e9bead16c7..faec3ea763 100644
--- a/src/components/forms/form-detail-page.tsx
+++ b/src/components/forms/form-detail-page.tsx
@@ -559,7 +559,7 @@ export function FormDetailPage({ form }: { form: FormRecord }) {
   return (
     <main
       data-testid="form-detail-page"
-      className="min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 pb-[calc(2rem+env(safe-area-inset-bottom))] pt-4 text-[color:var(--text)] sm:px-5 sm:pb-10 sm:pt-6 lg:px-8"
+      className="min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 pb-4 pt-4 text-[color:var(--text)] sm:px-5 sm:pb-10 sm:pt-6 lg:px-8"
     >
       <div className={pageContainer}>
         {notice ? (
diff --git a/src/components/formulation/formulation-ui.tsx b/src/components/formulation/formulation-ui.tsx
index 29322834f8..32b3ec3dc3 100644
--- a/src/components/formulation/formulation-ui.tsx
+++ b/src/components/formulation/formulation-ui.tsx
@@ -11,7 +11,7 @@ export function FormulationPageShell({ children, className }: { children: ReactN
   return (
     <main
       className={cn(
-        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-[calc(7rem+env(safe-area-inset-bottom))] text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
+        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
         className,
       )}
     >
diff --git a/src/components/services/service-detail-page.tsx b/src/components/services/service-detail-page.tsx
index b8f0f4d1cf..696c6ea566 100644
--- a/src/components/services/service-detail-page.tsx
+++ b/src/components/services/service-detail-page.tsx
@@ -505,7 +505,7 @@ export function ServiceDetailPage({ service }: { service: ServiceRecord }) {
   return (
     <main
       data-testid="service-detail-page"
-      className="min-h-[calc(100dvh-4rem)] max-sm:shrink-0 bg-[color:var(--background)] px-3 py-4 pb-[calc(5.5rem+env(safe-area-inset-bottom))] text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-8"
+      className="min-h-[calc(100dvh-4rem)] max-sm:shrink-0 bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-8"
     >
       <div className={pageContainer}>
         {notice ? (
diff --git a/src/components/specifiers/specifier-ui.tsx b/src/components/specifiers/specifier-ui.tsx
index 071daf0b08..c0811a7758 100644
--- a/src/components/specifiers/specifier-ui.tsx
+++ b/src/components/specifiers/specifier-ui.tsx
@@ -13,7 +13,7 @@ export function SpecifierPageShell({ children, className }: { children: ReactNod
   return (
     <main
       className={cn(
-        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-[calc(7rem+env(safe-area-inset-bottom))] text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
+        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
         className,
       )}
     >
diff --git a/src/components/ui-primitives.tsx b/src/components/ui-primitives.tsx
index 3b3295c918..79591013f6 100644
--- a/src/components/ui-primitives.tsx
+++ b/src/components/ui-primitives.tsx
@@ -128,8 +128,11 @@ export const toneNeutral =
   "border-[color:var(--border)] bg-[color:var(--surface-subtle)] text-[color:var(--text-muted)]";
 
 export const searchPageCanvas = "bg-[color:var(--background)] text-[color:var(--text)]";
+// Phone bottom-dock clearance lives on #main-content / dashboard <main> via
+// --mobile-composer-reserve so it can collapse when the dock hides. Do not bake
+// a second dock-sized safe-area pad into page shells.
 export const searchPageShell =
-  "min-h-[calc(100dvh-4rem)] overflow-x-hidden px-3 py-3 pb-[calc(12rem+env(safe-area-inset-bottom))] sm:px-5 sm:py-5 sm:pb-8 lg:px-6";
+  "min-h-[calc(100dvh-4rem)] overflow-x-hidden px-3 py-3 pb-4 sm:px-5 sm:py-5 sm:pb-8 lg:px-6";
 export const searchPageContainer = "mx-auto w-full max-w-[1500px]";
 // Canonical content-page width. Detail pages (service / form / differential),
 // medication record + prescribing workspace, and the forms results view converge
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index 7484d6b708..68401c0698 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -31,6 +31,23 @@ const globalSearchShellSource = readFileSync(
 const clinicalDashboardSource = readFileSync(resolve(process.cwd(), "src/components/ClinicalDashboard.tsx"), "utf8");
 const documentViewerSource = readFileSync(resolve(process.cwd(), "src/components/DocumentViewer.tsx"), "utf8");
 const globalStylesSource = readFileSync(resolve(process.cwd(), "src/app/globals.css"), "utf8");
+const uiPrimitivesSource = readFileSync(resolve(process.cwd(), "src/components/ui-primitives.tsx"), "utf8");
+const differentialsHomeSource = readFileSync(
+  resolve(process.cwd(), "src/components/clinical-dashboard/differentials-home.tsx"),
+  "utf8",
+);
+const applicationsLauncherSource = readFileSync(
+  resolve(process.cwd(), "src/components/applications-launcher-page.tsx"),
+  "utf8",
+);
+const serviceDetailSource = readFileSync(resolve(process.cwd(), "src/components/services/service-detail-page.tsx"), "utf8");
+const formDetailSource = readFileSync(resolve(process.cwd(), "src/components/forms/form-detail-page.tsx"), "utf8");
+const specifierUiSource = readFileSync(resolve(process.cwd(), "src/components/specifiers/specifier-ui.tsx"), "utf8");
+const formulationUiSource = readFileSync(resolve(process.cwd(), "src/components/formulation/formulation-ui.tsx"), "utf8");
+const favouritesLibrarySource = readFileSync(
+  resolve(process.cwd(), "src/components/clinical-dashboard/favourites-command-library-page.tsx"),
+  "utf8",
+);
 
 type FoundDeclaration = { source: string };
 
@@ -109,6 +126,16 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(documentViewerSource).toContain('"max-sm:pb-[calc(9rem+var(--safe-area-bottom))]"');
     expect(documentViewerSource).toContain("max-sm:duration-[240ms]");
     expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
+    // Child pages must not stack a second dock-sized safe-area pad under the
+    // shared host reserve — that pad cannot collapse when the dock hides.
+    expect(uiPrimitivesSource).not.toContain("pb-[calc(12rem+env(safe-area-inset-bottom))]");
+    expect(differentialsHomeSource).not.toContain("pb-[calc(12.5rem+env(safe-area-inset-bottom))]");
+    expect(applicationsLauncherSource).not.toContain("pb-[calc(12rem+env(safe-area-inset-bottom))]");
+    expect(serviceDetailSource).not.toContain("pb-[calc(5.5rem+env(safe-area-inset-bottom))]");
+    expect(formDetailSource).not.toContain("pb-[calc(2rem+env(safe-area-inset-bottom))]");
+    expect(specifierUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
+    expect(formulationUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
+    expect(favouritesLibrarySource).not.toContain("pb-[calc(6rem+env(safe-area-inset-bottom))]");
   });
 
   it("does not reintroduce the obsolete output-mode copy helper", () => {

From 0c6c6bfae8178f69baa750645fa0da79f5edab56 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:21:27 +0000
Subject: [PATCH 3/9] fix(ui): harden Safari edge-to-edge proofs and
 compare-dock reserve

Raise the differentials compare visible reserve to 12.5rem so the shared
host clears Compare + search without a child env(safe-area) pad, and
strengthen document/forms/differentials Playwright assertions so a
toolbar-sized hidden reserve cannot regress again.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/components/ClinicalDashboard.tsx          |  4 +-
 .../global-search-shell.tsx                   |  4 +-
 ...clinical-dashboard-merge-artifacts.test.ts |  8 +++
 tests/ui-smoke.spec.ts                        | 18 +++++-
 tests/ui-tools.spec.ts                        | 57 ++++++++++++++++---
 5 files changed, 81 insertions(+), 10 deletions(-)

diff --git a/src/components/ClinicalDashboard.tsx b/src/components/ClinicalDashboard.tsx
index 79e3fa337f..a6e6688706 100644
--- a/src/components/ClinicalDashboard.tsx
+++ b/src/components/ClinicalDashboard.tsx
@@ -3255,7 +3255,9 @@ export function ClinicalDashboard({
         ? "calc(7.5rem + var(--safe-area-bottom))"
         : "calc(5.25rem + var(--safe-area-bottom))"
       : differentialsCompareAddonActive
-        ? "calc(8.75rem + var(--safe-area-bottom))"
+        ? // Compare selected bar + compact search pill; must clear both while
+          // the dock is visible. Hidden state still collapses to 0.75rem below.
+          "calc(12.5rem + var(--safe-area-bottom))"
         : compactMobileBottomSearch
           ? "calc(5rem + var(--safe-area-bottom))"
           : "calc(5.25rem + var(--safe-area-bottom))";
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index 00ce28cc83..731c16c6b6 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -360,7 +360,9 @@ function GlobalStandaloneSearchShellClient({
       : searchMode === "answer"
         ? "calc(9rem + var(--safe-area-bottom))"
         : differentialsCompareAddonActive
-          ? "calc(8.75rem + var(--safe-area-bottom))"
+          ? // Compare selected bar + compact search pill; must clear both while
+            // the dock is visible. Hidden state still collapses to 0.75rem below.
+            "calc(12.5rem + var(--safe-area-bottom))"
           : useCompactBottomSearch
             ? "calc(5.5rem + var(--safe-area-bottom))"
             : "calc(9rem + var(--safe-area-bottom))";
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index 68401c0698..811fc6be38 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -116,6 +116,8 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
     expect(globalSearchShellSource).toContain("function isDocumentViewerOwnedRoute");
     expect(globalSearchShellSource).toContain('isDocumentViewerOwnedRoute(pathname)\n      ? "0.75rem"\n      : "2rem"');
+    expect(globalSearchShellSource).toContain('"calc(12.5rem + var(--safe-area-bottom))"');
+    expect(clinicalDashboardSource).toContain('"calc(12.5rem + var(--safe-area-bottom))"');
     expect(clinicalDashboardSource).toContain('const mobileComposerReserve = bottomComposerHidden ? "0.75rem"');
     expect(clinicalDashboardSource).not.toContain(
       'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
@@ -124,8 +126,14 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(documentViewerSource).toContain('data-testid="document-viewer-content"');
     expect(documentViewerSource).toContain('"max-sm:pb-3"');
     expect(documentViewerSource).toContain('"max-sm:pb-[calc(9rem+var(--safe-area-bottom))]"');
+    // Hidden document content must not reintroduce Safari toolbar inset padding.
+    expect(documentViewerSource).not.toMatch(
+      /composerScrollHidden\s*\?\s*["']max-sm:pb-\[calc\([^"']*safe-area/,
+    );
     expect(documentViewerSource).toContain("max-sm:duration-[240ms]");
     expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
+    expect(globalStylesSource).toContain("@media (max-width: 639px) and (prefers-reduced-motion: reduce)");
+    expect(globalStylesSource).toContain('#main-content[data-bottom-composer-hidden="true"]');
     // Child pages must not stack a second dock-sized safe-area pad under the
     // shared host reserve — that pad cannot collapse when the dock hides.
     expect(uiPrimitivesSource).not.toContain("pb-[calc(12rem+env(safe-area-inset-bottom))]");
diff --git a/tests/ui-smoke.spec.ts b/tests/ui-smoke.spec.ts
index 2fa171bdab..9370f6d8c0 100644
--- a/tests/ui-smoke.spec.ts
+++ b/tests/ui-smoke.spec.ts
@@ -3536,13 +3536,20 @@ test.describe("Clinical KB UI smoke coverage", () => {
       document.documentElement.style.setProperty("--safe-area-bottom", "112px");
     });
     const viewerContent = page.getByTestId("document-viewer-content");
+    const main = page.locator("#main-content");
+    // DocumentViewer owns the floating dock. The shell must keep only a tiny
+    // pad even when Safari's toolbar inset is large — otherwise #932's
+    // max(2rem, --safe-area-bottom) shell reserve recreates the blank band
+    // under the viewer while the viewer itself collapses correctly.
+    await expect
+      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
+      .toBeLessThanOrEqual(13);
     await expect
       .poll(async () =>
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeGreaterThan(250);
 
-    const main = page.locator("#main-content");
     await waitForReactEventHandler(main, "onScroll");
     await page.evaluate(() => {
       const main = window.document.getElementById("main-content");
@@ -3568,6 +3575,9 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeLessThanOrEqual(13);
+    await expect
+      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
+      .toBeLessThanOrEqual(13);
 
     // Reappear on scroll up.
     await scrollPrimarySurface(page, 60);
@@ -3577,6 +3587,9 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeGreaterThan(250);
+    await expect
+      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
+      .toBeLessThanOrEqual(13);
 
     // Keyboard focus inside the composer reveals it while hidden.
     await scrollPrimarySurface(page, 240);
@@ -3588,6 +3601,9 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeGreaterThan(250);
+    await expect
+      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
+      .toBeLessThanOrEqual(13);
   });
 
   test("document questions use the shared answer stream with progress and cleaned bold formatting", async ({
diff --git a/tests/ui-tools.spec.ts b/tests/ui-tools.spec.ts
index 717cc700e8..071aab8871 100644
--- a/tests/ui-tools.spec.ts
+++ b/tests/ui-tools.spec.ts
@@ -1524,13 +1524,44 @@ test.describe("Clinical KB tools launcher", () => {
     await expect(compareAction).toContainText("Compare selected");
     await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
 
+    // Keep the composer focused while measuring end-of-list clearance so
+    // hide-on-scroll cannot collapse --mobile-composer-reserve mid-check.
+    await input.focus();
+    await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
+    await expect
+      .poll(async () =>
+        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
+      )
+      .toBeGreaterThan(180);
     await mainContent.evaluate((element) => element.scrollTo({ top: element.scrollHeight, behavior: "instant" }));
-    const lastResultBottom = await page
-      .getByTestId("differential-mobile-result-card")
-      .last()
-      .evaluate((element) => element.getBoundingClientRect().bottom);
-    const dockTop = await dock.evaluate((element) => element.getBoundingClientRect().top);
-    expect(lastResultBottom).toBeLessThanOrEqual(dockTop);
+    await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
+    await expect
+      .poll(async () =>
+        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
+      )
+      .toBeGreaterThan(180);
+    const clearance = await page.evaluate(() => {
+      const main = document.getElementById("main-content");
+      const last = document.querySelector('[data-testid="differential-mobile-result-card"]:last-of-type');
+      const dock = document.querySelector("form.answer-footer-search-dock");
+      const style = main ? window.getComputedStyle(main) : null;
+      return {
+        lastBottom: last?.getBoundingClientRect().bottom ?? null,
+        dockTop: dock?.getBoundingClientRect().top ?? null,
+        paddingBottom: style ? Number.parseFloat(style.paddingBottom) : null,
+        reserve:
+          main?.parentElement
+            ? window.getComputedStyle(main.parentElement).getPropertyValue("--mobile-composer-reserve").trim()
+            : null,
+        selfReserve: style?.getPropertyValue("--mobile-composer-reserve").trim() ?? null,
+        scrollHidden: dock?.getAttribute("data-scroll-hidden"),
+        url: window.location.href,
+      };
+    });
+    expect(clearance, JSON.stringify(clearance)).toMatchObject({
+      scrollHidden: null,
+    });
+    expect(clearance.lastBottom ?? Number.POSITIVE_INFINITY).toBeLessThanOrEqual(clearance.dockTop ?? 0);
 
     // Compare lives in the dock addon slot above the search pill.
     const revealedGeometry = await compareAction.evaluate((element) => {
@@ -1553,7 +1584,7 @@ test.describe("Clinical KB tools launcher", () => {
     expect(revealedGeometry.bottom).toBeLessThanOrEqual(revealedGeometry.dockBottom!);
     expect(revealedGeometry.receivesPointer).toBe(true);
     // Last card must clear the floating compare CTA, not only the composer dock.
-    expect(lastResultBottom).toBeLessThanOrEqual(revealedGeometry.top);
+    expect(clearance.lastBottom ?? Number.POSITIVE_INFINITY).toBeLessThanOrEqual(revealedGeometry.top);
 
     const mainPaddingBottom = await mainContent.evaluate((element) =>
       Number.parseFloat(window.getComputedStyle(element).paddingBottom),
@@ -1573,6 +1604,18 @@ test.describe("Clinical KB tools launcher", () => {
       container.appendChild(spacer);
     });
 
+    // Apply the Safari toolbar simulation after the visible-dock clearance
+    // checks above. A collapsed reserve that still includes the toolbar inset
+    // must fail the ≤13px assertion below.
+    await page.evaluate(() => {
+      document.documentElement.style.setProperty("--safe-area-bottom", "112px");
+    });
+    await expect
+      .poll(async () =>
+        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
+      )
+      .toBeGreaterThan(200);
+
     await expect(async () => {
       await input.blur();
       await expect(input).not.toBeFocused({ timeout: 1_000 });

From 2b68a3a3cf0a85ae73b6cf948892d57ca2ed62cc Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:27:30 +0000
Subject: [PATCH 4/9] fix(ui): centralize phone dock reserves and align compare
 backdrop

Share mobile composer reserve tokens between GlobalSearchShell and
ClinicalDashboard, sync differentials compare backdrop heights to the
12.5rem clearance, use testable safe-area vars on sm+ shell padding, and
add tablet/desktop clearance coverage so phone hide-collapse cannot leak.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/app/globals.css                           | 17 +++++--
 src/components/ClinicalDashboard.tsx          | 18 ++++----
 .../global-search-shell.tsx                   | 39 ++++++++--------
 .../mobile-composer-reserve.ts                | 44 ++++++++++++++++++
 ...clinical-dashboard-merge-artifacts.test.ts | 34 +++++++++++---
 tests/mobile-composer-reserve.test.ts         | 46 +++++++++++++++++++
 tests/ui-tools.spec.ts                        | 31 +++++++++++++
 7 files changed, 193 insertions(+), 36 deletions(-)
 create mode 100644 src/components/clinical-dashboard/mobile-composer-reserve.ts
 create mode 100644 tests/mobile-composer-reserve.test.ts

diff --git a/src/app/globals.css b/src/app/globals.css
index b346ffe5c8..a28fc1b2ec 100644
--- a/src/app/globals.css
+++ b/src/app/globals.css
@@ -267,6 +267,10 @@
   --safe-area-right: env(safe-area-inset-right, 0px);
   --safe-area-bottom: env(safe-area-inset-bottom, 0px);
   --safe-area-left: env(safe-area-inset-left, 0px);
+  /* Keep in sync with mobile-composer-reserve.ts (phone dock clearance). */
+  --phone-dock-hidden-pad: 0.75rem;
+  --phone-dock-differentials-compare-clearance: 12.5rem;
+  --phone-dock-differentials-compare-compact-clearance: 12.25rem;
   /* Radius tokens are the single source of truth in @theme above (they also
      generate the rounded-* utilities); do not redefine them here or var() and
      the utilities drift apart. */
@@ -1802,14 +1806,21 @@ summary::-webkit-details-marker {
     height: max(5rem, calc(var(--safe-area-bottom) + 4.4rem));
   }
 
-  /* Differentials search results: compare action sits above the search pill in the dock. */
+  /* Differentials search results: compare action sits above the search pill in the dock.
+     Heights track --phone-dock-differentials-compare-* (same as content reserve). */
   .answer-footer-search-dock[data-footer-addon="differentials-compare"] .answer-footer-search-backdrop {
-    height: max(8.75rem, calc(var(--safe-area-bottom) + 7.5rem));
+    height: max(
+      var(--phone-dock-differentials-compare-clearance),
+      calc(var(--safe-area-bottom) + 11.25rem)
+    );
   }
 
   .answer-footer-search-dock.document-mobile-search-compact[data-footer-addon="differentials-compare"]
     .answer-footer-search-backdrop {
-    height: max(8.5rem, calc(var(--safe-area-bottom) + 7.25rem));
+    height: max(
+      var(--phone-dock-differentials-compare-compact-clearance),
+      calc(var(--safe-area-bottom) + 11rem)
+    );
   }
 
   .document-mobile-search-pill {
diff --git a/src/components/ClinicalDashboard.tsx b/src/components/ClinicalDashboard.tsx
index a6e6688706..e05b83d205 100644
--- a/src/components/ClinicalDashboard.tsx
+++ b/src/components/ClinicalDashboard.tsx
@@ -91,6 +91,10 @@ import {
 } from "@/components/clinical-dashboard/answer-progress";
 import { evidenceMapRowsFromRenderModel } from "@/components/clinical-dashboard/evidence-map-model";
 import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header";
+import {
+  mobileComposerVisibleReserve,
+  resolveMobileComposerReserve,
+} from "@/components/clinical-dashboard/mobile-composer-reserve";
 import { UniversalSearchAlsoMatches } from "@/components/clinical-dashboard/universal-search-also-matches";
 import { useScrollHideReporter } from "@/components/clinical-dashboard/use-hide-on-scroll";
 import { SearchCommandProvider } from "@/components/clinical-dashboard/search-command-context";
@@ -3252,19 +3256,17 @@ export function ClinicalDashboard({
   const visibleMobileComposerReserve =
     searchMode === "answer"
       ? answerFollowUpSuggestions.length > 0
-        ? "calc(7.5rem + var(--safe-area-bottom))"
-        : "calc(5.25rem + var(--safe-area-bottom))"
+        ? mobileComposerVisibleReserve.dashboardAnswerWithFollowUps
+        : mobileComposerVisibleReserve.dashboardAnswer
       : differentialsCompareAddonActive
-        ? // Compare selected bar + compact search pill; must clear both while
-          // the dock is visible. Hidden state still collapses to 0.75rem below.
-          "calc(12.5rem + var(--safe-area-bottom))"
+        ? mobileComposerVisibleReserve.differentialsCompare
         : compactMobileBottomSearch
-          ? "calc(5rem + var(--safe-area-bottom))"
-          : "calc(5.25rem + var(--safe-area-bottom))";
+          ? mobileComposerVisibleReserve.dashboardCompactSubmitted
+          : mobileComposerVisibleReserve.dashboardDefaultDock;
   // Safari's bottom safe-area inset includes its translucent browser toolbar.
   // Reusing that inset after the app composer hides recreates a toolbar-sized
   // blank band, so the hidden state intentionally keeps only a small content pad.
-  const mobileComposerReserve = bottomComposerHidden ? "0.75rem" : visibleMobileComposerReserve;
+  const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve);
   const renderDegradedNotice = () => (
     <UtilityDrawer
       icon={!isOnline ? WifiOff : CircleAlert}
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index 731c16c6b6..f792ae5afd 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -28,6 +28,13 @@ import { GuideDialog } from "@/components/clinical-dashboard/dashboard-shell";
 import { landingModeForPreference, readAppPreferences } from "@/components/clinical-dashboard/use-app-preferences";
 import { useFavouritesAccess } from "@/components/clinical-dashboard/use-favourites-access";
 import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header";
+import {
+  isDocumentViewerOwnedRoute,
+  mobileComposerDocumentViewerShellReserve,
+  mobileComposerIdleReserve,
+  mobileComposerVisibleReserve,
+  resolveMobileComposerReserve,
+} from "@/components/clinical-dashboard/mobile-composer-reserve";
 import { useScrollHideReporter } from "@/components/clinical-dashboard/use-hide-on-scroll";
 import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton";
 import { useSidebarCollapsed } from "@/components/clinical-dashboard/use-sidebar-collapsed";
@@ -222,13 +229,6 @@ function isToolDetailWithFooterSearch(pathname: string): boolean {
   );
 }
 
-/** Document viewer surfaces own their floating bottom composer; the shell must not stack a second pad. */
-function isDocumentViewerOwnedRoute(pathname: string): boolean {
-  if (pathname.startsWith("/documents/source")) return true;
-  if (!pathname.startsWith("/documents/")) return false;
-  return pathname !== "/documents/search";
-}
-
 function GlobalStandaloneSearchShellClient({
   children,
   initialMode = "answer",
@@ -353,19 +353,17 @@ function GlobalStandaloneSearchShellClient({
   // and lets DocumentViewer manage visible-dock clearance.
   const visibleMobileComposerReserve = !shouldShowSearchComposer
     ? isDocumentViewerOwnedRoute(pathname)
-      ? "0.75rem"
-      : "2rem"
+      ? mobileComposerDocumentViewerShellReserve
+      : mobileComposerIdleReserve
     : isStandaloneModeHome
-      ? "2rem"
+      ? mobileComposerIdleReserve
       : searchMode === "answer"
-        ? "calc(9rem + var(--safe-area-bottom))"
+        ? mobileComposerVisibleReserve.shellAnswer
         : differentialsCompareAddonActive
-          ? // Compare selected bar + compact search pill; must clear both while
-            // the dock is visible. Hidden state still collapses to 0.75rem below.
-            "calc(12.5rem + var(--safe-area-bottom))"
+          ? mobileComposerVisibleReserve.differentialsCompare
           : useCompactBottomSearch
-            ? "calc(5.5rem + var(--safe-area-bottom))"
-            : "calc(9rem + var(--safe-area-bottom))";
+            ? mobileComposerVisibleReserve.shellCompactSubmitted
+            : mobileComposerVisibleReserve.shellDefaultDock;
   // Release the large bottom reserve only when the phone bottom composer is
   // actually hidden (MasterSearchHeader's bottomComposerHidden). Header-only
   // scroll-hide, pinned compare addons, open menus/sheets, and composer focus
@@ -374,7 +372,7 @@ function GlobalStandaloneSearchShellClient({
   // Reusing that inset after the app composer hides recreates a toolbar-sized
   // blank band, so the hidden state intentionally keeps only a small content
   // pad. Interactive composer chrome still receives the full inset above.
-  const mobileComposerReserve = bottomComposerHidden ? "0.75rem" : visibleMobileComposerReserve;
+  const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve);
 
   useEffect(() => {
     // Re-derive the mode and query from the URL, but only when the search string
@@ -744,13 +742,16 @@ function GlobalStandaloneSearchShellClient({
             // window does the actual scrolling — silently disabling every
             // position:sticky descendant (e.g. the document viewer rail).
             "min-w-0 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-[-2px] focus-visible:outline-[color:var(--focus)] max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col max-sm:overflow-x-hidden max-sm:overflow-y-auto max-sm:overscroll-contain max-sm:[-webkit-overflow-scrolling:touch] sm:min-h-[calc(100dvh-4rem)] sm:overflow-x-clip",
+            // Phone (max-sm): collapse-aware --mobile-composer-reserve.
+            // sm+: static desktop clearance; use var(--safe-area-bottom) so tests
+            // can simulate insets without depending on env() in Chromium.
             !reservesFloatingComposer
               ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-8"
               : searchMode === "answer"
-                ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+env(safe-area-inset-bottom))]"
+                ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+var(--safe-area-bottom))]"
                 : useCompactBottomSearch
                   ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-8"
-                  : "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+env(safe-area-inset-bottom))]",
+                  : "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+var(--safe-area-bottom))]",
           )}
         >
           <div className="max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col">
diff --git a/src/components/clinical-dashboard/mobile-composer-reserve.ts b/src/components/clinical-dashboard/mobile-composer-reserve.ts
new file mode 100644
index 0000000000..34182ffed3
--- /dev/null
+++ b/src/components/clinical-dashboard/mobile-composer-reserve.ts
@@ -0,0 +1,44 @@
+/**
+ * Phone bottom-dock content clearance for GlobalSearchShell + ClinicalDashboard.
+ *
+ * Visible docks include `var(--safe-area-bottom)` so Playwright can simulate a
+ * Safari toolbar inset. Once the dock is actually hidden, clearance collapses to
+ * {@link mobileComposerHiddenReserve} — never back to the browser safe-area
+ * inset env(), which recreates a toolbar-sized blank band on iOS Safari.
+ *
+ * Keep these string values aligned with `--phone-dock-*` tokens in globals.css.
+ */
+
+/** Content pad after the phone bottom composer has scrolled away. */
+export const mobileComposerHiddenReserve = "0.75rem";
+
+/** Routes with no floating bottom dock (info pages, in-flow mode-home composers). */
+export const mobileComposerIdleReserve = "2rem";
+
+/** Shell pad on DocumentViewer-owned routes; the viewer manages dock clearance. */
+export const mobileComposerDocumentViewerShellReserve = mobileComposerHiddenReserve;
+
+/** Differentials Compare selected bar + compact search pill. */
+export const mobileComposerDifferentialsCompareReserve = "calc(12.5rem + var(--safe-area-bottom))";
+
+export const mobileComposerVisibleReserve = {
+  shellAnswer: "calc(9rem + var(--safe-area-bottom))",
+  shellCompactSubmitted: "calc(5.5rem + var(--safe-area-bottom))",
+  shellDefaultDock: "calc(9rem + var(--safe-area-bottom))",
+  dashboardAnswerWithFollowUps: "calc(7.5rem + var(--safe-area-bottom))",
+  dashboardAnswer: "calc(5.25rem + var(--safe-area-bottom))",
+  dashboardCompactSubmitted: "calc(5rem + var(--safe-area-bottom))",
+  dashboardDefaultDock: "calc(5.25rem + var(--safe-area-bottom))",
+  differentialsCompare: mobileComposerDifferentialsCompareReserve,
+} as const;
+
+export function resolveMobileComposerReserve(bottomComposerHidden: boolean, visibleReserve: string): string {
+  return bottomComposerHidden ? mobileComposerHiddenReserve : visibleReserve;
+}
+
+/** Document detail / source flows own a floating composer outside MasterSearchHeader. */
+export function isDocumentViewerOwnedRoute(pathname: string): boolean {
+  if (pathname.startsWith("/documents/source")) return true;
+  if (!pathname.startsWith("/documents/")) return false;
+  return pathname !== "/documents/search";
+}
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index 811fc6be38..043b11260a 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -48,6 +48,10 @@ const favouritesLibrarySource = readFileSync(
   resolve(process.cwd(), "src/components/clinical-dashboard/favourites-command-library-page.tsx"),
   "utf8",
 );
+const mobileComposerReserveSource = readFileSync(
+  resolve(process.cwd(), "src/components/clinical-dashboard/mobile-composer-reserve.ts"),
+  "utf8",
+);
 
 type FoundDeclaration = { source: string };
 
@@ -105,8 +109,19 @@ describe("ClinicalDashboard merge-artifact guards", () => {
   });
 
   it("releases the Safari toolbar reserve only after phone composers hide", () => {
+    expect(mobileComposerReserveSource).toContain('export const mobileComposerHiddenReserve = "0.75rem"');
+    expect(mobileComposerReserveSource).toContain(
+      'export const mobileComposerDifferentialsCompareReserve = "calc(12.5rem + var(--safe-area-bottom))"',
+    );
+    expect(mobileComposerReserveSource).toContain("export function resolveMobileComposerReserve");
+    expect(mobileComposerReserveSource).toContain("export function isDocumentViewerOwnedRoute");
+    expect(mobileComposerReserveSource).not.toContain("env(safe-area-inset-bottom)");
+
     expect(globalSearchShellSource).toContain("const visibleMobileComposerReserve = !shouldShowSearchComposer");
-    expect(globalSearchShellSource).toContain('const mobileComposerReserve = bottomComposerHidden ? "0.75rem"');
+    expect(globalSearchShellSource).toContain(
+      "const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve)",
+    );
+    expect(globalSearchShellSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
     expect(globalSearchShellSource).not.toContain(
       'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
     );
@@ -114,15 +129,20 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(globalSearchShellSource).not.toContain('"max(2rem, var(--safe-area-bottom))"');
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = !reservesFloatingComposer");
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
-    expect(globalSearchShellSource).toContain("function isDocumentViewerOwnedRoute");
-    expect(globalSearchShellSource).toContain('isDocumentViewerOwnedRoute(pathname)\n      ? "0.75rem"\n      : "2rem"');
-    expect(globalSearchShellSource).toContain('"calc(12.5rem + var(--safe-area-bottom))"');
-    expect(clinicalDashboardSource).toContain('"calc(12.5rem + var(--safe-area-bottom))"');
-    expect(clinicalDashboardSource).toContain('const mobileComposerReserve = bottomComposerHidden ? "0.75rem"');
+    expect(globalSearchShellSource).toContain("mobileComposerVisibleReserve.differentialsCompare");
+    expect(globalSearchShellSource).toContain("sm:pb-[calc(9rem+var(--safe-area-bottom))]");
+    expect(globalSearchShellSource).not.toContain("sm:pb-[calc(9rem+env(safe-area-inset-bottom))]");
+
+    expect(clinicalDashboardSource).toContain(
+      "const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve)",
+    );
+    expect(clinicalDashboardSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
+    expect(clinicalDashboardSource).toContain("mobileComposerVisibleReserve.differentialsCompare");
     expect(clinicalDashboardSource).not.toContain(
       'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
     );
     expect(clinicalDashboardSource).toContain('"max-sm:pb-[var(--mobile-composer-reserve)] sm:mb-24"');
+
     expect(documentViewerSource).toContain('data-testid="document-viewer-content"');
     expect(documentViewerSource).toContain('"max-sm:pb-3"');
     expect(documentViewerSource).toContain('"max-sm:pb-[calc(9rem+var(--safe-area-bottom))]"');
@@ -134,6 +154,8 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
     expect(globalStylesSource).toContain("@media (max-width: 639px) and (prefers-reduced-motion: reduce)");
     expect(globalStylesSource).toContain('#main-content[data-bottom-composer-hidden="true"]');
+    expect(globalStylesSource).toContain("--phone-dock-differentials-compare-clearance: 12.5rem");
+    expect(globalStylesSource).toContain("var(--phone-dock-differentials-compare-clearance)");
     // Child pages must not stack a second dock-sized safe-area pad under the
     // shared host reserve — that pad cannot collapse when the dock hides.
     expect(uiPrimitivesSource).not.toContain("pb-[calc(12rem+env(safe-area-inset-bottom))]");
diff --git a/tests/mobile-composer-reserve.test.ts b/tests/mobile-composer-reserve.test.ts
new file mode 100644
index 0000000000..0e79ffed21
--- /dev/null
+++ b/tests/mobile-composer-reserve.test.ts
@@ -0,0 +1,46 @@
+import { describe, expect, it } from "vitest";
+
+import {
+  isDocumentViewerOwnedRoute,
+  mobileComposerDifferentialsCompareReserve,
+  mobileComposerDocumentViewerShellReserve,
+  mobileComposerHiddenReserve,
+  mobileComposerIdleReserve,
+  mobileComposerVisibleReserve,
+  resolveMobileComposerReserve,
+} from "@/components/clinical-dashboard/mobile-composer-reserve";
+
+describe("mobile composer reserve contract", () => {
+  it("collapses to the hidden pad without Safari toolbar safe-area", () => {
+    expect(mobileComposerHiddenReserve).toBe("0.75rem");
+    expect(resolveMobileComposerReserve(true, mobileComposerVisibleReserve.shellAnswer)).toBe(
+      mobileComposerHiddenReserve,
+    );
+    expect(resolveMobileComposerReserve(false, mobileComposerVisibleReserve.shellAnswer)).toBe(
+      mobileComposerVisibleReserve.shellAnswer,
+    );
+    expect(mobileComposerHiddenReserve).not.toContain("safe-area");
+    expect(mobileComposerHiddenReserve).not.toContain("env(");
+  });
+
+  it("keeps document-viewer shell pad at the hidden size", () => {
+    expect(mobileComposerDocumentViewerShellReserve).toBe(mobileComposerHiddenReserve);
+    expect(mobileComposerIdleReserve).toBe("2rem");
+  });
+
+  it("keeps differentials compare clearance shared across hosts", () => {
+    expect(mobileComposerVisibleReserve.differentialsCompare).toBe(mobileComposerDifferentialsCompareReserve);
+    expect(mobileComposerDifferentialsCompareReserve).toContain("12.5rem");
+    expect(mobileComposerDifferentialsCompareReserve).toContain("var(--safe-area-bottom)");
+    expect(mobileComposerDifferentialsCompareReserve).not.toContain("env(safe-area-inset-bottom)");
+  });
+
+  it("classifies document viewer owned routes", () => {
+    expect(isDocumentViewerOwnedRoute("/documents/abc")).toBe(true);
+    expect(isDocumentViewerOwnedRoute("/documents/source")).toBe(true);
+    expect(isDocumentViewerOwnedRoute("/documents/source/evidence")).toBe(true);
+    expect(isDocumentViewerOwnedRoute("/documents/search")).toBe(false);
+    expect(isDocumentViewerOwnedRoute("/documents")).toBe(false);
+    expect(isDocumentViewerOwnedRoute("/forms")).toBe(false);
+  });
+});
diff --git a/tests/ui-tools.spec.ts b/tests/ui-tools.spec.ts
index 071aab8871..98308d37f7 100644
--- a/tests/ui-tools.spec.ts
+++ b/tests/ui-tools.spec.ts
@@ -1114,6 +1114,37 @@ test.describe("Clinical KB tools launcher", () => {
       .toBeGreaterThan(112);
   });
 
+  test("tablet and desktop forms results keep non-phone bottom clearance", async ({ page }) => {
+    // Phone dock reserve (max-sm) must not leak into sm+/lg layouts.
+    for (const viewport of [
+      { width: 768, height: 1024, label: "tablet" },
+      { width: 1280, height: 900, label: "desktop" },
+    ] as const) {
+      await page.setViewportSize({ width: viewport.width, height: viewport.height });
+      await gotoLauncher(page, "/forms?q=transport&run=1");
+      await expect(page.getByTestId("form-search-results")).toBeVisible();
+      const main = page.locator("#main-content");
+      await page.evaluate(() => {
+        document.documentElement.style.setProperty("--safe-area-bottom", "112px");
+      });
+      const geometry = await main.evaluate((node) => {
+        const style = window.getComputedStyle(node);
+        return {
+          paddingBottom: Number.parseFloat(style.paddingBottom),
+          marginBottom: Number.parseFloat(style.marginBottom),
+        };
+      });
+      // sm+ uses static desktop padding (pb-8 = 32px) or larger desktop dock
+      // clearance — never the phone hide-collapse path alone.
+      expect(geometry.paddingBottom, viewport.label).toBeGreaterThanOrEqual(32);
+      // Phone-only hide transform should not be active on these widths.
+      const dock = page.locator("form.answer-footer-search-dock");
+      if ((await dock.count()) > 0 && (await dock.first().isVisible())) {
+        await expect(dock.first()).not.toHaveAttribute("data-scroll-hidden", "true");
+      }
+    }
+  });
+
   test("mode toggle keeps forms separate from services", async ({ page }) => {
     await page.setViewportSize({ width: 1280, height: 900 });
     await gotoLauncher(page, "/?mode=answer");

From 10aa7a3ca06710adad6fc5f94aa2efb801e2c3f7 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:30:11 +0000
Subject: [PATCH 5/9] fix(ci): clear ClinicalDashboard budget and knip
 duplicate export

Move visible reserve resolution into mobile-composer-reserve helpers so
the dashboard stays within the no-growth line budget, and drop the
aliased document-viewer reserve export that knip flagged as a duplicate.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/components/ClinicalDashboard.tsx          | 26 +++++-------
 .../global-search-shell.tsx                   | 29 ++++++-------
 .../mobile-composer-reserve.ts                | 42 +++++++++++++++++--
 ...clinical-dashboard-merge-artifacts.test.ts | 13 ++----
 tests/mobile-composer-reserve.test.ts         | 24 +++++++++--
 5 files changed, 87 insertions(+), 47 deletions(-)

diff --git a/src/components/ClinicalDashboard.tsx b/src/components/ClinicalDashboard.tsx
index e05b83d205..90ba502134 100644
--- a/src/components/ClinicalDashboard.tsx
+++ b/src/components/ClinicalDashboard.tsx
@@ -92,7 +92,7 @@ import {
 import { evidenceMapRowsFromRenderModel } from "@/components/clinical-dashboard/evidence-map-model";
 import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header";
 import {
-  mobileComposerVisibleReserve,
+  resolveDashboardVisibleMobileComposerReserve,
   resolveMobileComposerReserve,
 } from "@/components/clinical-dashboard/mobile-composer-reserve";
 import { UniversalSearchAlsoMatches } from "@/components/clinical-dashboard/universal-search-also-matches";
@@ -3253,20 +3253,16 @@ export function ClinicalDashboard({
   const compactMobileBottomSearch = hasMobileBottomSearch && modeSearchSubmitted;
   const differentialsCompareAddonActive =
     searchMode === "differentials" && modeSearchSubmitted && Boolean(query.trim());
-  const visibleMobileComposerReserve =
-    searchMode === "answer"
-      ? answerFollowUpSuggestions.length > 0
-        ? mobileComposerVisibleReserve.dashboardAnswerWithFollowUps
-        : mobileComposerVisibleReserve.dashboardAnswer
-      : differentialsCompareAddonActive
-        ? mobileComposerVisibleReserve.differentialsCompare
-        : compactMobileBottomSearch
-          ? mobileComposerVisibleReserve.dashboardCompactSubmitted
-          : mobileComposerVisibleReserve.dashboardDefaultDock;
-  // Safari's bottom safe-area inset includes its translucent browser toolbar.
-  // Reusing that inset after the app composer hides recreates a toolbar-sized
-  // blank band, so the hidden state intentionally keeps only a small content pad.
-  const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve);
+  // Hidden dock pad must stay at 0.75rem — Safari toolbar safe-area recreates a blank band.
+  const mobileComposerReserve = resolveMobileComposerReserve(
+    bottomComposerHidden,
+    resolveDashboardVisibleMobileComposerReserve({
+      searchMode,
+      hasAnswerFollowUps: answerFollowUpSuggestions.length > 0,
+      differentialsCompareAddonActive,
+      compactMobileBottomSearch,
+    }),
+  );
   const renderDegradedNotice = () => (
     <UtilityDrawer
       icon={!isOnline ? WifiOff : CircleAlert}
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index f792ae5afd..9ca56c27a1 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -30,10 +30,8 @@ import { useFavouritesAccess } from "@/components/clinical-dashboard/use-favouri
 import { MasterSearchHeader } from "@/components/clinical-dashboard/master-search-header";
 import {
   isDocumentViewerOwnedRoute,
-  mobileComposerDocumentViewerShellReserve,
-  mobileComposerIdleReserve,
-  mobileComposerVisibleReserve,
   resolveMobileComposerReserve,
+  resolveShellVisibleMobileComposerReserve,
 } from "@/components/clinical-dashboard/mobile-composer-reserve";
 import { useScrollHideReporter } from "@/components/clinical-dashboard/use-hide-on-scroll";
 import { ModeHomeRouteLoading } from "@/components/mode-home-page-skeleton";
@@ -351,19 +349,6 @@ function GlobalStandaloneSearchShellClient({
   // width), so phones need no bottom-dock clearance there. Document viewer
   // routes own their own floating composer, so the shell keeps only a small pad
   // and lets DocumentViewer manage visible-dock clearance.
-  const visibleMobileComposerReserve = !shouldShowSearchComposer
-    ? isDocumentViewerOwnedRoute(pathname)
-      ? mobileComposerDocumentViewerShellReserve
-      : mobileComposerIdleReserve
-    : isStandaloneModeHome
-      ? mobileComposerIdleReserve
-      : searchMode === "answer"
-        ? mobileComposerVisibleReserve.shellAnswer
-        : differentialsCompareAddonActive
-          ? mobileComposerVisibleReserve.differentialsCompare
-          : useCompactBottomSearch
-            ? mobileComposerVisibleReserve.shellCompactSubmitted
-            : mobileComposerVisibleReserve.shellDefaultDock;
   // Release the large bottom reserve only when the phone bottom composer is
   // actually hidden (MasterSearchHeader's bottomComposerHidden). Header-only
   // scroll-hide, pinned compare addons, open menus/sheets, and composer focus
@@ -372,7 +357,17 @@ function GlobalStandaloneSearchShellClient({
   // Reusing that inset after the app composer hides recreates a toolbar-sized
   // blank band, so the hidden state intentionally keeps only a small content
   // pad. Interactive composer chrome still receives the full inset above.
-  const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve);
+  const mobileComposerReserve = resolveMobileComposerReserve(
+    bottomComposerHidden,
+    resolveShellVisibleMobileComposerReserve({
+      shouldShowSearchComposer,
+      documentViewerOwnedRoute: isDocumentViewerOwnedRoute(pathname),
+      isStandaloneModeHome,
+      searchMode,
+      differentialsCompareAddonActive,
+      useCompactBottomSearch,
+    }),
+  );
 
   useEffect(() => {
     // Re-derive the mode and query from the URL, but only when the search string
diff --git a/src/components/clinical-dashboard/mobile-composer-reserve.ts b/src/components/clinical-dashboard/mobile-composer-reserve.ts
index 34182ffed3..7c54629683 100644
--- a/src/components/clinical-dashboard/mobile-composer-reserve.ts
+++ b/src/components/clinical-dashboard/mobile-composer-reserve.ts
@@ -15,9 +15,6 @@ export const mobileComposerHiddenReserve = "0.75rem";
 /** Routes with no floating bottom dock (info pages, in-flow mode-home composers). */
 export const mobileComposerIdleReserve = "2rem";
 
-/** Shell pad on DocumentViewer-owned routes; the viewer manages dock clearance. */
-export const mobileComposerDocumentViewerShellReserve = mobileComposerHiddenReserve;
-
 /** Differentials Compare selected bar + compact search pill. */
 export const mobileComposerDifferentialsCompareReserve = "calc(12.5rem + var(--safe-area-bottom))";
 
@@ -42,3 +39,42 @@ export function isDocumentViewerOwnedRoute(pathname: string): boolean {
   if (!pathname.startsWith("/documents/")) return false;
   return pathname !== "/documents/search";
 }
+
+export function resolveDashboardVisibleMobileComposerReserve(input: {
+  searchMode: string;
+  hasAnswerFollowUps: boolean;
+  differentialsCompareAddonActive: boolean;
+  compactMobileBottomSearch: boolean;
+}): string {
+  if (input.searchMode === "answer") {
+    return input.hasAnswerFollowUps
+      ? mobileComposerVisibleReserve.dashboardAnswerWithFollowUps
+      : mobileComposerVisibleReserve.dashboardAnswer;
+  }
+  if (input.differentialsCompareAddonActive) {
+    return mobileComposerVisibleReserve.differentialsCompare;
+  }
+  return input.compactMobileBottomSearch
+    ? mobileComposerVisibleReserve.dashboardCompactSubmitted
+    : mobileComposerVisibleReserve.dashboardDefaultDock;
+}
+
+export function resolveShellVisibleMobileComposerReserve(input: {
+  shouldShowSearchComposer: boolean;
+  documentViewerOwnedRoute: boolean;
+  isStandaloneModeHome: boolean;
+  searchMode: string;
+  differentialsCompareAddonActive: boolean;
+  useCompactBottomSearch: boolean;
+}): string {
+  if (!input.shouldShowSearchComposer) {
+    // DocumentViewer owns its dock; shell keeps only the hidden-size pad.
+    return input.documentViewerOwnedRoute ? mobileComposerHiddenReserve : mobileComposerIdleReserve;
+  }
+  if (input.isStandaloneModeHome) return mobileComposerIdleReserve;
+  if (input.searchMode === "answer") return mobileComposerVisibleReserve.shellAnswer;
+  if (input.differentialsCompareAddonActive) return mobileComposerVisibleReserve.differentialsCompare;
+  return input.useCompactBottomSearch
+    ? mobileComposerVisibleReserve.shellCompactSubmitted
+    : mobileComposerVisibleReserve.shellDefaultDock;
+}
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index 043b11260a..a96add49f3 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -117,10 +117,8 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(mobileComposerReserveSource).toContain("export function isDocumentViewerOwnedRoute");
     expect(mobileComposerReserveSource).not.toContain("env(safe-area-inset-bottom)");
 
-    expect(globalSearchShellSource).toContain("const visibleMobileComposerReserve = !shouldShowSearchComposer");
-    expect(globalSearchShellSource).toContain(
-      "const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve)",
-    );
+    expect(globalSearchShellSource).toContain("resolveShellVisibleMobileComposerReserve");
+    expect(globalSearchShellSource).toContain("resolveMobileComposerReserve(");
     expect(globalSearchShellSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
     expect(globalSearchShellSource).not.toContain(
       'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
@@ -129,15 +127,12 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(globalSearchShellSource).not.toContain('"max(2rem, var(--safe-area-bottom))"');
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = !reservesFloatingComposer");
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
-    expect(globalSearchShellSource).toContain("mobileComposerVisibleReserve.differentialsCompare");
     expect(globalSearchShellSource).toContain("sm:pb-[calc(9rem+var(--safe-area-bottom))]");
     expect(globalSearchShellSource).not.toContain("sm:pb-[calc(9rem+env(safe-area-inset-bottom))]");
 
-    expect(clinicalDashboardSource).toContain(
-      "const mobileComposerReserve = resolveMobileComposerReserve(bottomComposerHidden, visibleMobileComposerReserve)",
-    );
+    expect(clinicalDashboardSource).toContain("resolveDashboardVisibleMobileComposerReserve");
+    expect(clinicalDashboardSource).toContain("resolveMobileComposerReserve(");
     expect(clinicalDashboardSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
-    expect(clinicalDashboardSource).toContain("mobileComposerVisibleReserve.differentialsCompare");
     expect(clinicalDashboardSource).not.toContain(
       'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
     );
diff --git a/tests/mobile-composer-reserve.test.ts b/tests/mobile-composer-reserve.test.ts
index 0e79ffed21..b50e51e900 100644
--- a/tests/mobile-composer-reserve.test.ts
+++ b/tests/mobile-composer-reserve.test.ts
@@ -3,11 +3,12 @@ import { describe, expect, it } from "vitest";
 import {
   isDocumentViewerOwnedRoute,
   mobileComposerDifferentialsCompareReserve,
-  mobileComposerDocumentViewerShellReserve,
   mobileComposerHiddenReserve,
   mobileComposerIdleReserve,
   mobileComposerVisibleReserve,
+  resolveDashboardVisibleMobileComposerReserve,
   resolveMobileComposerReserve,
+  resolveShellVisibleMobileComposerReserve,
 } from "@/components/clinical-dashboard/mobile-composer-reserve";
 
 describe("mobile composer reserve contract", () => {
@@ -23,9 +24,18 @@ describe("mobile composer reserve contract", () => {
     expect(mobileComposerHiddenReserve).not.toContain("env(");
   });
 
-  it("keeps document-viewer shell pad at the hidden size", () => {
-    expect(mobileComposerDocumentViewerShellReserve).toBe(mobileComposerHiddenReserve);
+  it("keeps idle and document-viewer shell pads free of toolbar insets", () => {
     expect(mobileComposerIdleReserve).toBe("2rem");
+    expect(
+      resolveShellVisibleMobileComposerReserve({
+        shouldShowSearchComposer: false,
+        documentViewerOwnedRoute: true,
+        isStandaloneModeHome: false,
+        searchMode: "documents",
+        differentialsCompareAddonActive: false,
+        useCompactBottomSearch: false,
+      }),
+    ).toBe(mobileComposerHiddenReserve);
   });
 
   it("keeps differentials compare clearance shared across hosts", () => {
@@ -33,6 +43,14 @@ describe("mobile composer reserve contract", () => {
     expect(mobileComposerDifferentialsCompareReserve).toContain("12.5rem");
     expect(mobileComposerDifferentialsCompareReserve).toContain("var(--safe-area-bottom)");
     expect(mobileComposerDifferentialsCompareReserve).not.toContain("env(safe-area-inset-bottom)");
+    expect(
+      resolveDashboardVisibleMobileComposerReserve({
+        searchMode: "differentials",
+        hasAnswerFollowUps: false,
+        differentialsCompareAddonActive: true,
+        compactMobileBottomSearch: true,
+      }),
+    ).toBe(mobileComposerDifferentialsCompareReserve);
   });
 
   it("classifies document viewer owned routes", () => {

From c99f39b020a2285df83cc125ae06f7ef1067a0ad Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:39:32 +0000
Subject: [PATCH 6/9] fix(ui): use flex spacer for phone dock scroll clearance

Padding-bottom on the shell's column flex scrollport was omitted from
scrollHeight, so long service pages parked footers under the visible dock.
Move phone reserve onto a sibling spacer, drop min-h-dvh overflow on phone
detail pages, and point Playwright proofs at the spacer height.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/app/globals.css                           | 22 +++--
 .../global-search-shell.tsx                   | 18 ++--
 src/components/forms/form-detail-page.tsx     |  2 +-
 .../services/service-detail-page.tsx          |  5 +-
 ...clinical-dashboard-merge-artifacts.test.ts | 30 ++++---
 tests/playwright-scroll.ts                    | 15 +++-
 tests/ui-smoke.spec.ts                        | 18 ++--
 tests/ui-tools.spec.ts                        | 85 ++++++++++---------
 8 files changed, 112 insertions(+), 83 deletions(-)

diff --git a/src/app/globals.css b/src/app/globals.css
index a28fc1b2ec..38a43a3e46 100644
--- a/src/app/globals.css
+++ b/src/app/globals.css
@@ -1809,18 +1809,12 @@ summary::-webkit-details-marker {
   /* Differentials search results: compare action sits above the search pill in the dock.
      Heights track --phone-dock-differentials-compare-* (same as content reserve). */
   .answer-footer-search-dock[data-footer-addon="differentials-compare"] .answer-footer-search-backdrop {
-    height: max(
-      var(--phone-dock-differentials-compare-clearance),
-      calc(var(--safe-area-bottom) + 11.25rem)
-    );
+    height: max(var(--phone-dock-differentials-compare-clearance), calc(var(--safe-area-bottom) + 11.25rem));
   }
 
   .answer-footer-search-dock.document-mobile-search-compact[data-footer-addon="differentials-compare"]
     .answer-footer-search-backdrop {
-    height: max(
-      var(--phone-dock-differentials-compare-compact-clearance),
-      calc(var(--safe-area-bottom) + 11rem)
-    );
+    height: max(var(--phone-dock-differentials-compare-compact-clearance), calc(var(--safe-area-bottom) + 11rem));
   }
 
   .document-mobile-search-pill {
@@ -2592,7 +2586,9 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
   }
 }
 
-/* iOS Safari bottom padding transitions to match the composer's hide/show motion */
+/* iOS Safari bottom reserve transitions to match the composer's hide/show motion.
+   Shell routes animate the flex spacer height (padding is unreliable in a column
+   flex scrollport). Dashboard/answer and DocumentViewer still animate padding. */
 @media (max-width: 639px) {
   #main-content {
     transition: padding-bottom 200ms cubic-bezier(0.22, 1, 0.36, 1);
@@ -2600,6 +2596,12 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
   #main-content[data-bottom-composer-hidden="true"] {
     transition: padding-bottom 240ms cubic-bezier(0.4, 0, 0.2, 1);
   }
+  #main-content [data-testid="mobile-composer-reserve-spacer"] {
+    transition: height 200ms cubic-bezier(0.22, 1, 0.36, 1);
+  }
+  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-spacer"] {
+    transition: height 240ms cubic-bezier(0.4, 0, 0.2, 1);
+  }
   [data-testid="document-viewer-content"] {
     transition: padding-bottom 200ms cubic-bezier(0.22, 1, 0.36, 1);
   }
@@ -2611,6 +2613,8 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
 @media (max-width: 639px) and (prefers-reduced-motion: reduce) {
   #main-content,
   #main-content[data-bottom-composer-hidden="true"],
+  #main-content [data-testid="mobile-composer-reserve-spacer"],
+  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-spacer"],
   [data-testid="document-viewer-content"],
   [data-testid="document-viewer-content"][data-scroll-hidden="true"] {
     transition: none;
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index 9ca56c27a1..f8e7cb7f4e 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -737,16 +737,18 @@ function GlobalStandaloneSearchShellClient({
             // window does the actual scrolling — silently disabling every
             // position:sticky descendant (e.g. the document viewer rail).
             "min-w-0 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-[-2px] focus-visible:outline-[color:var(--focus)] max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col max-sm:overflow-x-hidden max-sm:overflow-y-auto max-sm:overscroll-contain max-sm:[-webkit-overflow-scrolling:touch] sm:min-h-[calc(100dvh-4rem)] sm:overflow-x-clip",
-            // Phone (max-sm): collapse-aware --mobile-composer-reserve.
+            // Phone clearance uses a flex spacer sibling below (not padding):
+            // padding-bottom on a column flex scrollport is omitted from
+            // scrollHeight, so long pages parked content under the dock.
             // sm+: static desktop clearance; use var(--safe-area-bottom) so tests
             // can simulate insets without depending on env() in Chromium.
             !reservesFloatingComposer
-              ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-8"
+              ? "sm:pb-8"
               : searchMode === "answer"
-                ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+var(--safe-area-bottom))]"
+                ? "sm:pb-[calc(9rem+var(--safe-area-bottom))]"
                 : useCompactBottomSearch
-                  ? "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-8"
-                  : "max-sm:pb-[var(--mobile-composer-reserve)] sm:pb-[calc(9rem+var(--safe-area-bottom))]",
+                  ? "sm:pb-8"
+                  : "sm:pb-[calc(9rem+var(--safe-area-bottom))]",
           )}
         >
           <div className="max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col">
@@ -756,6 +758,12 @@ function GlobalStandaloneSearchShellClient({
               <SearchCommandProvider value={searchCommandContextValue}>{children}</SearchCommandProvider>
             </ClientHydrationBoundary>
           </div>
+          <div
+            aria-hidden="true"
+            data-testid="mobile-composer-reserve-spacer"
+            className="pointer-events-none max-sm:block max-sm:shrink-0 sm:hidden"
+            style={{ height: "var(--mobile-composer-reserve)" }}
+          />
         </div>
       </div>
 
diff --git a/src/components/forms/form-detail-page.tsx b/src/components/forms/form-detail-page.tsx
index faec3ea763..64051ca74f 100644
--- a/src/components/forms/form-detail-page.tsx
+++ b/src/components/forms/form-detail-page.tsx
@@ -559,7 +559,7 @@ export function FormDetailPage({ form }: { form: FormRecord }) {
   return (
     <main
       data-testid="form-detail-page"
-      className="min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 pb-4 pt-4 text-[color:var(--text)] sm:px-5 sm:pb-10 sm:pt-6 lg:px-8"
+      className="max-sm:min-h-0 bg-[color:var(--background)] px-3 pb-4 pt-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:px-5 sm:pb-10 sm:pt-6 lg:px-8"
     >
       <div className={pageContainer}>
         {notice ? (
diff --git a/src/components/services/service-detail-page.tsx b/src/components/services/service-detail-page.tsx
index 696c6ea566..4756992ca1 100644
--- a/src/components/services/service-detail-page.tsx
+++ b/src/components/services/service-detail-page.tsx
@@ -505,7 +505,10 @@ export function ServiceDetailPage({ service }: { service: ServiceRecord }) {
   return (
     <main
       data-testid="service-detail-page"
-      className="min-h-[calc(100dvh-4rem)] max-sm:shrink-0 bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-8"
+      // Phone shell already owns dock clearance via --mobile-composer-reserve.
+      // A 100dvh min-height here overflows the inset scrollport and parks the
+      // page footer under the visible dock even when the shell pad is correct.
+      className="max-sm:min-h-0 max-sm:shrink-0 bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:px-5 sm:py-6 sm:pb-10 lg:px-8"
     >
       <div className={pageContainer}>
         {notice ? (
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index a96add49f3..e55260731e 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -40,10 +40,16 @@ const applicationsLauncherSource = readFileSync(
   resolve(process.cwd(), "src/components/applications-launcher-page.tsx"),
   "utf8",
 );
-const serviceDetailSource = readFileSync(resolve(process.cwd(), "src/components/services/service-detail-page.tsx"), "utf8");
+const serviceDetailSource = readFileSync(
+  resolve(process.cwd(), "src/components/services/service-detail-page.tsx"),
+  "utf8",
+);
 const formDetailSource = readFileSync(resolve(process.cwd(), "src/components/forms/form-detail-page.tsx"), "utf8");
 const specifierUiSource = readFileSync(resolve(process.cwd(), "src/components/specifiers/specifier-ui.tsx"), "utf8");
-const formulationUiSource = readFileSync(resolve(process.cwd(), "src/components/formulation/formulation-ui.tsx"), "utf8");
+const formulationUiSource = readFileSync(
+  resolve(process.cwd(), "src/components/formulation/formulation-ui.tsx"),
+  "utf8",
+);
 const favouritesLibrarySource = readFileSync(
   resolve(process.cwd(), "src/components/clinical-dashboard/favourites-command-library-page.tsx"),
   "utf8",
@@ -120,35 +126,35 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(globalSearchShellSource).toContain("resolveShellVisibleMobileComposerReserve");
     expect(globalSearchShellSource).toContain("resolveMobileComposerReserve(");
     expect(globalSearchShellSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
-    expect(globalSearchShellSource).not.toContain(
-      'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
-    );
+    expect(globalSearchShellSource).not.toContain('bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"');
     expect(globalSearchShellSource).not.toContain('bottomComposerHidden ? "max(0.75rem, var(--safe-area-bottom))"');
     expect(globalSearchShellSource).not.toContain('"max(2rem, var(--safe-area-bottom))"');
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = !reservesFloatingComposer");
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
     expect(globalSearchShellSource).toContain("sm:pb-[calc(9rem+var(--safe-area-bottom))]");
     expect(globalSearchShellSource).not.toContain("sm:pb-[calc(9rem+env(safe-area-inset-bottom))]");
+    // Phone shell clearance is a flex spacer (padding is omitted from scrollHeight
+    // on a column flex scrollport).
+    expect(globalSearchShellSource).toContain('data-testid="mobile-composer-reserve-spacer"');
+    expect(globalSearchShellSource).toContain('height: "var(--mobile-composer-reserve)"');
+    expect(globalSearchShellSource).not.toContain("max-sm:pb-[var(--mobile-composer-reserve)]");
 
     expect(clinicalDashboardSource).toContain("resolveDashboardVisibleMobileComposerReserve");
     expect(clinicalDashboardSource).toContain("resolveMobileComposerReserve(");
     expect(clinicalDashboardSource).toContain('from "@/components/clinical-dashboard/mobile-composer-reserve"');
-    expect(clinicalDashboardSource).not.toContain(
-      'bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"',
-    );
+    expect(clinicalDashboardSource).not.toContain('bottomComposerHidden ? "max(0.75rem, env(safe-area-inset-bottom))"');
     expect(clinicalDashboardSource).toContain('"max-sm:pb-[var(--mobile-composer-reserve)] sm:mb-24"');
 
     expect(documentViewerSource).toContain('data-testid="document-viewer-content"');
     expect(documentViewerSource).toContain('"max-sm:pb-3"');
     expect(documentViewerSource).toContain('"max-sm:pb-[calc(9rem+var(--safe-area-bottom))]"');
     // Hidden document content must not reintroduce Safari toolbar inset padding.
-    expect(documentViewerSource).not.toMatch(
-      /composerScrollHidden\s*\?\s*["']max-sm:pb-\[calc\([^"']*safe-area/,
-    );
+    expect(documentViewerSource).not.toMatch(/composerScrollHidden\s*\?\s*["']max-sm:pb-\[calc\([^"']*safe-area/);
     expect(documentViewerSource).toContain("max-sm:duration-[240ms]");
     expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
     expect(globalStylesSource).toContain("@media (max-width: 639px) and (prefers-reduced-motion: reduce)");
     expect(globalStylesSource).toContain('#main-content[data-bottom-composer-hidden="true"]');
+    expect(globalStylesSource).toContain('[data-testid="mobile-composer-reserve-spacer"]');
     expect(globalStylesSource).toContain("--phone-dock-differentials-compare-clearance: 12.5rem");
     expect(globalStylesSource).toContain("var(--phone-dock-differentials-compare-clearance)");
     // Child pages must not stack a second dock-sized safe-area pad under the
@@ -157,7 +163,9 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(differentialsHomeSource).not.toContain("pb-[calc(12.5rem+env(safe-area-inset-bottom))]");
     expect(applicationsLauncherSource).not.toContain("pb-[calc(12rem+env(safe-area-inset-bottom))]");
     expect(serviceDetailSource).not.toContain("pb-[calc(5.5rem+env(safe-area-inset-bottom))]");
+    expect(serviceDetailSource).toContain("max-sm:min-h-0");
     expect(formDetailSource).not.toContain("pb-[calc(2rem+env(safe-area-inset-bottom))]");
+    expect(formDetailSource).toContain("max-sm:min-h-0");
     expect(specifierUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
     expect(formulationUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
     expect(favouritesLibrarySource).not.toContain("pb-[calc(6rem+env(safe-area-inset-bottom))]");
diff --git a/tests/playwright-scroll.ts b/tests/playwright-scroll.ts
index 36b17a9ed3..0c04b322e1 100644
--- a/tests/playwright-scroll.ts
+++ b/tests/playwright-scroll.ts
@@ -1,4 +1,17 @@
-import type { Page } from "playwright/test";
+import type { Locator, Page } from "playwright/test";
+
+/**
+ * Phone dock clearance in CSS pixels for #main-content.
+ * GlobalSearchShell uses a flex spacer (padding is omitted from scrollHeight on
+ * column flex scrollports); ClinicalDashboard still uses padding-bottom.
+ */
+export async function readMobileComposerReservePx(main: Locator): Promise<number> {
+  return main.evaluate((node) => {
+    const spacer = node.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
+    if (spacer) return spacer.getBoundingClientRect().height;
+    return Number.parseFloat(window.getComputedStyle(node).paddingBottom);
+  });
+}
 
 /** Scroll the app's primary phone surface (#main-content when present, else the document). */
 export async function scrollPrimarySurface(page: Page, top: number) {
diff --git a/tests/ui-smoke.spec.ts b/tests/ui-smoke.spec.ts
index 9370f6d8c0..b1bb3d829c 100644
--- a/tests/ui-smoke.spec.ts
+++ b/tests/ui-smoke.spec.ts
@@ -1,6 +1,6 @@
 import type { Route } from "playwright-core";
 import { expect, test, type Locator, type Page } from "playwright/test";
-import { scrollPrimarySurface } from "./playwright-scroll";
+import { readMobileComposerReservePx, scrollPrimarySurface } from "./playwright-scroll";
 import { answerThreadStorageKey } from "../src/lib/answer-thread-storage";
 import { documentSummaryQuestion } from "../src/lib/answer-contract";
 import { demoAnswer, demoDocuments, demoSummary, getDemoDocument, getDemoDocumentPayload } from "../src/lib/demo-data";
@@ -3541,9 +3541,7 @@ test.describe("Clinical KB UI smoke coverage", () => {
     // pad even when Safari's toolbar inset is large — otherwise #932's
     // max(2rem, --safe-area-bottom) shell reserve recreates the blank band
     // under the viewer while the viewer itself collapses correctly.
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeLessThanOrEqual(13);
     await expect
       .poll(async () =>
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
@@ -3575,9 +3573,7 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeLessThanOrEqual(13);
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeLessThanOrEqual(13);
 
     // Reappear on scroll up.
     await scrollPrimarySurface(page, 60);
@@ -3587,9 +3583,7 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeGreaterThan(250);
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeLessThanOrEqual(13);
 
     // Keyboard focus inside the composer reveals it while hidden.
     await scrollPrimarySurface(page, 240);
@@ -3601,9 +3595,7 @@ test.describe("Clinical KB UI smoke coverage", () => {
         viewerContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
       )
       .toBeGreaterThan(250);
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeLessThanOrEqual(13);
   });
 
   test("document questions use the shared answer stream with progress and cleaned bold formatting", async ({
diff --git a/tests/ui-tools.spec.ts b/tests/ui-tools.spec.ts
index 98308d37f7..8197e742d4 100644
--- a/tests/ui-tools.spec.ts
+++ b/tests/ui-tools.spec.ts
@@ -8,7 +8,7 @@ import { medicationToSearchResult, rankMedicationRecords } from "../src/lib/medi
 import { sortResultItems } from "../src/lib/result-sort";
 import { serviceRecords } from "../src/lib/services";
 import { openAppModeMenu } from "./playwright-app-mode";
-import { scrollPrimarySurface } from "./playwright-scroll";
+import { readMobileComposerReservePx, scrollPrimarySurface } from "./playwright-scroll";
 
 const readySetupChecks = [
   { id: "env", label: ".env.local configured", status: "ready", detail: "Test environment ready." },
@@ -1028,9 +1028,7 @@ test.describe("Clinical KB tools launcher", () => {
     await page.evaluate(() => {
       document.documentElement.style.setProperty("--safe-area-bottom", "112px");
     });
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeGreaterThan(112);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeGreaterThan(112);
     const visibleMainGeometry = await main.evaluate((node) => {
       const style = window.getComputedStyle(node);
       return {
@@ -1090,9 +1088,7 @@ test.describe("Clinical KB tools launcher", () => {
     await expect
       .poll(async () => dock.evaluate((node) => window.getComputedStyle(node).transform !== "none"))
       .toBe(true);
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeLessThanOrEqual(13);
     const hiddenMainGeometry = await main.evaluate((node) => {
       const style = window.getComputedStyle(node);
       return {
@@ -1109,9 +1105,7 @@ test.describe("Clinical KB tools launcher", () => {
     await expect
       .poll(async () => dock.evaluate((node) => window.getComputedStyle(node).transform === "none"))
       .toBe(true);
-    await expect
-      .poll(async () => main.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeGreaterThan(112);
+    await expect.poll(async () => readMobileComposerReservePx(main)).toBeGreaterThan(112);
   });
 
   test("tablet and desktop forms results keep non-phone bottom clearance", async ({ page }) => {
@@ -1559,32 +1553,25 @@ test.describe("Clinical KB tools launcher", () => {
     // hide-on-scroll cannot collapse --mobile-composer-reserve mid-check.
     await input.focus();
     await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
-    await expect
-      .poll(async () =>
-        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
-      )
-      .toBeGreaterThan(180);
+    await expect.poll(async () => readMobileComposerReservePx(mainContent)).toBeGreaterThan(180);
     await mainContent.evaluate((element) => element.scrollTo({ top: element.scrollHeight, behavior: "instant" }));
     await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
-    await expect
-      .poll(async () =>
-        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
-      )
-      .toBeGreaterThan(180);
+    await expect.poll(async () => readMobileComposerReservePx(mainContent)).toBeGreaterThan(180);
     const clearance = await page.evaluate(() => {
       const main = document.getElementById("main-content");
       const last = document.querySelector('[data-testid="differential-mobile-result-card"]:last-of-type');
       const dock = document.querySelector("form.answer-footer-search-dock");
       const style = main ? window.getComputedStyle(main) : null;
+      const spacer = main?.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
       return {
         lastBottom: last?.getBoundingClientRect().bottom ?? null,
         dockTop: dock?.getBoundingClientRect().top ?? null,
-        paddingBottom: style ? Number.parseFloat(style.paddingBottom) : null,
-        reserve:
-          main?.parentElement
-            ? window.getComputedStyle(main.parentElement).getPropertyValue("--mobile-composer-reserve").trim()
+        reservePx: spacer
+          ? spacer.getBoundingClientRect().height
+          : style
+            ? Number.parseFloat(style.paddingBottom)
             : null,
-        selfReserve: style?.getPropertyValue("--mobile-composer-reserve").trim() ?? null,
+        reserve: style?.getPropertyValue("--mobile-composer-reserve").trim() ?? null,
         scrollHidden: dock?.getAttribute("data-scroll-hidden"),
         url: window.location.href,
       };
@@ -1617,11 +1604,9 @@ test.describe("Clinical KB tools launcher", () => {
     // Last card must clear the floating compare CTA, not only the composer dock.
     expect(clearance.lastBottom ?? Number.POSITIVE_INFINITY).toBeLessThanOrEqual(revealedGeometry.top);
 
-    const mainPaddingBottom = await mainContent.evaluate((element) =>
-      Number.parseFloat(window.getComputedStyle(element).paddingBottom),
-    );
+    const reservePx = await readMobileComposerReservePx(mainContent);
     const dockHeight = await dock.evaluate((element) => element.getBoundingClientRect().height);
-    expect(mainPaddingBottom).toBeGreaterThanOrEqual(dockHeight);
+    expect(reservePx).toBeGreaterThanOrEqual(dockHeight);
 
     // Ensure enough scroll room for hide thresholds even with a short result list.
     await page.evaluate(() => {
@@ -1641,11 +1626,7 @@ test.describe("Clinical KB tools launcher", () => {
     await page.evaluate(() => {
       document.documentElement.style.setProperty("--safe-area-bottom", "112px");
     });
-    await expect
-      .poll(async () =>
-        mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)),
-      )
-      .toBeGreaterThan(200);
+    await expect.poll(async () => readMobileComposerReservePx(mainContent)).toBeGreaterThan(200);
 
     await expect(async () => {
       await input.blur();
@@ -1660,9 +1641,7 @@ test.describe("Clinical KB tools launcher", () => {
     await expect
       .poll(async () => dock.evaluate((node) => window.getComputedStyle(node).transform !== "none"))
       .toBe(true);
-    await expect
-      .poll(async () => mainContent.evaluate((node) => Number.parseFloat(window.getComputedStyle(node).paddingBottom)))
-      .toBeLessThanOrEqual(13);
+    await expect.poll(async () => readMobileComposerReservePx(mainContent)).toBeLessThanOrEqual(13);
 
     // Wait for the hide transition to finish so the in-dock Compare bar is fully
     // off-screen (translateY(100%) parks the dock top on the viewport bottom edge).
@@ -1858,8 +1837,17 @@ test.describe("Clinical KB service detail page", () => {
     const servicePage = page.getByTestId("service-detail-page");
     const footer = servicePage.getByText("Information accuracy may vary. Confirm locally before use.");
     const scrollport = page.locator("#main-content");
+    const dock = page.locator("form.answer-footer-search-dock, form.answer-footer-search-edge").first();
+    const dockInput = visibleGlobalSearchInput(page).first();
     await expect(servicePage).toBeVisible();
+    await expect(dock).toBeVisible();
+    // Keep the dock focused so hide-on-scroll cannot collapse --mobile-composer-reserve
+    // while we measure end-of-page clearance under a still-visible composer.
+    await dockInput.focus();
+    await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
+    await expect.poll(async () => readMobileComposerReservePx(scrollport)).toBeGreaterThan(120);
     await scrollport.evaluate((element) => element.scrollTo({ top: element.scrollHeight, behavior: "instant" }));
+    await expect(dock).not.toHaveAttribute("data-scroll-hidden", "true");
 
     await expect
       .poll(() => scrollport.evaluate((element) => element.scrollHeight - element.clientHeight - element.scrollTop))
@@ -1867,19 +1855,32 @@ test.describe("Clinical KB service detail page", () => {
 
     const clearance = await footer.evaluate((element) => {
       const scrollElement = document.querySelector<HTMLElement>("#main-content");
-      const dock = document.querySelector<HTMLElement>(
+      const dockElement = document.querySelector<HTMLElement>(
         "form.answer-footer-search-dock, form.answer-footer-search-edge",
       );
-      if (!scrollElement || !dock) return null;
+      const servicePage = document.querySelector<HTMLElement>('[data-testid="service-detail-page"]');
+      if (!scrollElement || !dockElement) return null;
+      const scrollStyle = window.getComputedStyle(scrollElement);
+      const spacer = scrollElement.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
       return {
         footerBottom: element.getBoundingClientRect().bottom,
         scrollBottom: scrollElement.getBoundingClientRect().bottom,
-        dockHeight: dock.getBoundingClientRect().height,
+        dockTop: dockElement.getBoundingClientRect().top,
+        dockHeight: dockElement.getBoundingClientRect().height,
+        reservePx: spacer ? spacer.getBoundingClientRect().height : Number.parseFloat(scrollStyle.paddingBottom),
+        reserve: scrollStyle.getPropertyValue("--mobile-composer-reserve").trim(),
+        scrollTop: scrollElement.scrollTop,
+        scrollHeight: scrollElement.scrollHeight,
+        clientHeight: scrollElement.clientHeight,
+        serviceBottom: servicePage?.getBoundingClientRect().bottom ?? null,
+        serviceHeight: servicePage?.getBoundingClientRect().height ?? null,
+        scrollHidden: dockElement.getAttribute("data-scroll-hidden"),
       };
     });
 
-    expect(clearance).not.toBeNull();
-    expect(clearance!.footerBottom).toBeLessThanOrEqual(clearance!.scrollBottom - clearance!.dockHeight - 8);
+    expect(clearance, JSON.stringify(clearance)).not.toBeNull();
+    expect(clearance!.reservePx, JSON.stringify(clearance)).toBeGreaterThan(120);
+    expect(clearance!.footerBottom, JSON.stringify(clearance)).toBeLessThanOrEqual(clearance!.dockTop - 8);
   });
 
   test("service navigator action uses the shared global search route", async ({ page }) => {

From 666a6b2b629db8109a45e89631ccc94fdf43ae6f Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 19:43:34 +0000
Subject: [PATCH 7/9] fix(ui): clear phone dock with inner reserve pad

A flex spacer sibling never extended scrollHeight when the content child
overflowed a flex-1 min-h-0 wrapper. Use a block scrollport with an inner
padding pad so end-of-page content clears the visible composer.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/app/globals.css                           | 16 +++++++-------
 .../global-search-shell.tsx                   | 22 +++++++++----------
 ...clinical-dashboard-merge-artifacts.test.ts | 11 +++++-----
 tests/playwright-scroll.ts                    |  8 +++----
 tests/ui-tools.spec.ts                        | 12 +++++-----
 5 files changed, 35 insertions(+), 34 deletions(-)

diff --git a/src/app/globals.css b/src/app/globals.css
index 38a43a3e46..eb75cb6667 100644
--- a/src/app/globals.css
+++ b/src/app/globals.css
@@ -2587,8 +2587,8 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
 }
 
 /* iOS Safari bottom reserve transitions to match the composer's hide/show motion.
-   Shell routes animate the flex spacer height (padding is unreliable in a column
-   flex scrollport). Dashboard/answer and DocumentViewer still animate padding. */
+   Shell routes animate the inner reserve pad; dashboard/answer animates
+   #main-content padding; DocumentViewer animates its own content pad. */
 @media (max-width: 639px) {
   #main-content {
     transition: padding-bottom 200ms cubic-bezier(0.22, 1, 0.36, 1);
@@ -2596,11 +2596,11 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
   #main-content[data-bottom-composer-hidden="true"] {
     transition: padding-bottom 240ms cubic-bezier(0.4, 0, 0.2, 1);
   }
-  #main-content [data-testid="mobile-composer-reserve-spacer"] {
-    transition: height 200ms cubic-bezier(0.22, 1, 0.36, 1);
+  #main-content [data-testid="mobile-composer-reserve-pad"] {
+    transition: padding-bottom 200ms cubic-bezier(0.22, 1, 0.36, 1);
   }
-  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-spacer"] {
-    transition: height 240ms cubic-bezier(0.4, 0, 0.2, 1);
+  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-pad"] {
+    transition: padding-bottom 240ms cubic-bezier(0.4, 0, 0.2, 1);
   }
   [data-testid="document-viewer-content"] {
     transition: padding-bottom 200ms cubic-bezier(0.22, 1, 0.36, 1);
@@ -2613,8 +2613,8 @@ html[data-motion="reduced"] .source-capsule-hit[aria-expanded="true"]:hover .sou
 @media (max-width: 639px) and (prefers-reduced-motion: reduce) {
   #main-content,
   #main-content[data-bottom-composer-hidden="true"],
-  #main-content [data-testid="mobile-composer-reserve-spacer"],
-  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-spacer"],
+  #main-content [data-testid="mobile-composer-reserve-pad"],
+  #main-content[data-bottom-composer-hidden="true"] [data-testid="mobile-composer-reserve-pad"],
   [data-testid="document-viewer-content"],
   [data-testid="document-viewer-content"][data-scroll-hidden="true"] {
     transition: none;
diff --git a/src/components/clinical-dashboard/global-search-shell.tsx b/src/components/clinical-dashboard/global-search-shell.tsx
index f8e7cb7f4e..58c3e2baa2 100644
--- a/src/components/clinical-dashboard/global-search-shell.tsx
+++ b/src/components/clinical-dashboard/global-search-shell.tsx
@@ -736,10 +736,10 @@ function GlobalStandaloneSearchShellClient({
             // auto, which turns #main-content into the sticky scrollport while the
             // window does the actual scrolling — silently disabling every
             // position:sticky descendant (e.g. the document viewer rail).
-            "min-w-0 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-[-2px] focus-visible:outline-[color:var(--focus)] max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col max-sm:overflow-x-hidden max-sm:overflow-y-auto max-sm:overscroll-contain max-sm:[-webkit-overflow-scrolling:touch] sm:min-h-[calc(100dvh-4rem)] sm:overflow-x-clip",
-            // Phone clearance uses a flex spacer sibling below (not padding):
-            // padding-bottom on a column flex scrollport is omitted from
-            // scrollHeight, so long pages parked content under the dock.
+            // Phone: keep a block formatting scrollport (not a column flex). A
+            // flex-1 child overflowed past a sibling spacer without extending
+            // scrollHeight, which parked long pages under the visible dock.
+            "min-w-0 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-[-2px] focus-visible:outline-[color:var(--focus)] max-sm:min-h-0 max-sm:flex-1 max-sm:overflow-x-hidden max-sm:overflow-y-auto max-sm:overscroll-contain max-sm:[-webkit-overflow-scrolling:touch] sm:min-h-[calc(100dvh-4rem)] sm:overflow-x-clip",
             // sm+: static desktop clearance; use var(--safe-area-bottom) so tests
             // can simulate insets without depending on env() in Chromium.
             !reservesFloatingComposer
@@ -751,19 +751,19 @@ function GlobalStandaloneSearchShellClient({
                   : "sm:pb-[calc(9rem+var(--safe-area-bottom))]",
           )}
         >
-          <div className="max-sm:flex max-sm:min-h-0 max-sm:flex-1 max-sm:flex-col">
+          {/*
+            Phone dock clearance lives on this inner pad (not #main-content):
+            padding on the scrollport itself is omitted from scrollHeight in some
+            flex/overflow combinations. The inner block box includes padding in
+            its height, so end-of-page content clears the visible dock.
+          */}
+          <div data-testid="mobile-composer-reserve-pad" className="max-sm:pb-[var(--mobile-composer-reserve)]">
             <ClientHydrationBoundary
               fallback={<div className="min-h-[calc(100dvh-4rem)] overflow-x-hidden" aria-hidden />}
             >
               <SearchCommandProvider value={searchCommandContextValue}>{children}</SearchCommandProvider>
             </ClientHydrationBoundary>
           </div>
-          <div
-            aria-hidden="true"
-            data-testid="mobile-composer-reserve-spacer"
-            className="pointer-events-none max-sm:block max-sm:shrink-0 sm:hidden"
-            style={{ height: "var(--mobile-composer-reserve)" }}
-          />
         </div>
       </div>
 
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index e55260731e..ac2e0d4a9b 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -133,11 +133,10 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(globalSearchShellSource).not.toContain("const mobileComposerReserve = phoneScrollHide.hidden");
     expect(globalSearchShellSource).toContain("sm:pb-[calc(9rem+var(--safe-area-bottom))]");
     expect(globalSearchShellSource).not.toContain("sm:pb-[calc(9rem+env(safe-area-inset-bottom))]");
-    // Phone shell clearance is a flex spacer (padding is omitted from scrollHeight
-    // on a column flex scrollport).
-    expect(globalSearchShellSource).toContain('data-testid="mobile-composer-reserve-spacer"');
-    expect(globalSearchShellSource).toContain('height: "var(--mobile-composer-reserve)"');
-    expect(globalSearchShellSource).not.toContain("max-sm:pb-[var(--mobile-composer-reserve)]");
+    // Phone shell clearance is an inner pad so padding contributes to scrollHeight.
+    expect(globalSearchShellSource).toContain('data-testid="mobile-composer-reserve-pad"');
+    expect(globalSearchShellSource).toContain("max-sm:pb-[var(--mobile-composer-reserve)]");
+    expect(globalSearchShellSource).not.toContain('data-testid="mobile-composer-reserve-spacer"');
 
     expect(clinicalDashboardSource).toContain("resolveDashboardVisibleMobileComposerReserve");
     expect(clinicalDashboardSource).toContain("resolveMobileComposerReserve(");
@@ -154,7 +153,7 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(documentViewerSource).toContain("max-sm:ease-[cubic-bezier(0.4,0,0.2,1)]");
     expect(globalStylesSource).toContain("@media (max-width: 639px) and (prefers-reduced-motion: reduce)");
     expect(globalStylesSource).toContain('#main-content[data-bottom-composer-hidden="true"]');
-    expect(globalStylesSource).toContain('[data-testid="mobile-composer-reserve-spacer"]');
+    expect(globalStylesSource).toContain('[data-testid="mobile-composer-reserve-pad"]');
     expect(globalStylesSource).toContain("--phone-dock-differentials-compare-clearance: 12.5rem");
     expect(globalStylesSource).toContain("var(--phone-dock-differentials-compare-clearance)");
     // Child pages must not stack a second dock-sized safe-area pad under the
diff --git a/tests/playwright-scroll.ts b/tests/playwright-scroll.ts
index 0c04b322e1..e92fb7443f 100644
--- a/tests/playwright-scroll.ts
+++ b/tests/playwright-scroll.ts
@@ -2,13 +2,13 @@ import type { Locator, Page } from "playwright/test";
 
 /**
  * Phone dock clearance in CSS pixels for #main-content.
- * GlobalSearchShell uses a flex spacer (padding is omitted from scrollHeight on
- * column flex scrollports); ClinicalDashboard still uses padding-bottom.
+ * GlobalSearchShell applies the reserve on an inner pad (so it contributes to
+ * scrollHeight); ClinicalDashboard still pads #main-content directly.
  */
 export async function readMobileComposerReservePx(main: Locator): Promise<number> {
   return main.evaluate((node) => {
-    const spacer = node.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
-    if (spacer) return spacer.getBoundingClientRect().height;
+    const pad = node.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-pad"]');
+    if (pad) return Number.parseFloat(window.getComputedStyle(pad).paddingBottom);
     return Number.parseFloat(window.getComputedStyle(node).paddingBottom);
   });
 }
diff --git a/tests/ui-tools.spec.ts b/tests/ui-tools.spec.ts
index 8197e742d4..efad0b8502 100644
--- a/tests/ui-tools.spec.ts
+++ b/tests/ui-tools.spec.ts
@@ -1562,12 +1562,12 @@ test.describe("Clinical KB tools launcher", () => {
       const last = document.querySelector('[data-testid="differential-mobile-result-card"]:last-of-type');
       const dock = document.querySelector("form.answer-footer-search-dock");
       const style = main ? window.getComputedStyle(main) : null;
-      const spacer = main?.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
+      const pad = main?.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-pad"]');
       return {
         lastBottom: last?.getBoundingClientRect().bottom ?? null,
         dockTop: dock?.getBoundingClientRect().top ?? null,
-        reservePx: spacer
-          ? spacer.getBoundingClientRect().height
+        reservePx: pad
+          ? Number.parseFloat(window.getComputedStyle(pad).paddingBottom)
           : style
             ? Number.parseFloat(style.paddingBottom)
             : null,
@@ -1861,13 +1861,15 @@ test.describe("Clinical KB service detail page", () => {
       const servicePage = document.querySelector<HTMLElement>('[data-testid="service-detail-page"]');
       if (!scrollElement || !dockElement) return null;
       const scrollStyle = window.getComputedStyle(scrollElement);
-      const spacer = scrollElement.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-spacer"]');
+      const pad = scrollElement.querySelector<HTMLElement>('[data-testid="mobile-composer-reserve-pad"]');
       return {
         footerBottom: element.getBoundingClientRect().bottom,
         scrollBottom: scrollElement.getBoundingClientRect().bottom,
         dockTop: dockElement.getBoundingClientRect().top,
         dockHeight: dockElement.getBoundingClientRect().height,
-        reservePx: spacer ? spacer.getBoundingClientRect().height : Number.parseFloat(scrollStyle.paddingBottom),
+        reservePx: pad
+          ? Number.parseFloat(window.getComputedStyle(pad).paddingBottom)
+          : Number.parseFloat(scrollStyle.paddingBottom),
         reserve: scrollStyle.getPropertyValue("--mobile-composer-reserve").trim(),
         scrollTop: scrollElement.scrollTop,
         scrollHeight: scrollElement.scrollHeight,

From 15061964dd2fdf9665f72b7282f5cc81c736e57f Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 20:03:35 +0000
Subject: [PATCH 8/9] fix(ui): align phone detail shells with dock clearance
 contract

Give formulation/specifier pages the same max-sm:min-h-0 treatment as
service/form detail, simplify document-route ownership classification, and
lock the hidden-pad CSS token in merge-artifact guards.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 src/components/clinical-dashboard/mobile-composer-reserve.ts | 3 ++-
 src/components/formulation/formulation-ui.tsx                | 4 +++-
 src/components/specifiers/specifier-ui.tsx                   | 4 +++-
 tests/clinical-dashboard-merge-artifacts.test.ts             | 3 +++
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/components/clinical-dashboard/mobile-composer-reserve.ts b/src/components/clinical-dashboard/mobile-composer-reserve.ts
index 7c54629683..3d28f8ae18 100644
--- a/src/components/clinical-dashboard/mobile-composer-reserve.ts
+++ b/src/components/clinical-dashboard/mobile-composer-reserve.ts
@@ -35,8 +35,9 @@ export function resolveMobileComposerReserve(bottomComposerHidden: boolean, visi
 
 /** Document detail / source flows own a floating composer outside MasterSearchHeader. */
 export function isDocumentViewerOwnedRoute(pathname: string): boolean {
-  if (pathname.startsWith("/documents/source")) return true;
   if (!pathname.startsWith("/documents/")) return false;
+  // /documents/search is the shell-owned index; every other /documents/* route
+  // (detail, source, evidence) owns its floating composer in DocumentViewer.
   return pathname !== "/documents/search";
 }
 
diff --git a/src/components/formulation/formulation-ui.tsx b/src/components/formulation/formulation-ui.tsx
index 32b3ec3dc3..becae60a0b 100644
--- a/src/components/formulation/formulation-ui.tsx
+++ b/src/components/formulation/formulation-ui.tsx
@@ -11,7 +11,9 @@ export function FormulationPageShell({ children, className }: { children: ReactN
   return (
     <main
       className={cn(
-        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
+        // Phone shell owns dock clearance; avoid 100dvh min-height overflowing the
+        // inset scrollport the way service/form detail pages used to.
+        "max-sm:min-h-0 bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
         className,
       )}
     >
diff --git a/src/components/specifiers/specifier-ui.tsx b/src/components/specifiers/specifier-ui.tsx
index c0811a7758..b7ccfdd078 100644
--- a/src/components/specifiers/specifier-ui.tsx
+++ b/src/components/specifiers/specifier-ui.tsx
@@ -13,7 +13,9 @@ export function SpecifierPageShell({ children, className }: { children: ReactNod
   return (
     <main
       className={cn(
-        "min-h-[calc(100dvh-4rem)] bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
+        // Phone shell owns dock clearance; avoid 100dvh min-height overflowing the
+        // inset scrollport the way service/form detail pages used to.
+        "max-sm:min-h-0 bg-[color:var(--background)] px-3 py-4 pb-4 text-[color:var(--text)] sm:min-h-[calc(100dvh-4rem)] sm:px-5 sm:py-6 sm:pb-10 lg:px-7",
         className,
       )}
     >
diff --git a/tests/clinical-dashboard-merge-artifacts.test.ts b/tests/clinical-dashboard-merge-artifacts.test.ts
index ac2e0d4a9b..66e965fd11 100644
--- a/tests/clinical-dashboard-merge-artifacts.test.ts
+++ b/tests/clinical-dashboard-merge-artifacts.test.ts
@@ -166,8 +166,11 @@ describe("ClinicalDashboard merge-artifact guards", () => {
     expect(formDetailSource).not.toContain("pb-[calc(2rem+env(safe-area-inset-bottom))]");
     expect(formDetailSource).toContain("max-sm:min-h-0");
     expect(specifierUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
+    expect(specifierUiSource).toContain("max-sm:min-h-0");
     expect(formulationUiSource).not.toContain("pb-[calc(7rem+env(safe-area-inset-bottom))]");
+    expect(formulationUiSource).toContain("max-sm:min-h-0");
     expect(favouritesLibrarySource).not.toContain("pb-[calc(6rem+env(safe-area-inset-bottom))]");
+    expect(globalStylesSource).toContain("--phone-dock-hidden-pad: 0.75rem");
   });
 
   it("does not reintroduce the obsolete output-mode copy helper", () => {

From 04bb55900a0dae36552bd0e2d43c47f7f896fab8 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Sun, 19 Jul 2026 20:08:38 +0000
Subject: [PATCH 9/9] docs: record Safari edge-to-edge final review for PR #933

Append the branch-review ledger outcome for the phone dock reserve
closure so merge readiness is auditable.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
---
 docs/branch-review-ledger.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/branch-review-ledger.md b/docs/branch-review-ledger.md
index 8896a0d8c5..ca5aa86778 100644
--- a/docs/branch-review-ledger.md
+++ b/docs/branch-review-ledger.md
@@ -621,3 +621,4 @@ Use this ledger to prevent repeated branch and PR reviews when the reviewed HEAD
 | 2026-07-18 | claude/clinical-kb-pwa-review-asi3wb (PR #896, plan Phase 5; content commit + this ledger follow-up) | a6c2b4e92374e9002fb00c547eb5677d01ce538c | Design-polish sweep: audit-then-fix (plan Phase 5, final phase) | Audit on post-#890 main: three strict design guards clean; full re-run of the 07-token-adoption-audit grep method shows all July 3 debt resolved (M1–M3 done, L4 reduced to the deliberate theme-aware `ring-white/N dark:ring-white/10` glass idiom, L5/L7 gone; production hex all legitimate print/brand/console/comment classes); 43-capture live sweep across 15 routes × desktop/phone + 320px spots + dark/reduced-motion/forced-colors spots found 0 overflow and 0 console errors. Three defects found and fixed: (1) forced-colors solid-button labels rendered as blank Canvas-on-Canvas backplate boxes (axe-invisible) — command controls flattened to the native HCM ButtonFace/ButtonText pairing and accent glyph tokens flipped to ButtonText inside the existing forced-colors block, regression-locked by a new ui-accessibility test; (2) tools desktop 6-up quick-action rail truncated card titles at 1440×1000 — card metrics tightened, all six titles verified unclipped; (3) privacy page rendered "systemand" from a JSX newline-adjacent-to-tag drop — explicit space, locked by a privacy-ui assertion. Dated July 18 run appended to docs/redesign/07-token-adoption-audit.md (archived design-qa.md not resurrected). | Guards + focused vitest 14/14; `verify:cheap` chain green to the known container-only pdf-extraction-budget artifact (2806/2809); `verify:ui` 220 passed/2 failed (the two long-baselined container artifacts, hosted-CI-green through #826/#835/#872/#890); `test:e2e:accessibility` 8/8 incl. the new forced-colors token test; production build + client-bundle secret scan passed; `check:bundle-budget` within tolerance vs the Phase 4 ratchet (1290.6 vs 1278.6 KiB baseline); `verify:pr-local` runtime/format/lint/typecheck/build/rag-fixtures green with the same sole unit-suite artifact. `verify:release` not run (provider-backed; awaits explicit confirmation). No provider-backed checks run. |
 | 2026-07-19 | all remote feature branches and registered worktrees against `origin/main` through PR #899 | 8242fa63d5f5b79fc770c9ae4f633e3a784b80e1 | branch/worktree cleanup, useful-work recovery, and protected-main merge closure | Deleted 122 stale or closed remote feature refs with exact SHA leases; four additional merged PR branches were removed by the protected-main PR workflow. Removed 32 obsolete, superseded, or merge-proven worktree registrations. Recovered useful dirty RAG work into PR #901 (deterministic and opt-in semantic reranking) and PR #902 (retrieval phase latency telemetry), preserved follow-up decisions in `docs/process-hardening.md`, and recovered four missing historical review rows. PRs #897, #899, #901, and #902 are merged with green exact-head checks and zero unresolved review threads. A detached full-repo-review worktree is deliberately retained because its ownership/activity could not be safely disproved; one unregistered `node_modules` junction residue is also retained because deletion was denied by local safety policy. | Fresh fetch/prune; full GitHub PR/check/thread inventory; `git worktree list --porcelain`; cherry-pick-aware right-only logs; exact leased remote deletes; exact-old-value local ref deletes; clean-worktree, path, and merged-PR proof before every removal. PR #899 local proof: focused Vitest 31/31, changed-file ESLint, `verify:cheap` 317 files / 2,879 tests, and `verify:ui` 239/239; exact-head hosted checks all passed. PR #901 local proof: `verify:cheap` 316 files / 2,870 tests; PR #902 focused Vitest 8/8 plus ESLint and typecheck. No OpenAI, Supabase, live clinical, deployment, or production-data workflow ran; provider-backed semantic canary evaluation remains approval-gated. |
 | 2026-07-19 | main / `codex/supabase-database-review` | 4034d2e60ebb6616130ff17bf3cb69368f36f8f6 + reviewed working diff | live `Clinical KB Database` security, migration, schema-drift, integrity, and performance review against current repo | Confirmed and remediated a P1 privacy defect: 601 private-document title-vocabulary rows were reachable by the service-role query corrector; the live public-only sync/backfill now reports zero private or out-of-scope rows. Applied the committed retrieval-count bound, audit-metadata minimization, registry cleanup/index, public-title corrector, and atomic summary-rate-limit migrations. The missing FK and registry indexes are present and no invalid indexes remain. A second P1 was found in the untracked live `ingestion-worker`: gateway JWT verification accepted any project JWT before privileged direct-Postgres job processing. Recovered the deployed source into the repo, restricted it to POST plus a gateway-verified `service_role` claim, expanded the Deno checker to every tracked Edge Function, and deployed exact-matching v13 with JWT verification enabled. Review also exposed a repo mirror/test gap: the count-clamp migration was not reflected in `schema.sql`; the branch now mirrors it and locks both sources in the focused test. Remaining hosted blocker: `postgres` cannot assume managed `supabase_admin`, so the fail-closed default-ACL migrations and final title-word constraint/trigger migration remain unapplied; the intentional service-role-only table still produces one INFO no-policy advisor. | Supabase connector project identity, migration and Edge Function inventory, full drift snapshot comparison, security/performance advisors, catalog integrity/ACL/index queries, Vault JWT-role compatibility check, post-apply invariants, exact deployed-source hashes, and unauthenticated live rejection (401); focused retrieval/schema/drift Vitest 82/83 with only manifest freshness failing; Edge/retrieval auth 9/9; Deno check for both functions; offline RAG 36 cases / 294 tests; function-grant guard; scoped ESLint, Prettier, and `git diff --check`. `check:supabase-project` was attempted but stopped before provider contact because local project env vars are unset. `drift:manifest` was blocked because Docker Desktop could not start and was cleaned up. `verify:cheap`, `verify:pr-local`, production-readiness, OpenAI, hosted CI, broader deployment, and commit/push were not run. |
+| 2026-07-19 | cursor/safari-edge-to-edge-f46b (PR #933) | 15061964dd2fdf9665f72b7282f5cc81c736e57f | final Safari edge-to-edge / phone dock reserve review + merge readiness | No high-confidence P0-P1. Confirmed implementation: shared reserve module collapses to 0.75rem when dock hides; shell uses block scrollport + inner mobile-composer-reserve-pad so clearance contributes to scrollHeight; child dock-sized env(safe-area) pads removed; DocumentViewer owns its dock pad. Review polish: formulation/specifier max-sm:min-h-0 alignment, document-route ownership simplification, hidden-pad CSS token guard. Residual P2/P3 only: differentials compare zero-inset backdrop margin, idle 2rem vs max(2rem,safe-area) ~2px, unused-looking #main-content padding transition still needed by ClinicalDashboard. Merge-ready. | Local: format/lint/typecheck/knip/budgets pass; unit 2952 passed with only pre-existing pdf-extraction-budget (python ENOENT, also fails on clean main); production build + client-bundle secret scan pass; focused Chromium composer suite 6/6 (forms hide, tablet/desktop clearance, differentials compare, service-detail endpoint, document-viewer hide, long-answer dock). Hosted CI on prior head fully green including Production UI; polish head re-checked before merge. No OpenAI/live Supabase/provider calls. |