Skip to content

fix: confirm invoice missing params - #320

Merged
cameri merged 1 commit into
mainfrom
319-unable-to-confirm-invoice
May 25, 2023
Merged

fix: confirm invoice missing params#320
cameri merged 1 commit into
mainfrom
319-unable-to-confirm-invoice

Conversation

@cameri

@camericameri commented May 25, 2023•
edited
Loading

Copy link
Copy Markdown
Owner

Description

  1. Confirming invoice no longer fails because of missing data

Related Issue

#319

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@camericameri linked an issue May 25, 2023 that may be closed by this pull request
Unable to confirm invoice #319
Closed
@camericameri changed the title fix: confirm invoice confirmedAt is undefinedfix: confirm invoice missing paramsMay 25, 2023
@camericameri self-assigned this May 25, 2023
@camericameri added the bug Something isn't working label May 25, 2023
@cameri
cameri merged commit e0e3a11 into mainMay 25, 2023
@cameri
cameri deleted the 319-unable-to-confirm-invoice branch May 25, 2023 13:29
@sonarqubecloud

sonarqubecloudBot commented May 25, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

0.0%0.0% Coverage
0.0%0.0% Duplication

github-actionsBot pushed a commit that referenced this pull request May 25, 2023
@semantic-release-bot
chore(release): 1.25.2 [skip ci]
a63c035
## [1.25.2](v1.25.1...v1.25.2) (2023-05-25)
### Bug Fixes
* confirm invoice confirmedAt is undefined ([#320](#320)) ([e0e3a11](e0e3a11))
@github-actions

github-actionsBot commented May 25, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.25.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@camericameri

Labels

bugSomething isn't workingreleased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to confirm invoice

1 participant

@cameri