From cf2b50f4121d51003431951f50214b393e1668f3 Mon Sep 17 00:00:00 2001 From: jdev082 Date: Sat, 11 May 2024 13:51:49 -0500 Subject: [PATCH 1/4] feat(tabs): middle click tab muting + indicator Signed-off-by: jdev082 --- src/tabs.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/tabs.js b/src/tabs.js index a1c4563c..582fb9d9 100644 --- a/src/tabs.js +++ b/src/tabs.js @@ -17,6 +17,7 @@ async function createTab(url) { ).agent; let tab = document.createElement('div'); let span = document.createElement('span'); + let mute = document.createElement('span') // Some parts taken from MystPi/Ninetails on Github. Thank you so much!!! let randomHash = generateHashkey(); tab.classList.add('tab'); @@ -25,7 +26,15 @@ async function createTab(url) { switchTabs(randomHash); }; span.innerText = 'New Tab'; + mute.classList.add("material-symbols-rounded") + mute.innerText = 'volume_off' + mute.classList.add('hidden') let view = document.createElement('webview'); + tab.onauxclick = () => { + view.setAudioMuted(!view.audioMuted) + console.log(tab) + tab.children[2].classList.toggle("hidden") + } view.id = 'view-' + randomHash; view.classList.add('view'); view.allowpopups = 'allowpopups'; @@ -41,6 +50,7 @@ async function createTab(url) { document.getElementById('tabs-bar').appendChild(tab); tab.appendChild(image); tab.appendChild(span); + tab.appendChild(mute) addListeners(view, randomHash); document.getElementById('webviews').appendChild(view); switchTabs(randomHash); From 21f218bc9a5f908e786c1cf9cddbbfb704a92f9e Mon Sep 17 00:00:00 2001 From: jdev082 Date: Sat, 11 May 2024 13:55:07 -0500 Subject: [PATCH 2/4] fix(styles): adjust tab padding and font size for indicator Signed-off-by: jdev082 --- styles.css | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/styles.css b/styles.css index d6938ce4..ea1ebb95 100644 --- a/styles.css +++ b/styles.css @@ -40,6 +40,11 @@ body { border-radius: 0.5rem; cursor: pointer; white-space: nowrap; + padding: 4pt; +} + +.tab span { + font-size: 12pt; } .active-tab { From 1a86046e57fffb58990292163a847471ac1ee0e4 Mon Sep 17 00:00:00 2001 From: jdev082 Date: Sat, 11 May 2024 14:01:10 -0500 Subject: [PATCH 3/4] fix(styles): adjust positioning of elements within tabs for indicator Signed-off-by: jdev082 --- src/tabs.js | 1 + styles.css | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/tabs.js b/src/tabs.js index 582fb9d9..bba3ae1e 100644 --- a/src/tabs.js +++ b/src/tabs.js @@ -29,6 +29,7 @@ async function createTab(url) { mute.classList.add("material-symbols-rounded") mute.innerText = 'volume_off' mute.classList.add('hidden') + mute.classList.add('indicator') let view = document.createElement('webview'); tab.onauxclick = () => { view.setAudioMuted(!view.audioMuted) diff --git a/styles.css b/styles.css index ea1ebb95..cd0d47d6 100644 --- a/styles.css +++ b/styles.css @@ -27,9 +27,6 @@ body { .tab { transition: all; - display: flex; - justify-content: center; - align-items: center; flex-grow: 1; max-width: 32rem; padding: 0.25rem 0.5rem; @@ -47,6 +44,13 @@ body { font-size: 12pt; } +.tab .indicator { + position: relative; + float: right; + font-weight: bold; + font-size: 1.3em; +} + .active-tab { background-color: var(--tertiary); } From cae3b2bf06f4528154f2b341b27457d746ca000d Mon Sep 17 00:00:00 2001 From: jdev082 Date: Sat, 11 May 2024 14:02:01 -0500 Subject: [PATCH 4/4] fix: remove debug logging Signed-off-by: jdev082 --- src/tabs.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/tabs.js b/src/tabs.js index bba3ae1e..d2f1165c 100644 --- a/src/tabs.js +++ b/src/tabs.js @@ -33,7 +33,6 @@ async function createTab(url) { let view = document.createElement('webview'); tab.onauxclick = () => { view.setAudioMuted(!view.audioMuted) - console.log(tab) tab.children[2].classList.toggle("hidden") } view.id = 'view-' + randomHash;