From d41719c5ace4f55b92fdbc20531775abde0e258f Mon Sep 17 00:00:00 2001
From: Florent Tapponnier <florent.tapponnier@gmail.com>
Date: Thu, 4 Jun 2026 23:02:06 +0200
Subject: [PATCH] fix(bench): Best/Worst headline respects higher_is_better

For benches like HL frontends (higher_is_better=true, fees in USD), Best is the max value not the min, and Worst is the min not the max. Latency benches keep the original min=Best mapping. Fixes BEST=$0 / WORST=$24K on staging HL frontends page where the leaders (phantom-perps $119K, metamask $66K) were being mapped to Worst.
---
 src/app/alternatives/[slug]/page.tsx |  4 +-
 src/components/benchmark-body.tsx    | 58 ++++++++++++++++------------
 2 files changed, 35 insertions(+), 27 deletions(-)

diff --git a/src/app/alternatives/[slug]/page.tsx b/src/app/alternatives/[slug]/page.tsx
index 1488a209..e95babd9 100644
--- a/src/app/alternatives/[slug]/page.tsx
+++ b/src/app/alternatives/[slug]/page.tsx
@@ -250,7 +250,7 @@ export default async function AlternativePage({
           <dl className="mt-10 grid grid-cols-2 sm:flex sm:flex-wrap items-baseline gap-x-8 gap-y-3 border-y border-rule py-4">
             <SummaryStat
               label="Best"
-              value={`${fmtValue(fieldMin, bench.unit)}${unitSuffix(bench.unit)}`}
+              value={`${fmtValue(bench.higherIsBetter ? fieldMax : fieldMin, bench.unit)}${unitSuffix(bench.unit)}`}
             />
             <SummaryStat
               label="Median"
@@ -258,7 +258,7 @@ export default async function AlternativePage({
             />
             <SummaryStat
               label="Worst"
-              value={`${fmtValue(fieldMax, bench.unit)}${unitSuffix(bench.unit)}`}
+              value={`${fmtValue(bench.higherIsBetter ? fieldMin : fieldMax, bench.unit)}${unitSuffix(bench.unit)}`}
             />
             <SummaryStat
               label="Spread"
diff --git a/src/components/benchmark-body.tsx b/src/components/benchmark-body.tsx
index 40c7874a..0f38c8f8 100644
--- a/src/components/benchmark-body.tsx
+++ b/src/components/benchmark-body.tsx
@@ -359,31 +359,39 @@ export function BenchmarkBody({
         </div>
       )}
 
-      {!isDraft && benchmark.unit !== "count" && (
-        <dl className="mt-10 card rounded-xl grid grid-cols-2 sm:flex sm:flex-wrap divide-y divide-x sm:divide-y-0 divide-rule overflow-hidden">
-          <SummaryStat
-            label="Best"
-            value={`${fmtValue(fieldMin, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
-          />
-          <SummaryStat
-            label="Median"
-            value={`${fmtValue(fieldMedian, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
-          />
-          <SummaryStat
-            label="Worst"
-            value={`${fmtValue(fieldMax, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
-          />
-          <SummaryStat
-            label="Spread"
-            value={tailSpread > 0 ? `${tailSpread.toFixed(1)}×` : "-"}
-            hint={
-              tailSpread > 0
-                ? `${fmtUnit(tailMin, benchmark.unit)} → ${fmtUnit(tailMax, benchmark.unit)}`
-                : undefined
-            }
-          />
-        </dl>
-      )}
+      {!isDraft && benchmark.unit !== "count" && (() => {
+        // For higher-is-better benches (e.g. HL frontends USD revenue), the
+        // "best" headline is the max value, not the min. Latency benches keep
+        // the original min=best mapping.
+        const higherIsBetter = benchmark.higherIsBetter === true;
+        const bestValue = higherIsBetter ? fieldMax : fieldMin;
+        const worstValue = higherIsBetter ? fieldMin : fieldMax;
+        return (
+          <dl className="mt-10 card rounded-xl grid grid-cols-2 sm:flex sm:flex-wrap divide-y divide-x sm:divide-y-0 divide-rule overflow-hidden">
+            <SummaryStat
+              label="Best"
+              value={`${fmtValue(bestValue, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
+            />
+            <SummaryStat
+              label="Median"
+              value={`${fmtValue(fieldMedian, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
+            />
+            <SummaryStat
+              label="Worst"
+              value={`${fmtValue(worstValue, benchmark.unit)}${unitSuffix(benchmark.unit)}`}
+            />
+            <SummaryStat
+              label="Spread"
+              value={tailSpread > 0 ? `${tailSpread.toFixed(1)}×` : "-"}
+              hint={
+                tailSpread > 0
+                  ? `${fmtUnit(tailMin, benchmark.unit)} → ${fmtUnit(tailMax, benchmark.unit)}`
+                  : undefined
+              }
+            />
+          </dl>
+        );
+      })()}
 
       {!isDraft && (
         <>