From 3f8f3d5b1aa6d294187a48256b036b2b4ee94148 Mon Sep 17 00:00:00 2001 From: Dean Brettle Date: Mon, 27 May 2024 18:17:12 -0700 Subject: [PATCH 1/2] Add CODEOWNERS so the merging to master must be approved by a reviewer. --- .github/CODEOWNERS | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..e7015ac --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,7 @@ +# All PRs need to be approved by a member of the reviewers team +# Note that for this to work, the repository's access settings (https://github.com/DeepBlueRobotics/RobotCode2024/settings/access) +# need to be configured to allow the reviewers team (or a parent team like devs) to explicitly have write (or higher) access. +# It isn't sufficient for all org members to have write access. +# Also, the branch protection rules (https://github.com/DeepBlueRobotics/RobotCode2024/settings/branches) +# for the master branch need to have "Require review from Code Owners" enabled. +* @DeepBlueRobotics/reviewers From b914017ab470a9a2a2c6ae987d48e09151cc71d3 Mon Sep 17 00:00:00 2001 From: Dean Brettle Date: Mon, 27 May 2024 18:34:47 -0700 Subject: [PATCH 2/2] Make links to repository settings generic. --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e7015ac..52d67bf 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,7 +1,7 @@ # All PRs need to be approved by a member of the reviewers team -# Note that for this to work, the repository's access settings (https://github.com/DeepBlueRobotics/RobotCode2024/settings/access) +# Note that for this to work, the repository's access settings (https://github.com/DeepBlueRobotics//settings/access) # need to be configured to allow the reviewers team (or a parent team like devs) to explicitly have write (or higher) access. # It isn't sufficient for all org members to have write access. -# Also, the branch protection rules (https://github.com/DeepBlueRobotics/RobotCode2024/settings/branches) +# Also, the branch protection rules (https://github.com/DeepBlueRobotics//settings/branches) # for the master branch need to have "Require review from Code Owners" enabled. * @DeepBlueRobotics/reviewers