Adding UDF Resources to Queries by dwmclary · Pull Request #2015 · googleapis/google-cloud-python

dwmclary · 2016-07-22T18:45:04Z

The BigQuery client doesn't currently support adding UDF resources. This pull request adds a UDFResources object, and properties to set these resources on queries and QueryJobs.

googlebot · 2016-07-22T18:45:07Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

dwmclary · 2016-07-22T18:45:29Z

I signed it!
I'm a Googler.

tseaver · 2016-07-22T19:57:42Z

See #2007 for an alternative.

googlebot · 2016-07-22T23:18:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

dwmclary · 2016-07-22T23:21:30Z

All commits were authored by me. I had a different email set as primary when the initial commit was made.

daspecster · 2016-07-23T03:13:46Z

I'm not entirely sure how that not works but you might have to rebase and
change the user on those commits.

On Friday, July 22, 2016, Daniel McClary notifications@github.com wrote:

All commits were authored by me. I had a different email set as primary
when the initial commit was made.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2015 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALvyElSGhqFqGtucoId7um9jqo9fiHlks5qYVB7gaJpZM4JTBqe
.

Tom Schultz

googlebot · 2016-07-23T06:06:18Z

CLAs look good, thanks!

dwmclary · 2016-07-23T06:08:04Z

OK rebased to reflect the proper author email.

Sign in to view

+ if not self._udf_resources:
+ return []
+ if not all(isinstance(u, UDFResource) for u in self._udf_resources):
+ raise ValueError("udf items must be UDFResource")


tseaver · 2016-07-26T15:51:03Z

@dwmclary Thanks for the patch!

googlebot · 2016-07-26T17:14:50Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

tseaver · 2016-07-26T18:44:40Z

@dwmclary It appears that Github / the CLA bot do not think 1ff3252 was authored by you, but by another blind poet of the same name.

Testing deploy with 1:1 class:json. Add overview.html Deploy script working now in testing. Fix code blocks. Add href support. Add snippets to base service module. closes#1951 Fix types generation. Fix linking. Fix external github links. Update gcloud-commit site files. Swtich to live site generation. clean up manifest for starters. Remove old example detection code. Update TOC.

googlebot · 2016-07-26T19:48:45Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

dwmclary · 2016-07-26T19:50:33Z

Authored by me, and now painfully rebased to reflect it.

dwmclary · 2016-07-26T20:15:33Z

OK, should be all fixed as soon as CLAbot looks at the authorship again.

dwmclary · 2016-07-26T21:55:16Z

@googlebot can you check the CLA again?

I need to get better at whitespace.

…d-python

dwmclary · 2016-07-27T04:20:31Z

@tseaver @daspecster Any idea why the CLA isn't flipping? At this point all commits and author emails should point to me. There doesn't appear to be any rebase magic I can perform beyond this. Worst-case, I can re-fork and resubmit if we can't make @googlebot behave.

dwmclary · 2016-07-27T05:10:24Z

Re-opened here

…xReplaceStrOp and ReplaceStrOp compilers (#2015)

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 22, 2016

dhermes added the api: bigquery Issues related to the BigQuery API. label Jul 22, 2016

tseaver mentioned this pull request Jul 22, 2016
Add BigQuery UDF support #2007
Closed

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 23, 2016

tseaver reviewed Jul 26, 2016
View reviewed changes

Comment threadgcloud/bigquery/job.py Outdated
if not self._udf_resources:
return []
if not all(isinstance(u, UDFResource) for u in self._udf_resources):
raise ValueError("udf items must be UDFResource")
This comment was marked as spam.
Sign in to view

tseaver added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 26, 2016

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 26, 2016

dwmclary added 6 commits July 26, 2016 12:44

started addding udf resources
22186d1

added UDFResources to query
bdeac5c

lint and systemtests pass
5ad14a2

all tests pass
dafe007

final lint before pr
e2a0805

updated lint warnings
c4ee959

daspecsterand others added 13 commits July 26, 2016 12:47

First pass at Python doc generator...(originally JJ's commit)
4a4941c

Update site and fix typos.
bc584bf

Add RST snippet captions.
11e897f

Remove old gh-pages doc build script.
fbd411b

Switch to using tox for calling json docs update script.
a6b2751

Add Sphinx as a dependency for linting.
35678f6

Exclude verify_included_modules.py from lint.
6ee3826

Add Error Reporting Client
b9f8a2f

Update gcloud references.
6aa1c57

response to code review, better tests, no backslashes
897f8c0

started addding udf resources
1b29095

coverage fixed
79b38e5

dwmclary added 7 commits July 26, 2016 15:44

fixed linter error, again
e239baa
I need to get better at whitespace.

re-fixed broken tests
95ad07a

Merge branch 'master' ofhttps://github.com/GoogleCloudPlatform/gclou…
caed23a
…d-python

fixed author address
6fc3322

Merge branch 'master' into fix_author_address
a105efc

fixed classname in docstring
d9a3b2c

fixed tox.ini to include ordereddict ro dep for py26
9725f3b

dwmclary added a commit to dwmclary/gcloud-python that referenced this pull request Jul 27, 2016
refork and fix ofgoogleapis#2015
c8ba881

dwmclary mentioned this pull request Jul 27, 2016
refork and fix of #2015 (UDF Support) #2029
Merged

dwmclary closed this Jul 27, 2016

parthea pushed a commit that referenced this pull request Apr 1, 2026
chore: implement StrPadOp, StrFindOp, StrExtractOp, StrRepeatOp, Rege…
4e285d1
…xReplaceStrOp and ReplaceStrOp compilers (#2015)

Uh oh!

Conversation

dwmclary commented Jul 22, 2016

Uh oh!

googlebot commented Jul 22, 2016

Uh oh!

dwmclary commented Jul 22, 2016• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tseaver commented Jul 22, 2016

Uh oh!

googlebot commented Jul 22, 2016

Uh oh!

dwmclary commented Jul 22, 2016

Uh oh!

daspecster commented Jul 23, 2016

Uh oh!

googlebot commented Jul 23, 2016

Uh oh!

dwmclary commented Jul 23, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Jul 26, 2016

Uh oh!

googlebot commented Jul 26, 2016

Uh oh!

tseaver commented Jul 26, 2016

Uh oh!

googlebot commented Jul 26, 2016

Uh oh!

dwmclary commented Jul 26, 2016

Uh oh!

dwmclary commented Jul 26, 2016

Uh oh!

dwmclary commented Jul 26, 2016

Uh oh!

dwmclary commented Jul 27, 2016

Uh oh!

dwmclary commented Jul 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dwmclary commented Jul 22, 2016•
edited
Loading