Skip to content

spanner: Expand test coverage for ResultSets - #3717

Merged
chingor13 merged 4 commits into
googleapis:masterfrom
nithinsujir:rscovg
Oct 9, 2018
Merged

spanner: Expand test coverage for ResultSets#3717
chingor13 merged 4 commits into
googleapis:masterfrom
nithinsujir:rscovg

Conversation

@nithinsujir

@nithinsujirnithinsujir commented Sep 21, 2018

Copy link
Copy Markdown

ResultSets coverage now at 99%.

@nsujir
spanner: Expand test coverage for ResultSets
ff9ffc9
ResultSets coverage now at 99%.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2018
@nithinsujirnithinsujir changed the title WIP: spanner: Expand test coverage for ResultSetsspanner: Expand test coverage for ResultSetsSep 21, 2018
snehashah16
snehashah16 reviewed Sep 21, 2018
View reviewed changes
Comment thread...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java

try {
rs.getStats();
fail("Exception expected");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java Outdated
public void resultSetIteration() {
double dval = 1.2;
String s = "s";
String byt = "101";

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
@@ -34,11 +41,51 @@ public class ResultSetsTest {

@Test
public void resultSetIteration() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

snehashah16
snehashah16 approved these changes Sep 26, 2018
View reviewed changes

@snehashah16snehashah16 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please hold off on submitting this until DML PR is out.

Comment thread...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java
@@ -34,11 +41,51 @@ public class ResultSetsTest {

@Test
public void resultSetIteration() {

This comment was marked as spam.

Sign in to view

Comment thread...loud-clients/google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResultSetsTest.java

try {
rs.getStats();
fail("Exception expected");

This comment was marked as spam.

Sign in to view

@nithinsujirnithinsujir changed the title spanner: Expand test coverage for ResultSetsWIP: spanner: Expand test coverage for ResultSetsSep 26, 2018
@nithinsujir

nithinsujir commented Sep 26, 2018

Copy link
Copy Markdown
Author

Marking this WIP until DML changes are in.

@nithinsujirnithinsujir changed the title WIP: spanner: Expand test coverage for ResultSetsspanner: Expand test coverage for ResultSetsOct 2, 2018
@nithinsujir

nithinsujir commented Oct 2, 2018

Copy link
Copy Markdown
Author

@pongad Merged DML changes. Turns out there is no impact because the getStats() that DML changed is in a different class than the one in this test.

This PR is ready to go.

@pongad

pongad commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

We're transitioning ownership of this repo and I don't have write access anymore. @chingor13@JesseLovelace can you help?

@chingor13

chingor13 commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Does this need to go out with the spanner DML feature or can it wait until after the release is completed?

@nithinsujir

nithinsujir commented Oct 2, 2018 via email

Copy link
Copy Markdown
Author

@chingor13

chingor13 commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

SGTM

@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@chingor13chingor13 self-assigned this Oct 2, 2018
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2018
@chingor13chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2018
@chingor13
chingor13 merged commit a5628af into googleapis:masterOct 9, 2018
This was referenced Oct 10, 2018
Closed
Closed
Merged
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
deps: update netty.version to v4.1.119.final (#3717)
08a290a
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@renovate-bot
deps: update netty.version to v4.1.119.final (#3717)
d7a5f5e
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 6.90.1-SNAPSHOT (#3717)
04bf5e9
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongadpongadAwaiting requested review from pongad
1 more reviewer
@snehashah16snehashah16snehashah16 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@chingor13chingor13

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nithinsujir@pongad@chingor13@snehashah16@googlebot@kokoro-team@nsujir