Uh oh!
There was an error while loading. Please reload this page.
Add initial integration test for BigQuery Storage API. - #5216
Merged
Conversation
Integration tests in this change cover: - simple/non-filtered read from a table - filtered read from a table - read that only selects certain columns In addition to adding integration tests, this change also includes the Kokoro setup for presubmit, nighthly and continuous builds.
chingor13
requested review from
chingor13 and tswast
and removed request for
a teamMay 23, 2019 20:19
chingor13
approved these changes
May 23, 2019
chingor13
left a comment
Contributor
There was a problem hiding this comment.
Kokoro config LGTM. And it passed first time!
Codecov Report
@@ Coverage Diff @@## master #5216 +/- ##
=========================================
Coverage 50.41% 50.41% - Complexity 23796 23811 +15
=========================================
Files 2251 2251 Lines 226836 226836 Branches 24966 24961 -5 =========================================
Hits 114370 114370 Misses 103858 103858 Partials 8608 8608Continue to review full report at Codecov.
|
tswast
approved these changes
May 23, 2019
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests in this change cover:
In addition to adding integration tests, this change also includes the Kokoro setup for presubmit, nighthly and continuous builds.
In upcoming PRs for integration tests, other aspects of the BigQuery Storage API will be covered.
@tswast, please review the newly added tests.
@chingor13 , please review the Kokoro setup.
CC: @shollyman , @kmjung , @aryann