Firestore: Fix FieldValue.arrayUnion() accept POJO.

[pmakani]

Fixes#5622

[BenWhitehead]

This looks like it's okay to me. What do you think @schmidt-sebastian?

[schmidt-sebastian]

Thanks for this! I left some feedback if you want to take this PR for another spin.

[schmidt-sebastian]

Can you make the same change for ArrayRemoveFieldValue?

[schmidt-sebastian]

Would it be possible to just use

google-cloud-java/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java

Line 124 in 2b28ae1

publicstaticclassSingleField {

or

google-cloud-java/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java

Line 143 in 2b28ae1

publicstaticclassNestedClass {

?

If not, can you move this class to LocalFirestoreHelper?

[schmidt-sebastian]

I know it would be a lot more code, but to me this test would be more valuable if it verified the generated proto.

[codecov]

Codecov Report

Merging #5750 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #5750 +/- ##
===========================================
- Coverage 47.09% 46.79% -0.3% - Complexity 25079 25648 +569 
===========================================
Files 2389 2456 +67 Lines 259750 267615 +7865 Branches 29400 30563 +1163 ===========================================
+ Hits 122328 125243 +2915 - Misses 128459 133113 +4654 - Partials 8963 9259 +296

Impacted Files	Coverage Δ	Complexity Δ
...in/java/com/google/cloud/firestore/FieldValue.java	79.77% <100%> (+0.46%)	8 <0> (ø)	⬇️
.../cloud/compute/v1/InsertTargetPoolHttpRequest.java	22.08% <0%> (-1.85%)	8% <0%> (-1%)
...c/main/java/com/google/cloud/logging/SinkInfo.java	82.03% <0%> (-1.78%)	19% <0%> (-2%)
...n/java/com/google/cloud/compute/v1/Commitment.java	34.68% <0%> (-1.77%)	21% <0%> (+1%)
...m/google/cloud/compute/v1/stub/RegionDiskStub.java	8.33% <0%> (-1.67%)	1% <0%> (ø)
...om/google/cloud/compute/v1/RegionDiskSettings.java	16.66% <0%> (-1.52%)	3% <0%> (ø)
...java/com/google/cloud/compute/v1/DiskSettings.java	14.81% <0%> (-1.19%)	3% <0%> (ø)
...ava/com/google/cloud/compute/v1/stub/DiskStub.java	6.25% <0%> (-0.9%)	1% <0%> (ø)
...java/com/google/cloud/compute/v1/NodeTemplate.java	35.53% <0%> (-0.89%)	20% <0%> (+1%)
...n/java/com/google/cloud/compute/v1/DiskClient.java	55.71% <0%> (-0.88%)	55% <0%> (+8%)
... and 584 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d284774...0570f24. Read the comment docs.

[pmakani]

@schmidt-sebastian PTAL

[schmidt-sebastian]

@pmakani Thank you for addressing my feedback! This basically looks good, but I would like to tweak the tests slightly to better match the existing format. While you are essentially asserting the same things, we have been comparing the final CommitRequest rather than the outout from the toProto() calls.

Do you mind applying this patch to your PR: https://gist.github.com/schmidt-sebastian/08b8cf9956a33989a8eedaad4533d25d

We are then good to go! Thank you for your contribution.

[BenWhitehead]

@pmakani Thanks for the contribution!