Uh oh!
There was an error while loading. Please reload this page.
Firestore: add emulator support - #5924
Conversation
Codecov Report
@@ Coverage Diff @@## master #5924 +/- ##
=========================================
Coverage ? 46.12% Complexity ? 24189 =========================================
Files ? 2456 Lines ? 262273 Branches ? 29603 =========================================
Hits ? 120965 Misses ? 132196 Partials ? 9112
Continue to review full report at Codecov.
|
schmidt-sebastian
left a comment
There was a problem hiding this comment.
This basically looks good, but I think it is missing the port assignment (if the port is provided).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BenWhitehead
left a comment
There was a problem hiding this comment.
According to the bug linked, admin operations should succeed but I'm seeing a number of tests from com.google.cloud.firestore.it.ITSystemTest fail with com.google.cloud.firestore.FirestoreException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: Metadata operations require admin authentication
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thebrianchen
left a comment
There was a problem hiding this comment.
Resolved comments. Are we standardizing all SDKs to use FIRESTORE_EMULATOR_HOST, or is it ok for individual SDKs to come up with their own names?
@schmidt-sebastian
Uh oh!
There was an error while loading. Please reload this page.
| + FIRESTORE_EMULATOR_SYSTEM_PROPERTY | ||
| + " is not a valid host", | ||
| e); | ||
| } |
There was a problem hiding this comment.
can we extract this into a helper method validateUrl?
There was a problem hiding this comment.
We're not using this anywhere else, and the error code is pretty specific in that it's checking for the host.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hi all I can not find a working solution for my project GAE / spring boot Can you help me ? The CURL is OK (http 200) google-cloud-core-grpc-1.90.0 |
schmidt-sebastian
commented
Sep 9, 2019
You need to provide the It's usually best to open a GitHub issue for questions like these since it is pretty easy to miss a comment on a merged GitHub PR :) |
Context b/134525351