Skip to content

spanner-jdbc: Add jdbc statement integration tests - #6033

Merged
kolea2 merged 4 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-cleanup-it-jdbc-statements
Aug 19, 2019
Merged

spanner-jdbc: Add jdbc statement integration tests#6033
kolea2 merged 4 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-cleanup-it-jdbc-statements

Conversation

@olavloite

@olavloiteolavloite commented Aug 6, 2019

Copy link
Copy Markdown
Contributor

Adds integration tests for JDBC statements and prepared statements.

@olavloite
olavloite requested a review from kolea2August 6, 2019 14:06
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2019
@codecov

codecovBot commented Aug 6, 2019•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #6033 into master will decrease coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6033 +/- ##
============================================
- Coverage 47.37% 46.72% -0.66% + Complexity 27111 25649 -1462 
============================================
Files 2516 2516 Lines 273718 268318 -5400 Branches 31353 30340 -1013 ============================================
- Hits 129670 125365 -4305 + Misses 134440 133492 -948 + Partials 9608 9461 -147
Impacted FilesCoverage ΔComplexity Δ
...in/java/com/google/cloud/storage/StorageBatch.java88% <0%> (-4%)13% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java63.41% <0%> (-2.5%)12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
...cloud/texttospeech/v1beta1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
... and 667 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d3438...59d2da3. Read the comment docs.

kolea2
kolea2 suggested changes Aug 7, 2019
View reviewed changes
Comment thread...ib/google-cloud-spanner-jdbc/src/test/resources/com/google/cloud/spanner/jdbc/it/Singers.txt Outdated
@@ -0,0 +1,30 @@
(1,'Marilyn','Lindsey',FROM_BASE64('iVBORw0KGgoAAAANSUhEUgAAAgAAAAIACAIAAAB7GkOtAAANGklEQVR4nOzXi6/X9X3H8R56RO222IsXqqgwGROYWuf9wnDipV7B0GmxYzWr9bKNqDGatraltop2ird1hTXrqvbMiChiylA7mCtQK4aySkstRiyFrLZQy5DCWaMz+yteSZPX4/EHvD4n3/NLnnkPzlg//l1JC68bjO6fc+LXo/sv3XhXdH/M7tXR/S0fGBndf23ei9H9WzYfG91fdtoHo/uzn70pun/YtrOi+zMvzv79x6xeHt1/e8yz0f1fjNoW3X9qbvb7jIiuA/A7SwAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBo89IZzow8c/uab0f1Hj389uv/YCxuj+19d/Ep0f9GmO6L7P7p/Q3T/H8/5fnT/rzbvju6/svaK6P45i7L/349svSq6v9+Ri6P7ixf9KLr/1BV/G90/deeHo/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MAXdv44+sAXb18S3R+/eUJ0f++3hqP7p/7LtdH9bWsejO5/dvry6P4Hr50b3Z8/fFp0/4Sxfx/d3/ejg9H9vca9Gt0fumQgur/0kDOj+7fd8rXo/tCMA6L7LgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoNTA8J3viz4wb/jM6P49P/+z6P53Zh8U3b/wgInR/aVbr4vuL1h4VnR/979Pi+6f8A8jo/t//OU3ovuzj748uv/cnuHo/thRv4ru3zr4y+j+GeMWR/c3nj09uu8CACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKDUwb92r0gSMnvxzdv3HTr6L7w19ZG91f++Svo/tDrx0f3X9mzvnR/Ykj50T3779p/+j+fld/Lrq/7LHXo/u/XXJRdP+PDs3+frbPuiq7//D10f3hUUPRfRcAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBq4Mb5y6IPfOzRb0X37xtxcXT/ic+cF92fsG1udP+6vZ+J7u9/+3ej+2cNHhTdX/bC1dH9rZeNju7PWnBudP/e/f8yun/UZ98T3b9s6r3R/XXT/y26/7MfZ7+PCwCglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKDVwyikHRh94acTj0f2jxx4f3f/QHVOi+zdcNia6/9Bh86L76w+/Jrp/0p/Pie7ftm6f6P4++x4b3b977XHR/SOvHR3dX7Thruj+C4+/Ed1ftfTV6P4d962L7rsAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSgx/65rnRB6ZufX90/80Fo6P739t+W3T/lx9fE93f8r1jo/vXzLg0uv/l3x4Q3V85+/ei+1ePXh3d/+uT/iS6P/jt46L766bMie6PfuCJ6P7ctWOi+5PXHBbddwEAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUGp37jzOgDF957V3T/5JP/Nbr/yFFD0f3fv/y86P75v1kd3Z+/18jo/uOPZH+fIzZE5991+pVfiO6fd8Z90f1XDrwjuv8/L78e3X962uLo/srJ46P7q3feE913AQCUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQY+v/a16APTnvxJdP+4H8yP7p+4ZEp0f9JvtkT35x9+TXR/yxNfiu7PPGhPdP8Dc3ZF9zePfya6P+v590T3d2zYHd1/aN7l0f0Jkz4Z3Z9087js/qQro/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MCZtxwYfeCIz30lur9z+6To/n7LL4zuXzb9v6P7cy96Obp/64ObovsT9ro0ur98zlHR/ROWXRTdv+FvTozuTz5iQnR/1ANvRfd3feuH0f2ZH/l0dH/p2b+I7rsAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSA7PWfCb6wPS9/yO6//CKidH9BfecFN1/+uQbovtrhsZF9/c8vSa6/9Njst//9sHnovubJu4f3X/2L74R3T9l5Fej+7dtG4ruf/uT+0T37/7E9dH9R99/QXTfBQBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBrc96XvRx/YfuhN0f0nr7w+ur/1D34W3X/3zx+I7h885cXo/p3XDET3T/3UMdH9+9ZOje5fvOXy6P7dt384uj/tBwdG92fNeDu6v2veG9H9M762Iro/4bjHovsuAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1MCIhf8XfeAP/2s4uv/crr+L7k895J7o/oxDbo7uf3fm0uj+uaN+Et1fMfDD6P4FU7J//8b1b0f3D/3mQ9H90RecHt0f89G9o/vPf2lJdP/ji3dG9289OLvvAgAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASg186qzx0Qfe2bFfdP/B9306uv/5954T3f/iTx+O7l/yyKXR/YETn4ruH/1Pc6P7/3zyFdH9Px15RHR/8XuPje4PrZwd3T/t7KXR/f+dvCq6f9VbL0b33z3+19F9FwBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUGpw4iUfiz6wYtXY6P7s7zwf3d9xxZLo/titM6P7mz+R3Z8246Lo/jur1kf3D56+Mrp//u7d0f2Fd94f3b//6zui+xsn3xzdv3bH6dH9cXuOiO7f+p8jo/suAIBSAgBQSgAASgkAQCkBACglAAClBACglAAAlBIAgFICAFBKAABKCQBAKQEAKCUAAKUEAKCUAACUEgCAUgIAUEoAAEoJAEApAQAoJQAApQQAoJQAAJQSAIBSAgBQSgAASgkAQCkBACglAAClBACg1P8HAAD//+SLeeht2MttAAAAAElFTkSuQmCC'),DATE '1906-04-28');

@kolea2kolea2Aug 7, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's switch the BASE64 values to something generated by RandomResultSetGenerator.

@olavloiteolavloiteAug 7, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BASE64 values have been replaced with generated random numbers.

@olavloite
olavloiteforce-pushed the spanner-jdbc-cleanup-it-jdbc-statements branch from 01814a6 to f189dfdCompareAugust 7, 2019 07:45
@olavloite

olavloite commented Aug 16, 2019

Copy link
Copy Markdown
ContributorAuthor

Test failure is caused by flake that is addressed by #6095.

kolea2
kolea2 previously approved these changes Aug 16, 2019
View reviewed changes
@kolea2

kolea2 commented Aug 16, 2019

Copy link
Copy Markdown
Contributor

LGTM after rebase

@kolea2
kolea2 dismissed their stale reviewAugust 16, 2019 15:07

rebase needed

@olavloite
olavloiteforce-pushed the spanner-jdbc-cleanup-it-jdbc-statements branch from 59d2da3 to 4829aafCompareAugust 16, 2019 15:33
@olavloite
olavloite requested a review from kolea2August 17, 2019 06:07
@olavloite

olavloite commented Aug 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@kolea2
kolea2 merged commit 0aaa471 into googleapis:masterAug 19, 2019
This was referenced Aug 22, 2019
Closed
Merged
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@olavloite@kolea2
spanner-jdbc: Add jdbc statement integration tests (googleapis#6033)
b0c5389
* add jdbc statement integration tests
* fix parsing error
* replace base64 with random numbers
* use generated names
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kolea2kolea2kolea2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot