Skip to content

spanner-jdbc: Add integration tests for JDBC DatabaseMetadata - #6035

Merged
kolea2 merged 3 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-cleanup-it-database-metadata
Aug 19, 2019
Merged

spanner-jdbc: Add integration tests for JDBC DatabaseMetadata#6035
kolea2 merged 3 commits into
googleapis:masterfrom
olavloite:spanner-jdbc-cleanup-it-database-metadata

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Adds integration tests for JDBC DatabaseMetadata.

@olavloite
olavloite requested a review from kolea2August 6, 2019 14:22
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 6, 2019
@codecov

codecovBot commented Aug 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6035 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6035 +/- ##
============================================
- Coverage 47.1% 47.02% -0.08% + Complexity 27180 25715 -1465 
============================================
Files 2523 2523 Lines 274440 269305 -5135 Branches 30557 31187 +630 ============================================
- Hits 129271 126641 -2630 + Misses 134770 133989 -781 + Partials 10399 8675 -1724
Impacted FilesCoverage ΔComplexity Δ
...re/src/main/java/com/google/cloud/BaseService.java55.55% <0%> (-6.95%)2% <0%> (ø)
...m/google/cloud/vision/v1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java58.69% <0%> (-3.31%)15% <0%> (-4%)
...le/cloud/compute/deprecated/DeprecationStatus.java88.63% <0%> (-3.13%)20% <0%> (ø)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
...e/cloud/vision/v1p2beta1/ImageAnnotatorClient.java47.05% <0%> (-2.95%)9% <0%> (-2%)
.../java/com/google/cloud/speech/v1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...om/google/cloud/speech/v1p1beta1/SpeechClient.java48.57% <0%> (-2.78%)10% <0%> (-2%)
...d/webrisk/v1beta1/WebRiskServiceV1Beta1Client.java63.41% <0%> (-2.5%)12% <0%> (-3%)
...ogle/cloud/texttospeech/v1/TextToSpeechClient.java55.88% <0%> (-2.46%)9% <0%> (-2%)
... and 666 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d820f3d...6ca4864. Read the comment docs.

@kolea2

Copy link
Copy Markdown
Contributor

LGTM after rebase

@olavloite
olavloiteforce-pushed the spanner-jdbc-cleanup-it-database-metadata branch from d37008a to a742a72CompareAugust 16, 2019 15:43
@olavloite
olavloiteforce-pushed the spanner-jdbc-cleanup-it-database-metadata branch from a742a72 to 6ca4864CompareAugust 17, 2019 06:12
@olavloite

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@kolea2
kolea2 merged commit dc2672a into googleapis:masterAug 19, 2019
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
…apis#6035)
* add integration tests for jdbc database metadata
* fix formatting
* use random data
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot