Skip to content

spanner-tests: Sleep uninterruptedly to prevent test failures - #6096

Merged
olavloite merged 2 commits into
googleapis:masterfrom
olavloite:spanner-tests-sleep-uninterrupted
Aug 17, 2019
Merged

spanner-tests: Sleep uninterruptedly to prevent test failures#6096
olavloite merged 2 commits into
googleapis:masterfrom
olavloite:spanner-tests-sleep-uninterrupted

Conversation

@olavloite

@olavloiteolavloite commented Aug 16, 2019

Copy link
Copy Markdown
Contributor

Prevent a spurious wakeup or thread interrupt from causing a test failure due to an unexpected execution time.

Updates #6075

@olavloite
olavloite requested a review from kolea2August 16, 2019 12:38
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@codecov

codecovBot commented Aug 16, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6096 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #6096 +/- ##
============================================
- Coverage 47.38% 47.38% -0.01% - Complexity 27182 27195 +13 
============================================
Files 2523 2523 Lines 274581 274581 Branches 31380 31375 -5 ============================================
- Hits 130123 130113 -10 - Misses 134850 134858 +8 - Partials 9608 9610 +2
Impacted FilesCoverage ΔComplexity Δ
.../java/com/google/cloud/testing/CommandWrapper.java87.87% <0%> (-9.1%)13% <0%> (ø)
.../cloud/datastore/testing/LocalDatastoreHelper.java80.59% <0%> (-4.48%)17% <0%> (ø)
...able/gaxx/reframing/ReframingResponseObserver.java88.99% <0%> (-1.84%)29% <0%> (-1%)
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java86.87% <0%> (-0.91%)39% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1daf76a...80b1e6c. Read the comment docs.

@olavloite
olavloite merged commit 1797b2e into googleapis:masterAug 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@olavloite@kolea2@googlebot