Add properties for new job statistics by tseaver · Pull Request #3721 · googleapis/google-cloud-python

tseaver · 2017-08-02T23:27:43Z

Closes#3706.

Note for reviewers: commit-by-commit might be an easier path.

Eases construction of a client with a new project, but the same credentials / http implementation.

theacodes · 2017-08-02T23:29:16Z

I'm going to defer to @tswast for this.

tswast

Thanks! A couple suggestions.

Sign in to view

+ See:
+ https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.queryPlan
+
+ :rtype: list of dict


Sign in to view

 return job

+ @property
+ def query_plan(self):


Sign in to view

 project=project, credentials=credentials, _http=_http)
 self._connection = Connection(self)

+ def _clone(self, project):


Sign in to view

+ t_project = table['projectId']
+ t_client = clients_by_project.get(t_project)
+ if t_client is None:
+ t_client = client._clone(t_project)


Sign in to view

 return tables

+ @property
+ def num_dml_affected_rows(self):


Sign in to view

+
+ See:
+ https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.schema
+


Sign in to view

+ See:
+ https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.undeclaredQueryParamters
+
+ :rtype: list of dict


Sign in to view

+ :returns: a new instance, bound to the supplied project, using
+ the same credentials / http object as this instance.
+ """
+ return self.__class__(project, self._credentials, self._http)


tseaver · 2017-08-12T19:22:05Z

@tswast I'm going to break this up into separate PRs, targeting the bigquery-b2 branch.

tseaver added 14 commits August 2, 2017 17:30

Add 'QueryJob.query_plan' property.
a3dcf11

Add 'QueryJob.total_bytes_processed' property.
691f221

Add 'QueryJob.total_bytes_billed' property.
913db1c

Add 'QueryJob.billing_tier' property.
9e88976

Add 'QueryJob.cache_hit' property.
53ed914

Add 'Client._clone' helper.
941ad92
Eases construction of a client with a new project, but the same credentials / http implementation.

Add 'QueryJob.referenced_tables' property.
1e34f2d

Add 'QueryJob.num_dml_affected_rows' property.
3042da1

Add 'QueryJob.schema' property.
da1112a

Add 'QueryJob.undeclared_schema_parameters' property.
6009e30

Add 'QueryJob.statement_type' property.
419c8b6

Add 'ExtractTableToStorageJob.destination_uri_file_counts' property.
0f443ea

Factor out job-specific stats helper.
ed3aacc

Coverage.
6380fb9

tseaver added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 2, 2017

tseaver requested review from dhermes and theacodes August 2, 2017 23:27

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2017

Fix docs build.
0cd8fa5

tswast requested changes Aug 3, 2017
View reviewed changes

dhermes reviewed Aug 10, 2017
View reviewed changes

Comment threadbigquery/google/cloud/bigquery/client.py
:returns: a new instance, bound to the supplied project, using
the same credentials / http object as this instance.
"""
return self.__class__(project, self._credentials, self._http)
This comment was marked as spam.
Sign in to view

tseaver mentioned this pull request Aug 12, 2017
Bigquery Beta 2 Tracking #3746
Closed
18 tasks

tseaver closed this Aug 12, 2017

This was referenced Aug 12, 2017
Add 'QueryJob.query_plan' property. #3799
Merged
Add new scalar statistics properties to 'QueryJob' #3800
Merged
Add 'QueryJob.referenced_tables' property. #3801
Merged
Add 'QueryJob.undeclared_query_parameters' property. #3802
Merged

tseaver mentioned this pull request Aug 12, 2017
Add 'ExtractTableStorageJob.destination_uri_file_counts' property. #3803
Merged

tseaver deleted the 3706-bigquery-new-job-statistics branch September 8, 2017 12:56

Navigation Menu

Uh oh!

Add properties for new job statistics - #3721

Add properties for new job statistics#3721
tseaver wants to merge 15 commits into
googleapis:masterfrom
tseaver:3706-bigquery-new-job-statistics

tseaver commented Aug 2, 2017

Uh oh!

theacodes commented Aug 2, 2017

Uh oh!

tswast left a comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Aug 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		See:
		https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.schema

Uh oh!

Conversation

tseaver commented Aug 2, 2017

Uh oh!

theacodes commented Aug 2, 2017

Uh oh!

tswast left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Aug 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants