Skip to content

KMS: Updated for new client library - #1903

Merged
daniel-sanche merged 5 commits into
masterfrom
kms-gapic-update
Jan 7, 2019
Merged

KMS: Updated for new client library#1903
daniel-sanche merged 5 commits into
masterfrom
kms-gapic-update

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Dec 5, 2018

Copy link
Copy Markdown
Member

Updated all samples to use the new libraries

tracking bug: b/120216809

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric.py Outdated
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric.py Outdated
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric_test.py Outdated
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric_test.py Outdated
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric_test.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/quickstart.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/quickstart.py
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/requirements.txt Outdated
engelke
engelke reviewed Dec 19, 2018
View reviewed changes
Comment threadkms/api-client/asymmetric_test.py Outdated
engelke
engelke suggested changes Dec 19, 2018
View reviewed changes

@engelkeengelke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asymmetric samples all have comments saying that they work on key IDs, but actually require key version IDs. The tests all work with key versions, so they pass.

Please address the comments and update.

@daniel-sanche

daniel-sanche commented Dec 21, 2018

Copy link
Copy Markdown
MemberAuthor

@engelke I addressed your comments, let me know if there's anything else

@daniel-sanchedaniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2019
@daniel-sanche
daniel-sanche merged commit 6f9eacf into masterJan 7, 2019
@daniel-sanche
daniel-sanche deleted the kms-gapic-update branch January 8, 2019 23:45
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
@daniel-sanche@busunkim96
KMS: Updated for new client library [(#1903)](GoogleCloudPlatform/pyt…
6ef75e2
…hon-docs-samples#1903)
* updated kms samples to use new gapic client library
@rsamborskirsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@daniel-sanche@rsamborski
KMS: Updated for new client library [(#1903)](#1903)
cc6b00e
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@daniel-sanche@rsamborski
KMS: Updated for new client library [(#1903)](#1903)
1e40097
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@daniel-sanche@rsamborski
KMS: Updated for new client library [(#1903)](#1903)
df03dc0
* updated kms samples to use new gapic client library
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@daniel-sanche@dandhlee
KMS: Updated for new client library [(#1903)](#1903)
1e8220d
* updated kms samples to use new gapic client library
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@daniel-sanche@busunkim96
KMS: Updated for new client library [(#1903)](GoogleCloudPlatform/pyt…
620b210
…hon-docs-samples#1903)
* updated kms samples to use new gapic client library
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@engelkeengelkeengelke approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.kokoro:force-runAdd this label to force Kokoro to re-run the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche@engelke@googlebot