Skip to content

[automl] fix: retry vision_object_detection_predict.predict - #3492

Merged
tmatsuo merged 3 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-automl
Apr 24, 2020
Merged

[automl] fix: retry vision_object_detection_predict.predict#3492
tmatsuo merged 3 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-automl

Conversation

@tmatsuo

Copy link
Copy Markdown
Contributor

fixes#3415

Also setting a hard deadline for model deployment.

fixesGoogleCloudPlatform#3415
Also setting a hard deadline for model deployment.
@tmatsuo
tmatsuo requested a review from nnegreyApril 23, 2020 23:40
@tmatsuo
tmatsuo requested review from a team, sirtorry and telpirion as code ownersApril 23, 2020 23:40
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2020
@tmatsuo

Copy link
Copy Markdown
ContributorAuthor

It doesn't affect the published sample, also the infinite loop is bad for our tests and build-cop-bot, so I'm going to merge this. @telpirion@sirtorry@nnegrey Let me know if you have concerns.

@tmatsuotmatsuo added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 24, 2020
@tmatsuo
tmatsuo merged commit 86a552c into GoogleCloudPlatform:masterApr 24, 2020
@tmatsuo
tmatsuo deleted the fix-automl branch April 24, 2020 05:10
# Deploy model if it is not deployed
response = client.deploy_model(model_full_id)
response.result()
response.result(600) # 10 minutes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth bumping this to 30 minutes.
Model Deployement is really slow

busunkim96 pushed a commit to busunkim96/python-automl that referenced this pull request Aug 7, 2020
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Aug 11, 2020
arbrown pushed a commit that referenced this pull request Nov 17, 2022
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

automl.cloud-client.vision_object_detection_predict_test: test_vision_object_detection_predict failed

4 participants

@tmatsuo@nnegrey@kurtisvg@googlebot