Skip to content

fix(translate): fix a broken test - #4360

Merged
engelke merged 3 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-translate
Jul 23, 2020
Merged

fix(translate): fix a broken test#4360
engelke merged 3 commits into
GoogleCloudPlatform:masterfrom
tmatsuo:fix-translate

Conversation

@tmatsuo

Copy link
Copy Markdown
Contributor

fixes#4353

@tmatsuo
tmatsuo requested a review from telpirionJuly 22, 2020 22:59
@tmatsuo
tmatsuo requested review from a team and sirtorry as code ownersJuly 22, 2020 22:59
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 22, 2020

@engelkeengelke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke

Copy link
Copy Markdown
Contributor

Failed Py 3.8 test with 404, but passed the others. Language version should not have mattered. Is it possible that simultaneous running tests interfered with each other? Perhaps name test based on UUID instead of timestamp.

@telpirion

Copy link
Copy Markdown
Contributor

Yeah, I would change the test to use UUID instead of Timestamp.

@tmatsuo

Copy link
Copy Markdown
ContributorAuthor

@engelke Good catch! I didn't notice it's using timestamp. I'll change it to use uuid.

@engelke
engelke merged commit 7b3eb58 into GoogleCloudPlatform:masterJul 23, 2020
busunkim96 pushed a commit to busunkim96/python-automl that referenced this pull request Aug 17, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Aug 17, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-translate that referenced this pull request Aug 17, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-translate that referenced this pull request Sep 1, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-translate that referenced this pull request Sep 1, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Sep 15, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
busunkim96 pushed a commit to googleapis/python-automl that referenced this pull request Sep 15, 2020
…n-docs-samples#4360)
* fix(translate): fix a broken test
fixes #4353
* use uuid
* fix builds
telpirion pushed a commit that referenced this pull request Nov 16, 2022
* fix(translate): fix a broken test
fixes#4353
* use uuid
* fix builds
arbrown pushed a commit that referenced this pull request Nov 17, 2022
* fix(translate): fix a broken test
fixes#4353
* use uuid
* fix builds
dandhlee pushed a commit that referenced this pull request Nov 17, 2022
* fix(translate): fix a broken test
fixes#4353
* use uuid
* fix builds
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
* fix(translate): fix a broken test
fixes#4353
* use uuid
* fix builds
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failures in translate/automl

4 participants

@tmatsuo@engelke@telpirion@leahecole