Skip to content

Bash script made an incorrect string comparison - #10634

Merged
Nir-Az merged 1 commit into
realsenseai:developmentfrom
jcremona:patch_script_bug
Sep 15, 2022
Merged

Bash script made an incorrect string comparison#10634
Nir-Az merged 1 commit into
realsenseai:developmentfrom
jcremona:patch_script_bug

Conversation

@jcremona

Copy link
Copy Markdown

if [ "4.4" == PATCHES_REV ];

was replaced with:

if [ "4.4" = "$PATCHES_REV" ];

Missing $.

@dmipx

dmipx commented Sep 14, 2022

Copy link
Copy Markdown

Thanks for contribution!
Please re-submit this PR to 'development' branch so we can merge it.
@Nir-Az can you speedup and change PR branch?

@Nir-Az
Nir-Az changed the base branch from master to development September 14, 2022 14:12
@Nir-Az

Nir-Az commented Sep 14, 2022

Copy link
Copy Markdown
Collaborator

@jcremona Can you confirm testing this change on JP 4.4?

@jcremona

Copy link
Copy Markdown
Author

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

@Nir-Az

Nir-Az commented Sep 15, 2022

Copy link
Copy Markdown
Collaborator

@jcremona Can you confirm testing this change on JP 4.4?

I've tested on L4T version 32.2.1. When tested on this version, this script sets PATCHES_REV to 4.4. My Jetson TX2 has a JetPack 4.2.2.

Great, thanks!

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit bf48dfd into realsenseai:development Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants