Skip to content

added utilities/string/chrono.h; fix test-waiting-on.cpp to use it - #10762

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
maloel:development
Aug 14, 2022
Merged

added utilities/string/chrono.h; fix test-waiting-on.cpp to use it#10762
Nir-Az merged 2 commits into
realsenseai:developmentfrom
maloel:development

Conversation

@maloel

@maloel maloel commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Durations do not have an operator<< unless you're in C++20, so output from test-waiting-on was not readable.
Before:

C:\jenkins_sys_rsbuild\workspace\LRS_windows_compile_pipeline\unit-tests\utilities\time\test-waiting-on.cpp(164): FAILED:
  REQUIRE( wait_time >= timeout )
with expansion:
  {?} >= {?}

After:

with expansion:
  0.005s > 1.99s

@maloel
maloel requested a review from Nir-Az August 10, 2022 07:40

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nir-Az
Nir-Az merged commit 31d7702 into realsenseai:development Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants