Fix build fail due missing operator= in popup - #10881
Merged
Merged
Conversation
Collaborator
|
@baderouaich Thanks for the quick catch! |
If an operator=() is needed then objects can't be const. Using a `const_cast` is not a good idea, IMO.
maloel
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build failure after PR #10809 in Windows and Linux due missing operator= in common/viewer.h#16 which is required by std::vector::erase when having const members.
Workaround
this can also be solved by making the struct popup's members
header,messageandcustom_commandnon-const instead of usingconst_cast.