Skip to content

Add a new Emitter frequency option - #10953

Merged
Nir-Az merged 14 commits into
realsenseai:D4XX_MIPIfrom
Nir-Az:pwm_freq_option
Oct 19, 2022
Merged

Add a new Emitter frequency option#10953
Nir-Az merged 14 commits into
realsenseai:D4XX_MIPIfrom
Nir-Az:pwm_freq_option

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Oct 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

D455 & D457 devices only

  1. Add Emitter frequency new XU option
  2. Add a new Unit Test checking the option requirements (default values + not setting while streaming)
  3. Extract option_model from the model-views BIG file
  4. Refactor options drawing function for a more readable code
    Tracked on [LRS-516]

@Nir-Az
Nir-Az force-pushed the pwm_freq_option branch 2 times, most recently from 10ea59e to 01ca2fe Compare October 3, 2022 11:27
@Nir-Az Nir-Az closed this Oct 11, 2022
@Nir-Az Nir-Az reopened this Oct 11, 2022
@Nir-Az
Nir-Az requested a review from remibettan October 11, 2022 18:44
remibettan
remibettan reviewed Oct 18, 2022
View reviewed changes

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - thanks!

Comment thread common/model-views.cpp Outdated
Comment thread common/option-model.cpp
Comment thread include/librealsense2/h/rs_option.h
Comment thread src/ds5/ds5-options.cpp
Comment thread src/ds5/ds5-options.cpp
Comment thread src/ds5/ds5-options.h
public:
explicit emitter_frequency( uvc_sensor & ep,
const std::map< float, std::string > & description_per_value );
void set( float value ) override;

@remibettan remibettan Oct 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed? See corresponding comment in the cpp file

@Nir-Az Nir-Az Oct 18, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer

@remibettan remibettan Oct 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread unit-tests/live/d400/test-emitter-frequency.py
Comment thread unit-tests/live/d400/test-emitter-frequency.py Outdated
################################################################################################

test.start("Verify camera defaults")
device_nane = device.get_info(rs.camera_info.name)

@remibettan remibettan Oct 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo naMe

@Nir-Az Nir-Az Oct 19, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rename thanks

@remibettan remibettan Oct 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has it been corrected?

@Nir-Az Nir-Az Oct 19, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@remibettan remibettan Oct 19, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment thread unit-tests/live/d400/test-emitter-frequency.py
Comment thread wrappers/python/pyrsutil.cpp Outdated
@Nir-Az
Nir-Az requested a review from remibettan October 19, 2022 11:34
remibettan
remibettan reviewed Oct 19, 2022
View reviewed changes

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fewer comments...

remibettan
remibettan approved these changes Oct 19, 2022
View reviewed changes

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit e45b1fa into realsenseai:D4XX_MIPI Oct 19, 2022
@lupak

lupak commented Apr 4, 2023

Copy link
Copy Markdown

Hi! I've updated my camera firmware version to 5.14.0 and the realsense version to v2.53.1. How do I access and set this setting?

@Nir-Az

Nir-Az commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Hi! I've updated my camera firmware version to 5.14.0 and the realsense version to v2.53.1. How do I access and set this setting?

Can you share which camera model are you using?

@lupak

lupak commented Apr 4, 2023

Copy link
Copy Markdown

D430

@lupak

lupak commented Apr 4, 2023

Copy link
Copy Markdown

Ahh I might have missed reading the top part of the 1st comment. Is it for D455 & D457 devices only?
If yes, is there a way to replicate it for the D430s?
We have a situation where the laser is affecting wireless mic systems in classrooms.

@Nir-Az

Nir-Az commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator Author

I just added it so it will be clearer 😀.
I will check about your question and update.

@lupak

lupak commented Apr 5, 2023

Copy link
Copy Markdown

Thank you!

@Nir-Az

Nir-Az commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator Author

@lupak I can to update you that we are discussing this issue internally and I believe we will add this feature implementation into or FW + SDK, but it will take some time because laser related implementation and validation require some extra processes.
Please monitor future releases for this feature.
Thanks

@lupak

lupak commented Apr 18, 2023

Copy link
Copy Markdown

Thanks for the update @Nir-Az

@lupak

lupak commented Sep 17, 2024

Copy link
Copy Markdown

Hi! Is there any update on this being available on the D430 cameras?

@Nir-Az

Nir-Az commented Sep 18, 2024

Copy link
Copy Markdown
Collaborator Author

@lupak Hi,
Looks like this internal threat didn't reach to a conclusion,
Let me recheck that and get back with an answer..

@Nir-Az
Nir-Az deleted the pwm_freq_option branch September 30, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remibettan remibettan remibettan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nir-Az @lupak @remibettan