Skip to content

bump json to v3.11.2 - #11000

Merged
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:json
Oct 24, 2022
Merged

bump json to v3.11.2#11000
maloel merged 2 commits into
realsenseai:developmentfrom
maloel:json

Conversation

@maloel

@maloel maloel commented Oct 16, 2022

Copy link
Copy Markdown
Contributor

We were using v2.0.8, back from 2016...
New version includes lots of fixes and enhancements, including support for binary formats (BSON, CBOR, MessagePack, etc.).

Should be backwards compatible, but unit-test coverage is probably lacking. I did some manual testing, loading and saving json settings in the viewer with the L500 and D415, seems OK.

@maloel
maloel marked this pull request as ready for review October 16, 2022 07:09
@maloel
maloel requested a review from Nir-Az October 16, 2022 07:09

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe see you can load / save the viewer configuration.

I guess if this works the online updates will work as well..

@maloel

maloel commented Oct 18, 2022

Copy link
Copy Markdown
Contributor Author

Maybe see you can load / save the viewer configuration.

Did that -- see the description :)

@Nir-Az

Nir-Az commented Oct 18, 2022

Copy link
Copy Markdown
Collaborator

Maybe see you can load / save the viewer configuration.

Did that -- see the description :)

I meant realsense-config.json file.
Can be found in %appdata% on a windows machine.
You can delete it and see when the viewer is starting it should wtire a new one.
And when you change settings it should override it

@Nir-Az

Nir-Az commented Oct 23, 2022

Copy link
Copy Markdown
Collaborator

Maybe see you can load / save the viewer configuration.

Did that -- see the description :)

I meant realsense-config.json file. Can be found in %appdata% on a windows machine. You can delete it and see when the viewer is starting it should wtire a new one. And when you change settings it should override it

Ready for merge?

@maloel

maloel commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

I checked the realsense-config.json file, and saw changes when changing in app, when reloading app, etc.
I also exported and reimported settings, and no problems with the .json files.

@maloel
maloel merged commit eb422f2 into realsenseai:development Oct 24, 2022
maloel added a commit to maloel/librealsense that referenced this pull request Oct 24, 2022
maloel added a commit to maloel/librealsense that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants