Skip to content

Do a shallow git fetch instead of full fetch - #11019

Closed
codekansas wants to merge 3 commits into
realsenseai:developmentfrom
codekansas:master
Closed

Do a shallow git fetch instead of full fetch#11019
codekansas wants to merge 3 commits into
realsenseai:developmentfrom
codekansas:master

Conversation

@codekansas

Copy link
Copy Markdown
Contributor

Doing a shallow git fetch is a lot faster and lets the script run much more quickly without affecting the script's behavior

odubovsky and others added 3 commits October 21, 2022 17:48
Doing a shallow `git fetch` is a lot faster and lets the script run much more quickly
@Nir-Az
Nir-Az requested a review from dmipx October 25, 2022 19:43
@Nir-Az
Nir-Az changed the base branch from master to development October 27, 2022 08:29
@Nir-Az
Nir-Az changed the base branch from development to master October 27, 2022 08:30
@Nir-Az

Nir-Az commented Oct 27, 2022

Copy link
Copy Markdown
Collaborator

@codekansas Thanks for your contribution,
For future contributions please align to our contribution guide and base & target the changes to development branch

@dmipx looks like a nice optimization right?

Can be also updated in our kernel 5.13/5.15 script

@codekansas

Copy link
Copy Markdown
Contributor Author

Yeah, I was just following the install instructions and found this change made it go a lot faster, and I thought it'd be immediately useful for other people. It's a pretty minimal change so I just figured I'd throw it over the wall (I think there's other scripts which also fetch the entire Ubutu repo that would benefit but I wasn't trying them out). I'll be sure to use the development branch if I do end up making deeper changes later

@dmipx dmipx left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good catch!
@Nir-Az please change this PR to development branch.
@codekansas Can you add same change to the following script (new kernels support): https://github.com/IntelRealSense/librealsense/blob/development/scripts/patch-realsense-ubuntu-lts-hwe.sh ?
This PR will be merged to both scripts.

@Nir-Az
Nir-Az changed the base branch from master to development October 27, 2022 17:41
@codekansas

Copy link
Copy Markdown
Contributor Author

Closing this PR in favor of the other one (which is based off my fork's development branch): #11041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants