Multi d457 - #11070
Merged
Merged
Conversation
remibettan
reviewed
Nov 5, 2022
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Few comments - great work!
| // further development is needed to permit use of several mipi devices | ||
| static int first_video_index = ind; | ||
| if (ind == first_video_index || ind == first_video_index + 2 || ind == first_video_index + 4) | ||
| ind = (ind - first_video_index) % 6; // offset from first mipi video node and assume 6 nodes per mipi camera |
Contributor
There was a problem hiding this comment.
This will not work if a usb device is also connected. It will have 3 video nodes and the logic used here will then not work.
| // TODO - find a way to assign unique id for mipi | ||
| // maybe using bus_info and card params (see above in this method) | ||
| //info.unique_id = busnum + "-" + devpath + "-" + devnum; | ||
| info.unique_id = bus_info; // use bus_info as per camera unique id for mipi |
Contributor
There was a problem hiding this comment.
Seems to be enough, but could you please add here how would the busnum look like for each of the mipi devices, for example if 2 devices are connected?
Besides that, if this is chosen as unique_id, the above comment can be removed.
Contributor
Author
There was a problem hiding this comment.
Thank you.
Below is an example of busnum as well as the card param: [bus_info -- card_info] of 4 x D457 mipi devices. Bus_info seems to be unique to each mipi device and work in current system.
platform:15c10000.vi:0 -- vi-output, DS5 mux 34-0010
platform:15c10000.vi:0 -- 15c10000.vi-metadata-0
platform:15c10000.vi:0 -- vi-output, DS5 mux 35-0010
platform:15c10000.vi:0 -- 15c10000.vi-metadata-0
platform:15c10000.vi:0 -- vi-output, DS5 mux 36-0010
platform:15c10000.vi:0 -- vi-output, DS5 mux 37-0010
platform:15c10000.vi:2 -- vi-output, DS5 mux 38-0010
platform:15c10000.vi:2 -- 15c10000.vi-metadata-2
platform:15c10000.vi:2 -- vi-output, DS5 mux 39-0010
platform:15c10000.vi:2 -- 15c10000.vi-metadata-2
platform:15c10000.vi:2 -- vi-output, DS5 mux 40-0010
platform:15c10000.vi:2 -- vi-output, DS5 mux 41-0010
platform:15c10000.vi:4 -- vi-output, DS5 mux 42-0010
platform:15c10000.vi:4 -- 15c10000.vi-metadata-4
platform:15c10000.vi:4 -- vi-output, DS5 mux 43-0010
platform:15c10000.vi:4 -- 15c10000.vi-metadata-4
platform:15c10000.vi:4 -- vi-output, DS5 mux 44-0010
platform:15c10000.vi:4 -- vi-output, DS5 mux 45-0010
platform:15c10000.vi:5 -- vi-output, DS5 mux 46-0010
platform:15c10000.vi:5 -- 15c10000.vi-metadata-5
platform:15c10000.vi:5 -- vi-output, DS5 mux 47-0010
platform:15c10000.vi:5 -- 15c10000.vi-metadata-5
platform:15c10000.vi:5 -- vi-output, DS5 mux 48-0010
platform:15c10000.vi:5 -- vi-output, DS5 mux 49-0010
remibettan
self-requested a review
November 9, 2022 14:51
remibettan
approved these changes
Nov 9, 2022
Contributor
There was a problem hiding this comment.
PR can be merged.
Solution is not full, but it is better than current status.
@hsuys thanks a lot for your work!
dmipx
pushed a commit
to dmipx/librealsense
that referenced
this pull request
Feb 1, 2023
Following DSO-18585 PR realsenseai#11070 For use with jp5-2d457-1-des Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling multi camera support for D457