clean up rs-enumerate-devices tab output; add --verbose - #11080
Merged
Conversation
Nir-Az
reviewed
Nov 9, 2022
Nir-Az
reviewed
Nov 9, 2022
Nir-Az
reviewed
Nov 9, 2022
| } | ||
| cout << setw( w_fps ) << ( "@ " + std::to_string( profile.fps() ) + "Hz" ); | ||
| cout << setw( w_format ) << profile.format(); | ||
| cout << endl; |
Collaborator
There was a problem hiding this comment.
Can you share a run picture with the new changes so I can compare?
Collaborator
There was a problem hiding this comment.
Oh got it sid, please list it in the title on verbose mode as it is not clear without reading the code..
Contributor
Author
There was a problem hiding this comment.
I don't know that it'd be much help.
It's for us -- for debugging really. I.e., if you don't know what it is, ignore it. If I put (UID.IDX) as a heading, will that tell you much? If you want I'll add.
Collaborator
There was a problem hiding this comment.
I think it's better to add something, I first thought it the USB version (2.0)
Nir-Az
self-requested a review
November 13, 2022 12:25
Nir-Az
approved these changes
Nov 13, 2022
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Just add the missing title for verbose and its OK :)
Collaborator
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc changes to clean up my branch.
The
rs-enumerate-devicesoutput was using tabs, therefore was (usually) misaligned.I also added a
--verboseflag which, right now, only adds the(sid,index)pair to each profiles so we can check it.