Add ROS2 build step for LibRealSense - #11100
Conversation
changed to build with ament_cmake
|
Please (carefully) squash this 35 commits into 1, |
|
|
||
| # Rolling Ridley | ||
| - docker_image: ubuntu:jammy | ||
| ros_distribution: rolling |
There was a problem hiding this comment.
I don't see rolling in the matrix (line 16), why?
There was a problem hiding this comment.
I see that 4 jobs were tested by GHA but in the matrix, we have only 3 ros-distribution, so I see that "rolling" was tested too.
In addition, according to the sample no need specify "rolling" in the matrix.
There was a problem hiding this comment.
I think they may have missed it... try.
There was a problem hiding this comment.
Rolling added.
Passed GHA but, I will check if we have a difference in results/test later.
There was a problem hiding this comment.
Great, now please revert the error :)
|
Do we know if the GHA test will fail if the build fails? |
3cc7471 to
cfc206f
Compare
2 errors was injected in two files
3182761 to
bcde8cb
Compare
The syntax error was injected to rs.hpp (";" character was deleted). Console output:
|



Tracked on LRS-546