C++14 - #11105
Merged
Merged
Conversation
maloel
marked this pull request as draft
January 8, 2023 14:22
maloel
marked this pull request as ready for review
January 9, 2023 06:05
Nir-Az
reviewed
Jan 9, 2023
Nir-Az
reviewed
Jan 9, 2023
Collaborator
NVM :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build is here:
https://rsjenkins.iil.intel.com/view/LRS/job/LRS_release_flow_pipeline/4731/
LibCI has less warnings in Linux & Jetson.
Note that only the library internals (anything using concurrency etc.) need 14 -- all the rest (that depend on rs2, top of the hourglass) can stay on 11. I therefore left all the tools & examples on 11. We can adjust later as needed, but should start heeding compiler warnings now.
Note that the solution name changes in this, for the same reason we did the same in the
ddsbranch -- there was a mismatch between the project name (librealsense2) andLRS_TARGET(realsense2). The solution showsrealsense2as the project name under Library. Now everything matches.I ran the Viewer, seems to be working OK.
But no extensive testing...
Tracked on [LRS-620]