utilities as a library - #11137
Merged
Merged
Conversation
maloel
marked this pull request as ready for review
November 23, 2022 05:54
Nir-Az
reviewed
Nov 23, 2022
Nir-Az
reviewed
Nov 23, 2022
Nir-Az
approved these changes
Nov 23, 2022
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Looks great!
Like discussed, let's adapt the installer script and verify it works too as close as we can to merge this.
(cherry picked from commit 36f2ab5b7eb249d49c6bb42751303d33b778c9fe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.