pybind as a dependency in own project; utilities-py; test-split - #11147
Merged
Conversation
maloel
marked this pull request as ready for review
November 24, 2022 21:40
Use PYTHON_EXECUTABLE instead (using PYTHON_PATH). There were also referenced to Python 2.7...
Trying...
Nir-Az
reviewed
Nov 27, 2022
|
|
||
| # Now that it's available, we can refer to it with an actual ExternalProject_add (but notice we're not | ||
| # downloading anything) | ||
| ExternalProject_Add( pybind11 |
Collaborator
There was a problem hiding this comment.
What will happen here?
I think it will build it again during the build process
Why do we need to build it again?
why not just pybind11_add_module as before?
Nir-Az
reviewed
Nov 27, 2022
Nir-Az
reviewed
Nov 27, 2022
|
|
||
| # Put all the collaterals together, so we can find when trying to run examples/tests | ||
| # Note: this puts the outputs under <binary>/<build-type> | ||
| # Note note: this ruins our CI procedures... otherwise it mirrors Windows, simplifies |
Collaborator
There was a problem hiding this comment.
Please add a prefix 'We cannot uncomment because this.."
Collaborator
There was a problem hiding this comment.
# Note note: this ruins our CI procedures... otherwise it mirrors Windows, simplifies
to
# Note note: We cannot uncomment because it ruins our CI procedures... otherwise it mirrors Windows, simplifies
python/cpython#84006 >>> import sysconfig >>> sysconfig.get_config_var('EXT_SUFFIX') '.pyd' >>> from distutils import sysconfig >>> sysconfig.get_config_var('EXT_SUFFIX') '.cp38-win_amd64.pyd' v2.9.2 takes from the previous, v2.9.0 from the latter. So with v2.9.2 we get ABI-less extension which we need. v2.10.1 seems to have fixed this, but we cannot move to it (it deprecates VS2015)...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into same issues as before -- updated pybind11 to 2.9.0.