Skip to content

Stabilize timestamp domain test - #11167

Merged
Nir-Az merged 5 commits into
realsenseai:developmentfrom
Tamir91:bug/test-timestamp-domain-color-sensor-issue
Dec 7, 2022
Merged

Stabilize timestamp domain test#11167
Nir-Az merged 5 commits into
realsenseai:developmentfrom
Tamir91:bug/test-timestamp-domain-color-sensor-issue

Conversation

@Tamir91

@Tamir91 Tamir91 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Tracked on [LRS-567]
two queues were created for each type of sensor.
A queue was increased to 1 frame.

two queues were created for each type of sensor.
A queue was increased to 10 frames.
@Tamir91
Tamir91 marked this pull request as ready for review December 6, 2022 06:56
@Tamir91
Tamir91 requested a review from Nir-Az December 6, 2022 09:13
@Nir-Az

Nir-Az commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

two queues were created for each type of sensor. A queue was increased to 10 frames.

I see the capacity is 1, please update

Comment thread unit-tests/live/options/test-timestamp-domain.py
@Tamir91

Tamir91 commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

It was 1 in the previous code version, but I checked with size=10 yesterday and found it failing the test.
I will run the test with queue size=5 and update you.

The capacity of a queue is 5.
In case of a failure, data fame printed.
@Nir-Az

Nir-Az commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

It was 1 in the previous code version, but I checked with size=10 yesterday and found it failing the test. I will run the test with queue size=5 and update you.

No need for more then 1

Unnecessary "IF" statement was removed.
The frame queue size changed back to 1.
@Nir-Az
Nir-Az self-requested a review December 6, 2022 18:33

@Nir-Az Nir-Az left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az changed the title two queues created Stabilize timestamp domain test Dec 7, 2022
@Nir-Az
Nir-Az merged commit 926e65b into realsenseai:development Dec 7, 2022
@Tamir91
Tamir91 deleted the bug/test-timestamp-domain-color-sensor-issue branch December 22, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants