Hkr other ds rebased dev - #11222
Merged
Nir-Az merged 53 commits intoDec 25, 2022
Merged
Conversation
remibettan
force-pushed
the
hkr_other_ds_rebased_dev
branch
2 times, most recently
from
December 15, 2022 14:35
3e14573 to
c604c76
Compare
Nir-Az
reviewed
Dec 15, 2022
| bool frame_arrived = false; | ||
| try | ||
| { | ||
| if (_sub->s->supports(RS2_OPTION_THERMAL_COMPENSATION)) |
Collaborator
There was a problem hiding this comment.
This looks like a mistake
Development has it
Nir-Az
reviewed
Dec 15, 2022
|
|
||
| if (_pid != ds::RS457_PID) //not mipi device |
Collaborator
There was a problem hiding this comment.
Hard to follow, where did this lines go?
Contributor
Author
There was a problem hiding this comment.
In line 191, in method register_metadata
…en - till this works
remibettan
force-pushed
the
hkr_other_ds_rebased_dev
branch
from
December 19, 2022 07:27
369dcd3 to
ee6f12b
Compare
Nir-Az
reviewed
Dec 20, 2022
| public motion_sensor | ||
| { | ||
| public: | ||
| explicit ds_motion_sensor(std::string name, |
Contributor
Author
There was a problem hiding this comment.
yes, one needs the sets for mapping of the profiles (uvc) and one does not (hid)
Nir-Az
reviewed
Dec 20, 2022
| auto fisheye_auto_exposure = register_auto_exposure_options(_fisheye_ep.get(), &ds::fisheye_xu); | ||
| if (auto fisheye_sensor = dynamic_cast<ds_fisheye_sensor*>(_fisheye_ep.get())) | ||
| fisheye_sensor->set_roi_method(std::make_shared<fisheye_auto_exposure_roi_method>(fisheye_auto_exposure)); | ||
| else if (auto fisheye_sensor = dynamic_cast<ds_fisheye_sensor*>(_fisheye_ep.get())) |
Collaborator
There was a problem hiding this comment.
if and else match,
Am I missing something?
Contributor
Author
There was a problem hiding this comment.
correct- removed
Nir-Az
approved these changes
Dec 25, 2022
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Looks good,
As discussed lets do a short D457 sanity and comparation of controls against development and we'll merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by : LRS-581