D457 MIPI enable multiple cameras for single DES. - #11385
Merged
Conversation
Following DSO-18585 PR realsenseai#11070 For use with jp5-2d457-1-des Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Collaborator
|
@hsuys can you please verify this does not break your multi MIPI cams test? |
Nir-Az
reviewed
Feb 2, 2023
| @@ -786,7 +787,7 @@ namespace librealsense | |||
| // are not available via mipi | |||
| // TODO - find a way to assign unique id for mipi | |||
| // maybe using bus_info and card params (see above in this method) | |||
Collaborator
There was a problem hiding this comment.
Please update the above comment.
and the line comment
Until we will add dynamic binding we use bus info which is unique for a singe deserializer and cam_id which is unique to each camera connected to it, right?
added 3 commits
February 5, 2023 09:55
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
…me.h Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Nir-Az
approved these changes
Feb 6, 2023
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
LGTM + CI internal + val flows passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following DSO-18585 PR #11070
For use with jp5-2d457-1-des
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com