update third-party:tinyfiledialogs version to 3.9.0: cleanup format-overflow warning - #11396
Merged
Merged
Conversation
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Collaborator
|
Lets first see if we can update the third party to fix it. |
Collaborator
|
https://sourceforge.net/projects/tinyfiledialogs/ |
remibettan
reviewed
Feb 6, 2023
| static int lTkinter2Present = -1 ; | ||
| char lPythonCommand[256]; | ||
| char lPythonParams[256] = | ||
| char lPythonParams[224] = |
Contributor
There was a problem hiding this comment.
why 224 is better than 256?
Author
There was a problem hiding this comment.
lPythonParams copied to lPythonCommand.
lPythonParams is constant strings that never reach more than 218 characters (line 4080)
remibettan
reviewed
Feb 6, 2023
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Only one minor comment
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com