Skip to content

Add depth auto exposure mode - #11432

Merged
Nir-Az merged 4 commits into
realsenseai:developmentfrom
Nir-Az:add_new_AE
Feb 16, 2023
Merged

Add depth auto exposure mode#11432
Nir-Az merged 4 commits into
realsenseai:developmentfrom
Nir-Az:add_new_AE

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Feb 12, 2023

Copy link
Copy Markdown
Collaborator

Tracked on [LRS-656]

  • Some UI enhancements and alignments
  • Unit test

@Nir-Az
Nir-Az requested a review from remibettan February 12, 2023 17:57

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit 1eafc22 into realsenseai:development Feb 16, 2023
@seebq

seebq commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

Hi Realsense team, contributor here (docs mainly!) but was looking through release notes and saw this issue and story.

What is the reference to [LRS-656] and is that an internal tracker? Would love to learn more about this feature and what it is. Does this feature mean that if you adjust auto exposure settings, currently it only affects RGB and not the IR Stereo depth? Happy to read more somewhere else.

Also noticed quick typo in the Matlab source, I can open a PR for it, I don't use it, but saw this misspelling of exposure:

https://github.com/Nir-Az/librealsense/blob/44c9e204ebfc24c6e3069f4a784964c83781fda9/wrappers/matlab/option.m#L96

Would you like a PR for this quick fix and some docs on this?

@Nir-Az

Nir-Az commented Dec 17, 2023

Copy link
Copy Markdown
Collaborator Author

Hi @seebq ,
Thanks for your interest.

What is the reference to [LRS-656] and is that an internal tracker?

Yes, we keep track in an internal system

Would love to learn more about this feature and what it is

The accelerated AE is only for the depth stream and only relevant for D455 at the moment,
this is an improved algorithm that is faster than the previous one and should output a more accurate result.
On this PR I also did some cosmetics and renamed the color AE to really state color so users (and developers) can distinguish between them.

About the type, nice catch! feel free to open a PR for that, sounds like a valid fix :)

@seebq

seebq commented Dec 18, 2023

Copy link
Copy Markdown
Contributor

We are excited to try this. We have a couple hundred D455s in the wild using outdoor stereo depth, and interested in what the accelerated auto exposure will do.

Specifically hope to improve this issue at this timestamp in my video of a limitation with our D455 stereo depth algorithm:

https://youtu.be/ZFFVW7X0i1o?t=81

We've tried a few things with autoexposure regions, and we have an IR filter on these cameras....

@Nir-Az
Nir-Az deleted the add_new_AE branch September 30, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants