KW - null pointer checks added - #11469
Merged
Nir-Az merged 4 commits intoFeb 23, 2023
Merged
Conversation
Nir-Az
reviewed
Feb 21, 2023
|
|
||
| #include "sensor.h" | ||
|
|
||
| #include "api.h" |
Collaborator
There was a problem hiding this comment.
Please do not mix api with internal source code.
This macro is only used on API, and if you search the code you can verify it.
Please use other methods to do so.. if (!...)
Contributor
Author
There was a problem hiding this comment.
OK, Done.
Can I leave api usage in the "stream.h" file? I see we have usages of this macro there.
Collaborator
There was a problem hiding this comment.
- I still see the include here
- Where do you see a usage of this macro on
stream.h?
Contributor
Author
There was a problem hiding this comment.
Sorry, not in the stream.h, in the rs.cpp.
Collaborator
There was a problem hiding this comment.
rs.cpp can include the api.h
The "if" statements added
Tamir91
force-pushed
the
kw_development_validation
branch
from
February 22, 2023 13:40
0913c2e to
6d89576
Compare
Nir-Az
reviewed
Feb 22, 2023
The code format was refactored back to what it was before. The api.h include removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking on [LRS-696]