Skip to content

Move stuff to and from common DS - #11479

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Nir-Az:common_gvd
Feb 26, 2023
Merged

Move stuff to and from common DS#11479
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Nir-Az:common_gvd

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Feb 23, 2023

Copy link
Copy Markdown
Collaborator

Continue [LRS-674]

Comment thread src/ds/ds-private.h Outdated
{ 0xf6c3c3d1, 0x5cde, 0x4477,{ 0xad, 0xf0, 0x41, 0x33, 0xf5, 0x8d, 0xa6, 0xf4 } } };

const uint32_t REGISTER_CLOCK_0 = 0x0001613c;
const int REGISTER_CLOCK_0 = 0x0001613c;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get it back

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, let's discuss why CppCheck didn't catch it, I got an idea.

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one comment

@Nir-Az
Nir-Az requested a review from remibettan February 26, 2023 09:43

@remibettan remibettan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit 2c85f7f into realsenseai:development Feb 26, 2023
@Nir-Az
Nir-Az deleted the common_gvd branch September 30, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants