RS-Viewer : metadata scrollbar added by Tamir91 · Pull Request #11637 · realsenseai/librealsense

Tamir91 · 2023-03-30T13:32:58Z

Tracked on [LRS-714]

The scrollbar was created for metadata view mode.

Nir-Az · 2023-04-02T11:14:43Z

Please also rebase development so we can see LibCI works

Nir-Az · 2023-04-02T11:21:36Z

Please also see a diff between key height and value height

Nir-Az · 2023-04-09T18:22:09Z

    {
        auto zoom_val = 1.f;
-        if (stream_rect.contains(g.cursor))
+        if (stream_rect.contains(g.cursor) && !show_metadata)


Add a comment please

Now I see, you placed a comment 500 lines above.
Please add a comment here.
And the main reason I wanted a comment is to explain why we only calculate the mouse scroll for zoom when we don't have metadata.
Something like:

`We allow scrolling for zoom in/out when no metadata is on. If we have metadata on it will scroll the metadata

Oh, my bad. Those lines look a little similar...

Still missing comment.
Allow mouse scrolling for zoom when not displaying scrollable metadata

The comment was added.

Nir-Az

Overall it looks great.
Just added a few questions and comment that may help the code to be more readable

Tamir91 · 2023-04-13T07:11:06Z

Please also see a diff between key height and value height

fixed

Nir-Az · 2023-04-13T17:46:20Z

OK a few things:

Please fix compilation warning:
stream-model.cpp(777,48): warning C4244: 'argument': conversion from 'double' to 'const __int64', possible loss of data
from stream_model::draw_stream_metadata(...)
Please use the reference code I send by mail for how to draw a scrollable background and restore the old UI behavior including the smooth rectangle

            // Draw a smooth rectangle background for each label
            // When we draw multiple rectangles with a shorter pixel on w & h is darker the inside rectangle
            for (auto i = 3; i > 0; i--)
                ImGui::GetWindowDrawList()->AddRectFilled(
                    { screen_pos.x + 10 - i, line_y - i },
                    { screen_pos.x + 10 + size.x + i, line_y + size.y + i },
                    ImColor( alpha( sensor_bg, 0.1f ) ) );

use the same background for text, values, and no md labels as it was before.

See running example:
https://user-images.githubusercontent.com/64067618/231841869-5c55df78-a5d7-492b-b840-d36f51803c34.mp4

Nir-Az · 2023-04-27T14:22:32Z

-                    rsutils::string::from() << std::setprecision(2) << std::fixed << view_fps.get_fps(),
-                    "Viewer FPS captures how many frames the application manages to render.\n"
-                    "Frame drops can occur for variety of reasons." });
+        const std::string no_md = "no md";


Please verify that the use case of not having metadata looks OK too.
You can use @remibettan help to remove the metadata from the registry and verify it looks OK as it was on an old viewer code

Nir-Az · 2023-04-27T14:27:31Z

            || (profile.stream_type() == RS2_STREAM_POSE);

+        // This scope contains a logic behavior of mouse on viewport when metadata not visible for user.
        if (stream_rect.contains(mouse.cursor) && !non_visual_stream && !show_metadata)


Curser behavior on visual stream with no metadata on

Tamir91 · 2023-05-01T10:24:49Z

Fixed with if (at.name == "") continue; line.

Tamir91 requested a review from Nir-Az March 30, 2023 13:33

Nir-Az changed the title ~~scrollbar created~~ RS-Viewer : metadata scrollbar added Mar 30, 2023

Nir-Az reviewed Apr 2, 2023

View reviewed changes