Skip to content

Allow change AE type while not streaming (even if AE is on) - #11699

Merged
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Nir-Az:update_ae_type
Apr 19, 2023
Merged

Allow change AE type while not streaming (even if AE is on)#11699
Nir-Az merged 2 commits into
realsenseai:developmentfrom
Nir-Az:update_ae_type

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

Tracked on [DSO-18943]

@Nir-Az
Nir-Az requested a review from maloel April 18, 2023 16:51
@Nir-Az

Nir-Az commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator Author

@maloel UT change is coming.. I want to see it's failing first.

Update # 1:
It will not fail as it only runs on FW >= 5.15...
I will run the test locally and update it
Update # 2:
Done
Log before test update:

Verify cannot set when auto exposure on
-E- Traceback (most recent call last):
  File "C:\Work\Git\librealsense\unit-tests\live/d400/test-depth_ae_mode.py", line 33, in <module>
    test.check_equal(depth_sensor.get_option(rs.option.auto_exposure_mode), REGULAR)
    left  : 1.0
    right : 0.0
Test failed


depth_sensor.register_option(
RS2_OPTION_DEPTH_AUTO_EXPOSURE_MODE,
std::make_shared< gated_option >( depth_auto_exposure_mode, options_and_reasons ) );

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the gating be dependent on the FW version?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gated was removed as discussed

@Nir-Az
Nir-Az merged commit e9a3095 into realsenseai:development Apr 19, 2023
Nir-Az added a commit to Nir-Az/librealsense that referenced this pull request Apr 19, 2023
…aming (even if AE is on)

(cherry picked from commit e9a3095)
@Nir-Az
Nir-Az deleted the update_ae_type branch September 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants