Formats conversion - #11714
Merged
Merged
Conversation
…registers extrinsics with not final ID
…ers. Sensor registers active converters options
OhadMeir
marked this pull request as ready for review
May 1, 2023 18:53
Nir-Az
reviewed
May 1, 2023
…alsense into formats_conversion
Nir-Az
reviewed
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
OhadMeir
commented
May 4, 2023
Nir-Az
reviewed
May 7, 2023
Nir-Az
reviewed
May 8, 2023
Nir-Az
reviewed
May 8, 2023
Nir-Az
reviewed
May 8, 2023
| const auto&& resolved_req = resolve_requests(requests); | ||
| _formats_converter.prepare_to_convert( requests ); | ||
|
|
||
| const auto & resolved_req = _formats_converter.get_active_source_profiles(); |
Collaborator
There was a problem hiding this comment.
I wonder if we should add a resolve_requests function that calls this 2 new functions.
IMO resolve_request is a well known function in the SDK.
I remember Evgeni always telling me Try debugging the resolve_request function.
Contributor
Author
There was a problem hiding this comment.
As discussed, no need for this function.
OhadMeir
force-pushed
the
formats_conversion
branch
from
May 11, 2023 08:35
f1b3fe9 to
e9e33e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull conversion code out of
synthetic_sensor.There was some refactoring of names and other small bits, but the logic remains the same.
IMO, this class needs major refactoring, in next PRs.
There are many code lines that are not related directly to the conversion, but rather fix behavior of other parts of the code. In addition there are assumptions on the call timing to the different functions, and some workarounds when calling functions without all the needed data.