Adlp metadata - #11822
Merged
Merged
Conversation
remibettan
approved these changes
May 21, 2023
remibettan
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Please run this code over jetson before merging it.
dmipx
commented
May 22, 2023
| if ((_dev.cap.capabilities & V4L2_CAP_VIDEO_CAPTURE_MPLANE) && !is_platform_jetson()) | ||
| { | ||
| /* Sakari patch for videodev2.h. This structure will be within kernel > 6.4 */ | ||
| struct v4l2_meta_format { |
Author
There was a problem hiding this comment.
done. @Nir-Az
this is union with 200 bytes so we don't care about some integers appended.
struct v4l2_format {
__u32 type;
union {
struct v4l2_pix_format pix; /* V4L2_BUF_TYPE_VIDEO_CAPTURE */
struct v4l2_pix_format_mplane pix_mp; /* V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE */
struct v4l2_window win; /* V4L2_BUF_TYPE_VIDEO_OVERLAY */
struct v4l2_vbi_format vbi; /* V4L2_BUF_TYPE_VBI_CAPTURE */
struct v4l2_sliced_vbi_format sliced; /* V4L2_BUF_TYPE_SLICED_VBI_CAPTURE */
struct v4l2_sdr_format sdr; /* V4L2_BUF_TYPE_SDR_CAPTURE */
struct v4l2_meta_format meta; /* V4L2_BUF_TYPE_META_CAPTURE */
__u8 raw_data[200]; /* user-defined */
} fmt;
};
dmipx
force-pushed
the
adlp-metadata
branch
2 times, most recently
from
May 24, 2023 11:53
ad26ef4 to
cc0f189
Compare
added 4 commits
May 24, 2023 14:57
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Metadata structure will be changed in future kernel releases, expected from version > 6.4. This patch helps avoid system header file change with Sakari metadata patch. Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Author
done. works fine. |
Author
|
@Nir-Az can we merge? |
Nir-Az
approved these changes
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set metadata configuration.
Need to add md structure patch for LibCI.
Fix udev rules for mipi dfu.