Remove L500 - #12002
Merged
Merged
Conversation
Contributor
Author
maloel
marked this pull request as ready for review
July 16, 2023 11:39
Collaborator
|
Matching Win-Installer PR? |
Contributor
Author
Nope. Build succeeded. |
Nir-Az
reviewed
Jul 16, 2023
|
|
||
| namespace librealsense | ||
| { | ||
| // We keep the L500 recovery identification to not confuse it with D400 |
Collaborator
There was a problem hiding this comment.
I vote to remove this too.
If I recall, the problem was that L515 With oud DFU on USB2 reported D400 recovery.
This mechanism protect flashing the D400 flash to it.
This is a very rare case and on this release we will even say we do not support L515..
Contributor
Author
There was a problem hiding this comment.
But there is a chance that someone will brick their L515 in recovery mode.
If you're sure...
Nir-Az
reviewed
Jul 16, 2023
| { | ||
| camera_mesh.push_back(load_model(uncompress_d415_obj)); | ||
| camera_mesh.push_back(load_model(uncompress_d435_obj)); | ||
| camera_mesh.push_back(load_model(uncompress_L515_obj)); |
Collaborator
There was a problem hiding this comment.
On this file please also change this:
if (starts_with(dev_name, "Intel RealSense L5")) index = 2;
if (starts_with(dev_name, "Intel RealSense D45")) index = 3;
to this:
if (starts_with(dev_name, "Intel RealSense D45")) index = 2;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-615]