CMake: Use plain add_library - #12003
Merged
Merged
Conversation
Collaborator
|
@autoantwort Thanks for the PR. I have got 2 requested.
Can you please add this as a comment above the new line? |
autoantwort
force-pushed
the
less-code-2
branch
from
August 6, 2023 09:40
2bcc8a7 to
016d4fa
Compare
Author
|
Done :) |
Nir-Az
self-requested a review
August 6, 2023 18:20
Nir-Az
approved these changes
Aug 6, 2023
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
"Less is more"
CI failures doesn't look related.
Thanks for the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does the same with less code.