Refactor Windows documentation - #12013
Conversation
1. A title was changed. 2. A Cmake screenshot was changed. 2. Block with Windows 8.1 removed.
| **Note:** Due to the USB 3.0 translation layer between native hardware and virtual machine, the librealsense team does not recommend or support installation in a VM. | ||
|
|
||
| librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017: | ||
| librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017 / 2019: |
There was a problem hiding this comment.
Please verify the minimum cmake version , I dont think it's 3.8 today
There was a problem hiding this comment.
Please verify the minimum cmake version , I dont think it's 3.8 today
I scanned entire repo and found that a lowest CMake version is 2.8.3. (third party dependency)
So I need write 2.8.3 in the guide?
There was a problem hiding this comment.
Which 3-rd party? seems too low.
There was a problem hiding this comment.
C:\Users\tyurovs\repos\librealsense\src\gl\CMakeLists.txt (1 hit)
Line 4: cmake_minimum_required(VERSION 2.8.9...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\libusb\CMakeLists.txt (1 hit)
Line 4: cmake_minimum_required(VERSION 2.8.3)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\CMakeLists.txt (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.9...3.20.5)
C:\Users\tyurovs\repos\librealsense\tools\rosbag-inspector\CMakeLists.txt (1 hit)
Line 4: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\console_bridge\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\cpp_common\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\rosbag_storage\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\roscpp_serialization\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\roscpp_traits\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\roslz4\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
C:\Users\tyurovs\repos\librealsense\third-party\realsense-file\rosbag\rostime\config.cmake (1 hit)
Line 1: cmake_minimum_required(VERSION 2.8.3...3.20.5)
There was a problem hiding this comment.
Make sure someone use those cmake files, I bet not.
|
|
||
| ## Windows 8.1: | ||
| When working on Windows 8.1, make sure you have [KB3075872](https://support.microsoft.com/en-us/kb/3075872) and [KB2919355](https://support.microsoft.com/en-us/kb/2919355) installed. These patches are addressing issues specific to 8.1 video drivers, that were later resolved in Windows 10. | ||
| Don't forget to check `BUILD_EXAMPLES` if you wish to use librealsense samples. |
There was a problem hiding this comment.
Down in the document please update according to this:
Windows 10 (Build 15063 or later, 17763+ recommended) and Windows 11
The winver image needs to change too
There was a problem hiding this comment.
Windows 10 SDK version 1809 | 10.0.17763.0 is being validated by RS.
Lets write only this
Windows 10 (Build 15063 or later, 17763+ recommended) and Windows 11
Instead of both and give this screenshot
Thanks
There was a problem hiding this comment.
A build number and screenshot updated.
|
one more thing, please check the option"Allow desktop apps to access your camera" should be turned on in Setting -> Privacy -> Camera for Windows. |
| **Note** In case of multiple WinSDK version installed, CMake automatically selects the latest version of SDK. In some cases, however, the automatic selection may fail. Then you need to manually retarget the solution for the proper WinSDK version: | ||
|  | ||
|
|
||
| **Note** Turn on "Allow desktop apps to access your camera" in Windows OS (Setting -> Privacy -> Camera). No newline at end of file |
There was a problem hiding this comment.
If the camera is not recognized by the SDK, make sure that "Allow desktop apps to access your camera" setting is set to on in Windows OS (Setting -> Privacy -> Camera)
|
The WinSDK is 10 (10.0.15063) according: |
This was wriiten at May/2018. |
winver png updated issue table created windows build number updated
| **Note:** Due to the USB 3.0 translation layer between native hardware and virtual machine, the librealsense team does not recommend or support installation in a VM. | ||
|
|
||
| librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017: | ||
| librealsense shall be built on Windows using [CMake v3.8+](https://cmake.org/download/) and Visual Studio 2015 / 2017 / 2019 / 2022: |
There was a problem hiding this comment.
Also we know Cmake 3.8 is not supported, we need to make sure which one is supported and list it
There was a problem hiding this comment.
Also we know Cmake 3.8 is not supported, we need to make sure which one is supported and list it
According the test that we performed CMake 3.14 is minimal supported version.
Are you think we need perform other test to validate it? Maybe, install CMake 3.13 locally and build?
|
Added GHA test #12118 that checks minimal CMake supporting version on Linux. |
|
@maloel can you help review + spell check? |
|
Looks good from my side |
Tracked on [LRS-832].