Port test record-software-device to python - #12040
Merged
Nir-Az merged 2 commits intoAug 13, 2023
Merged
Conversation
Nir-Az
reviewed
Jul 26, 2023
| depth_intrinsics.width = W | ||
| depth_intrinsics.height = H | ||
| depth_intrinsics.ppx = float(W/2) | ||
| depth_intrinsics.ppy = H/2 |
Collaborator
There was a problem hiding this comment.
ppx and ppy are same type.
How come only one need float casting and the other not?
Nir-Az
reviewed
Jul 26, 2023
| @@ -0,0 +1,143 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
Collaborator
There was a problem hiding this comment.
Can we maybe split the logic into functions and add some comments.
It will help understand the flow..
prepare a depth image..
prepare a motion image
record frames
play frames
compare_frames (original, recorded)
something like that.. will look much better IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRS-843