Skip to content

Dev with hkr base - #12041

Merged
maloel merged 7 commits into
realsenseai:developmentfrom
remibettan:dev-with-hkr-base
Aug 2, 2023
Merged

Dev with hkr base#12041
maloel merged 7 commits into
realsenseai:developmentfrom
remibettan:dev-with-hkr-base

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

Tracked by: LRS-839

@remibettan
remibettan requested review from Nir-Az and maloel July 26, 2023 10:17
Comment thread src/ds/d500/d500-color.h Outdated
@maloel

maloel commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

I'm seeing:
3 compilation warnings found; 1 expected
In the Windows build. Can you check, please?

Comment thread include/librealsense2/h/rs_option.h
Comment thread include/librealsense2/h/rs_sensor.h
Comment thread src/ds/d500/d500-color.cpp
Comment thread src/ds/d500/d500-color.cpp
Comment thread src/ds/d500/d500-device.cpp
Comment thread src/ds/d500/d500-device.cpp
Comment thread src/ds/d500/d500-options.cpp
Comment thread src/ds/d500/d500-options.h
Comment thread wrappers/tensorflow/.idea/.name Outdated
@Nir-Az

Nir-Az commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

I see
third-party/json.hpp
This file addition, looks like a mistake as now it is cloned during cmake

Comment thread src/ds/d500/d500-color.h Outdated
@remibettan
remibettan requested review from Nir-Az and maloel August 1, 2023 12:33
@maloel
maloel merged commit 4666b29 into realsenseai:development Aug 2, 2023

@maloel maloel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remibettan
remibettan deleted the dev-with-hkr-base branch July 29, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants